* [PATCH] staging: media: imx: imx7-media-csi: Fix parenthesis alignment
@ 2022-10-24 15:07 Gabriel Lima Luz
2022-10-24 15:12 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Lima Luz @ 2022-10-24 15:07 UTC (permalink / raw)
To: Rui Miguel Silva, Laurent Pinchart, Steve Longerbeam,
Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-media, linux-staging, linux-arm-kernel,
linux-kernel, outreachy
Cc: Gabriel Lima Luz
Adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: Alignment should match open parenthesis
Signed-off-by: Gabriel Lima Luz <lima.gabriel.luz@gmail.com>
---
drivers/staging/media/imx/imx7-media-csi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
index cbc66ef0eda8..9ad7205a3f2f 100644
--- a/drivers/staging/media/imx/imx7-media-csi.c
+++ b/drivers/staging/media/imx/imx7-media-csi.c
@@ -1704,7 +1704,7 @@ static int imx7_csi_init_cfg(struct v4l2_subdev *sd,
mf->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(mf->colorspace);
mf->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(mf->colorspace);
mf->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(!cc->yuv,
- mf->colorspace, mf->ycbcr_enc);
+ mf->colorspace, mf->ycbcr_enc);
csi->cc[i] = cc;
}
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: imx: imx7-media-csi: Fix parenthesis alignment
2022-10-24 15:07 [PATCH] staging: media: imx: imx7-media-csi: Fix parenthesis alignment Gabriel Lima Luz
@ 2022-10-24 15:12 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2022-10-24 15:12 UTC (permalink / raw)
To: Gabriel Lima Luz
Cc: Rui Miguel Silva, Steve Longerbeam, Philipp Zabel,
Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-media, linux-staging, linux-arm-kernel,
linux-kernel, outreachy
Hi Gabriel,
Thank you for the patch.
On Mon, Oct 24, 2022 at 12:07:44PM -0300, Gabriel Lima Luz wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Gabriel Lima Luz <lima.gabriel.luz@gmail.com>
> ---
> drivers/staging/media/imx/imx7-media-csi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
> index cbc66ef0eda8..9ad7205a3f2f 100644
> --- a/drivers/staging/media/imx/imx7-media-csi.c
> +++ b/drivers/staging/media/imx/imx7-media-csi.c
> @@ -1704,7 +1704,7 @@ static int imx7_csi_init_cfg(struct v4l2_subdev *sd,
> mf->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(mf->colorspace);
> mf->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(mf->colorspace);
> mf->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(!cc->yuv,
> - mf->colorspace, mf->ycbcr_enc);
> + mf->colorspace, mf->ycbcr_enc);
I think this is a valid exception to the coding style, to increase
readability by avoiding long lines. Otherwise, I'd wrap it as
mf->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(!cc->yuv,
mf->colorspace,
mf->ycbcr_enc);
>
> csi->cc[i] = cc;
> }
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-24 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 15:07 [PATCH] staging: media: imx: imx7-media-csi: Fix parenthesis alignment Gabriel Lima Luz
2022-10-24 15:12 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox