* [PATCH v2] staging: media: imx: imx7-media-csi: Fix parenthesis alignment
@ 2022-10-25 0:12 Gabriel Lima Luz
2022-10-25 5:01 ` Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Lima Luz @ 2022-10-25 0:12 UTC (permalink / raw)
To: Rui Miguel Silva, Laurent Pinchart, Steve Longerbeam,
Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-media, linux-staging, linux-arm-kernel,
linux-kernel, outreachy
Cc: Gabriel Lima Luz
Adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: Alignment should match open parenthesis
Signed-off-by: Gabriel Lima Luz <lima.gabriel.luz@gmail.com>
---
Altered changes acording to feedback for a more readable code
drivers/staging/media/imx/imx7-media-csi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
index cbc66ef0eda8..b241b68f456c 100644
--- a/drivers/staging/media/imx/imx7-media-csi.c
+++ b/drivers/staging/media/imx/imx7-media-csi.c
@@ -1704,7 +1704,8 @@ static int imx7_csi_init_cfg(struct v4l2_subdev *sd,
mf->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(mf->colorspace);
mf->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(mf->colorspace);
mf->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(!cc->yuv,
- mf->colorspace, mf->ycbcr_enc);
+ mf->colorspace,
+ mf->ycbcr_enc);
csi->cc[i] = cc;
}
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: media: imx: imx7-media-csi: Fix parenthesis alignment
2022-10-25 0:12 [PATCH v2] staging: media: imx: imx7-media-csi: Fix parenthesis alignment Gabriel Lima Luz
@ 2022-10-25 5:01 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2022-10-25 5:01 UTC (permalink / raw)
To: Gabriel Lima Luz
Cc: Rui Miguel Silva, Laurent Pinchart, Steve Longerbeam,
Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-media, linux-staging, linux-arm-kernel,
linux-kernel, outreachy
On Mon, 24 Oct 2022, Gabriel Lima Luz wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> CHECK: Alignment should match open parenthesis
Here you have made a decision that is quite reasonable, but that does not
actually "Fix parenthesis alignment". This highlights an overall problem
with your log message. You say what you are "fixing", but you don't give
any explanation about why you have done what you have done. Actually the
most helpful comment was below the ---, but that will disappear when the
patch is applied.
julia
>
> Signed-off-by: Gabriel Lima Luz <lima.gabriel.luz@gmail.com>
> ---
> Altered changes acording to feedback for a more readable code
>
> drivers/staging/media/imx/imx7-media-csi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
> index cbc66ef0eda8..b241b68f456c 100644
> --- a/drivers/staging/media/imx/imx7-media-csi.c
> +++ b/drivers/staging/media/imx/imx7-media-csi.c
> @@ -1704,7 +1704,8 @@ static int imx7_csi_init_cfg(struct v4l2_subdev *sd,
> mf->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(mf->colorspace);
> mf->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(mf->colorspace);
> mf->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(!cc->yuv,
> - mf->colorspace, mf->ycbcr_enc);
> + mf->colorspace,
> + mf->ycbcr_enc);
>
> csi->cc[i] = cc;
> }
> --
> 2.34.1
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-25 18:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-25 0:12 [PATCH v2] staging: media: imx: imx7-media-csi: Fix parenthesis alignment Gabriel Lima Luz
2022-10-25 5:01 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).