From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57CBEC38A2D for ; Tue, 25 Oct 2022 11:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MbZA0FQxyvX3VqSzMpGiBwWmlu94kBlbBYQsJ9xF5zc=; b=FagkacutA3PxZG sucx7DEZ1c0Vl8NHbzs4Qs303DMiI9CztDyYO40/LSxuShuteyGtRlHJ7B/9vyNbKwEPAPAmj6vj6 hnrzZF8ih5YNZ6+YaChQ4YEYvI+LXyyG0NGkJIP693Ylgv/CIVk0oafUmBSwJwJBAw+i3q9cLacUz L1zw45XRK6DdB9iNLntpTKCPY8rsP3UfeUo/bLlPDsdi4/UM9thwIwf2r76YBaVI4WoJTQTLfAk7O Tu+mILqZZqibziyYOuAVfBbVFrdSKcLKqslfN1MEhxhTH5TjAxyuI0zUcBIaswFpa/UpGTvHUahdY ZfWiEs6mqzuVNMMBc2eA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onIJc-0052uE-QS; Tue, 25 Oct 2022 11:41:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onIJZ-0052t0-Bj for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 11:41:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E606ED6E; Tue, 25 Oct 2022 04:41:51 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3F57B3F7B4; Tue, 25 Oct 2022 04:41:44 -0700 (PDT) Date: Tue, 25 Oct 2022 12:41:41 +0100 From: Sudeep Holla To: Johan Hovold Cc: Dmitry Baryshkov , Arnd Bergmann , Mark Rutland , Lorenzo Pieralisi , Ulf Hansson , "Rafael J. Wysocki" , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, soc@kernel.org, linux-pm@vger.kernel.org Subject: Re: [RESEND PATCH v2] firmware/psci: Print a warning if PSCI doesn't accept PC mode Message-ID: <20221025114141.2my5drpjhincjons@bogus> References: <20220926110249.666813-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_044149_510710_C23DA111 X-CRM114-Status: GOOD ( 30.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 19, 2022 at 04:14:04PM +0200, Johan Hovold wrote: > On Mon, Sep 26, 2022 at 02:02:49PM +0300, Dmitry Baryshkov wrote: > > The function psci_pd_try_set_osi_mode() will print an error if enabling > > OSI mode fails. To ease debugging PSCI issues print corresponding > > message if switching to PC mode fails too. > > > > Acked-by: Mark Rutland > > Reviewed-by: Sudeep Holla > > Reviewed-by: Ulf Hansson > > Signed-off-by: Dmitry Baryshkov > > --- > > This is a replacement for [1], now moving the warning from > > psci_set_osi_mode() callers to the function iself. > > > > The patch is resent to include soc@kernel.org > > > > [1] https://lore.kernel.org/all/20220727182034.983727-1-dmitry.baryshkov@linaro.org/ > > > > --- > > drivers/cpuidle/cpuidle-psci-domain.c | 4 +--- > > drivers/firmware/psci/psci.c | 2 ++ > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > > index 3db4fca1172b..821984947ed9 100644 > > --- a/drivers/cpuidle/cpuidle-psci-domain.c > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > > @@ -124,10 +124,8 @@ static bool psci_pd_try_set_osi_mode(void) > > return false; > > > > ret = psci_set_osi_mode(true); > > - if (ret) { > > - pr_warn("failed to enable OSI mode: %d\n", ret); > > + if (ret) > > return false; > > - } > > > > return true; > > } > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > > index 9fdcb6bff403..42cae0ba10e2 100644 > > --- a/drivers/firmware/psci/psci.c > > +++ b/drivers/firmware/psci/psci.c > > @@ -164,6 +164,8 @@ int psci_set_osi_mode(bool enable) > > PSCI_1_0_SUSPEND_MODE_PC; > > > > err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); > > + if (err < 0) > > + pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); > > return psci_to_linux_errno(err); > > } > > When booting 6.1-rc1 I now see: > > [ 0.000000] psci: OSI mode supported. > [ 0.000000] psci: failed to set PC mode: -3 > > on every boot with sc8280xp, while later enabling OSI mode still works: > > [ 0.227358] CPUidle PSCI: psci_pd_try_set_osi_mode - success > [ 0.227599] CPUidle PSCI: Initialized CPU PM domain topology > > Judging from Sudeep's comment on v1: > > The platform must boot in PC mode, so even if it fails we ignore > so not sure if the logging is of much help here IMO. > > perhaps logging this as an error is not a good idea? > Sorry I have forgotten about the discussion on this already. I may contradict myself, but it the platform is misbehaving, why is it not a good idea to log it as error. It can be ignored right if it is not an issue on the platform ? My main worry is no one will turn on debug unless they are debugging and new platforms with same issues may go unnoticed while we want them to be fixed, right ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel