From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EB78C38A2D for ; Tue, 25 Oct 2022 14:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uF0h2UaIkkIulQtRr86zfzXbAK1vgOV0b+R/+LMwFWU=; b=SSUWBz0DQyVBJj AUDa8o0mG6pPR3UzLWkofPbJLZMYkd/E1tRLrGl0sga82XINVoC/Exiijn32G0xEueM8uxqWaXa4h hSlGIXgQmqXHI5OHJQYtjAyExqT3h7+C28vwrotGa42jDRppHK+9TQffdm2lIvUvgiXdko/fPTSYj RzLPY4mIJEn+sUvgSZN4vxtW1mPa+iRv6UGK/1I6P2TlDfb79bypZy3xuo7xRYmVo3Y3xm5kW6hGX OFI0qSb3GO7jCZhmHdgn/FcvUIWAZM37373WY7rnKJgXVycfI4cBxDfjecPVUeu3Z5Dv4YHWuEmIG rX1MuRzKRSvFFB5M3saw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onKmA-005kfJ-7o; Tue, 25 Oct 2022 14:19:32 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onKls-005kbX-Qe for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 14:19:15 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 9B6393200945; Tue, 25 Oct 2022 10:19:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 25 Oct 2022 10:19:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tyhicks.com; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666707545; x=1666793945; bh=VAcJBhh2sQ gVR7nnkpb9hlrFCM8vLrpSb6p4FzyesHo=; b=Li4SP42EFHvKsjN/pgLUUiom19 95RnptbYew2zbJE3lgoONscmw6SFDad7yK+0+8un00w+DkuB8lIgfd11S2FjGiIN 3RdyMogWcvSAxkRook9g9yUPiBt1skDbFSvlNDzA3ImNL0lgCY/KZ3gEQ906GJgD 7FE43oIKcavi6BXOEyNI1TvF+ONOykAzkwEtZCUyP12z7Ovp1qLBHx+bHr0NpWmZ dirIdrlnWFJOnUmvmgg38oxLc5JxLjP9NHAfl+yeh5QhwURDfgueJny5dd7YDbp8 C3jdKlfxJ4fjqPnLF6BeaEX3SluMQtiSY/tDPmsmPOCWVJVi1eMCD222QqwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666707545; x=1666793945; bh=VAcJBhh2sQgVR7nnkpb9hlrFCM8v LrpSb6p4FzyesHo=; b=SEBA5Gm9Vbpv8kQE79oVy1cVjXFzTGCO4uRMJwEIqNe8 qyXLp+wioEAtYfXO221Ghued3zD+TG+veelkx03mpmo0OoHgGcPkeaMy8xe7T/gE hEGR/UMxk6N2wwTHkak3wsSRDnafVyCeFl24NVpVsB9h0LInnSnQx+WrIWsonI1i k7P47YCBFGEic+mSoD7GEbSnFUXmanHLpdCO7YWSfYExw/+MgJq+FZf++f6d17Fl 211wbFoO2yTSlepQly6D+jyX9h4D0d/JpOzU2SAkJSbACzFz/tzXRW1LAK8AWD4j aP2mmfql/DOrYiibccJ9lWp6g31rAXOTCXhYZmDKNg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtddtgdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpedfvfihlhgv rhcujfhitghkshculdfoihgtrhhoshhofhhtmddfuceotghouggvsehthihhihgtkhhsrd gtohhmqeenucggtffrrghtthgvrhhnpeehieeiueevgfetlefhjeekleeutddtudelveev hfekgefhhffhtedtffehuedvteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegtohguvgesthihhhhitghkshdrtghomh X-ME-Proxy: Feedback-ID: i78e14604:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Oct 2022 10:19:04 -0400 (EDT) Date: Tue, 25 Oct 2022 09:18:54 -0500 From: "Tyler Hicks (Microsoft)" To: Marc Zyngier Cc: Mark Rutland , Daniel Lezcano , Thomas Gleixner , Vijay Balakrishna , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Fix event stream param in Kconfig Message-ID: <20221025141854.22ppd7mw3vb6esgr@sequoia> References: <20221024195118.871907-1-code@tyhicks.com> <86pmegdwug.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86pmegdwug.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_071913_280896_609A19D2 X-CRM114-Status: GOOD ( 26.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-10-25 11:24:55, Marc Zyngier wrote: > Hi Tyler, > > On Mon, 24 Oct 2022 20:51:18 +0100, > Tyler Hicks wrote: > > > > From: "Tyler Hicks (Microsoft)" > > > > Fix the event stream timer command line parameter name that's documented > > in the Kconfig description for CONFIG_ARM_ARCH_TIMER_EVTSTREAM. It > > didn't match the command line parameter name that's actually honored in > > the source code. > > > > Reported-by: Vijay Balakrishna > > Fixes: 46fd5c6b3059 ("clocksource/drivers/arm_arch_timer: Control the evtstrm via the cmdline") > > Cc: stable@vger.kernel.org > > No, this really doesn't deserve a Cc: stable. This bit may be wrong, > but we have the correct information in the kernel-parameters.txt file, > which is authoritative AFAIC. Thanks for the review! I added the stable tag because it caused an actual waste of time in an investigation. Upon discovering this option, I didn't notice the subtle difference in cmdline parameter name from the Kconfig, to the kernel-parameters.txt file and the code. I ran long-running stress tests with the incorrect parameter name copied and pasted from the Kconfig. This error resulted in a bad data point in the investigation and it took a second set of eyes (Vijay's) to uncover my mistake days later when we were trying to reconcile the bad data point with other good data points. It is no big deal if it is merged with the tag dropped but I wanted to provide my reasoning of why I personally felt this was a more than just a comment typo fix or something along those lines. Thanks, again! Tyler > > > Signed-off-by: Tyler Hicks (Microsoft) > > --- > > drivers/clocksource/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > index 4469e7f555e9..dcc274460973 100644 > > --- a/drivers/clocksource/Kconfig > > +++ b/drivers/clocksource/Kconfig > > @@ -315,7 +315,7 @@ config ARM_ARCH_TIMER_EVTSTREAM > > executing the wfe instruction at a frequency represented as a > > power-of-2 divisor of the clock rate. The behaviour can also be > > overridden on the command line using the > > - clocksource.arm_arch_timer.evtstream parameter. > > + clocksource.arm_arch_timer.evtstrm parameter. > > The main use of the event stream is wfe-based timeouts of userspace > > locking implementations. It might also be useful for imposing timeout > > on wfe to safeguard against any programming errors in case an expected > > With this tag dropped, > > Acked-by: Marc Zyngier > > M. > > -- > Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel