From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C93BEC38A2D for ; Wed, 26 Oct 2022 17:55:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y+uNzS6X9G+lSFJluew5moRT425Sbz6XZCesVM7YP1A=; b=B46lXt5rN0sIBL paJo6Qq/JF6bz/jU4psGAhM3etmL21M8I+mWJdkKy20Hx0axh/L4T6e9+cfzXl5x4rt4WJb6IdA8M DQ9dWmazzemNj/I5VTWAKUCz+FxjrZQcIepT7pST6YfCMZHvm/c3IDuvcbiXr1S/ewrPCkdkbXwYl BgASk/hioeZXZffWM1o88dO1cZQDu3/lWZ2vRGk+UCcmX4mXF7W3iZ3q8xGr+SbNRWlX7EG33GfM2 +0dptPzmlGfa4Dpgrj9GeOgS7YWK3tLZ2gpcVjDaD1KD9kcxfVcLvd8gaxudCY4Yqjvj75n1GIexk SbUVeu8wIcMtbGDtFJVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onkbF-00AS1i-PN; Wed, 26 Oct 2022 17:53:57 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onkbC-00AS0q-JM for linux-arm-kernel@lists.infradead.org; Wed, 26 Oct 2022 17:53:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cqxi+n3MmD7NBGgLs1eKTWF/KKLqUV5WI593klf6b/o=; b=voACzILOGDgQCDl04V355uNyQH 0Et67ksxu5E206x3I3uNqsAjFWF7LyAUHsotkbQz3M8LL9gQx+HA9gETynR+UQvMMzbQ5JIsPaRha lSEawjnn8MGZVhgiGbOaq85FedWhlbrnVAVGsvsRP7NiBWH5yb7gQ5WKVSBDBveJ4YPj6eewuWtz/ USNUB27FVNZfK8qCI+LNW5N0n02+J6PAdBnxkqOomsnHJ84FeZDRNXqHMAQgELdbi3qu5m2CgZhvH CZ84onrW/JB2uKCcgdczMfeMAoJLyKXdWZ90zy06XBhtgC+5Yy5OR4n/7YcrDtWN5rpjPPt3miK2l 4GiXZSFw==; Received: from p200300ccff073f001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff07:3f00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1onkb4-0001AD-2t; Wed, 26 Oct 2022 19:53:46 +0200 Date: Wed, 26 Oct 2022 19:53:44 +0200 From: Andreas Kemnade To: Marco Felsch Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alistair Francis Subject: Re: [PATCH] arm: dts: imx: e60k02: Add touchscreen Message-ID: <20221026195344.7fda0b44@aktux> In-Reply-To: <20221026174300.6f5l6lsg5msrz6op@pengutronix.de> References: <20221026173015.1172816-1-andreas@kemnade.info> <20221026174300.6f5l6lsg5msrz6op@pengutronix.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221026_105354_826753_10B0F4F6 X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marco, On Wed, 26 Oct 2022 19:43:00 +0200 Marco Felsch wrote: > Hi Andreas, > > On 22-10-26, Andreas Kemnade wrote: > > Add the touchscreen now, since the driver is available. > > I pulled input/next and grep'ed for the compatible but found nothing. > Where should the driver be available? > Copying the link again. I have the guts feeling that it is near being accepted: https://lore.kernel.org/linux-devicetree/20221026114908.191472-1-alistair@alistair23.me/T/#t Regards, Andreas > Regards, > Marco > > > Signed-off-by: Andreas Kemnade > > --- > > runtime/dtbs_check depends > > https://lore.kernel.org/linux-devicetree/20221026114908.191472-1-alistair@alistair23.me/T/#t > > arch/arm/boot/dts/e60k02.dtsi | 12 +++++++++++- > > arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 14 ++++++++++++++ > > arch/arm/boot/dts/imx6sll-kobo-clarahd.dts | 14 ++++++++++++++ > > 3 files changed, 39 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/e60k02.dtsi b/arch/arm/boot/dts/e60k02.dtsi > > index 935e2359f8df..4f36cc181a52 100644 > > --- a/arch/arm/boot/dts/e60k02.dtsi > > +++ b/arch/arm/boot/dts/e60k02.dtsi > > @@ -104,7 +104,17 @@ &i2c2 { > > clock-frequency = <100000>; > > status = "okay"; > > > > - /* TODO: CYTTSP5 touch controller at 0x24 */ > > + touchscreen@24 { > > + compatible = "cypress,tt21000"; > > + reg = <0x24>; > > + pinctrl-names = "default","sleep"; > > Does the driver handle the different states? > > > + pinctrl-0 = <&pinctrl_cyttsp5_gpio>; > > + pinctrl-1 = <&pinctrl_cyttsp5_gpio_sleep>; > > + interrupt-parent = <&gpio5>; > > + interrupts = <6 IRQ_TYPE_EDGE_FALLING>; > > + reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; > > + vdd-supply = <&ldo5_reg>; > > + }; > > > > /* TODO: TPS65185 PMIC for E Ink at 0x68 */ > > > > diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts > > index e3f1e8d79528..82d9ed91df92 100644 > > --- a/arch/arm/boot/dts/imx6sl-tolino-shine3.dts > > +++ b/arch/arm/boot/dts/imx6sl-tolino-shine3.dts > > @@ -52,6 +52,20 @@ &iomuxc { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_hog>; > > > > + pinctrl_cyttsp5_gpio: cyttsp5_gpio_grp { > > According the below code it should be: > pinctrl_cyttsp5_gpio: cyttsp5-gpiogrp { > > and.. > > > + fsl,pins = < > > + MX6SL_PAD_SD1_DAT3__GPIO5_IO06 0x17059 /* TP_INT */ > > + MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x10059 /* TP_RST */ > > + >; > > + }; > > + > > + pinctrl_cyttsp5_gpio_sleep: cyttsp5_gpio_grp_sleep { > > > pinctrl_cyttsp5_gpio_sleep: cyttsp5-gpio-sleepgrp { > > > Regards, > Marco > > > + fsl,pins = < > > + MX6SL_PAD_SD1_DAT3__GPIO5_IO06 0x10059 /* TP_INT */ > > + MX6SL_PAD_SD1_DAT2__GPIO5_IO13 0x10059 /* TP_RST */ > > + >; > > + }; > > + > > pinctrl_gpio_keys: gpio-keysgrp { > > fsl,pins = < > > MX6SL_PAD_SD1_DAT1__GPIO5_IO08 0x17059 /* PWR_SW */ > > diff --git a/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts b/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts > > index 90b32f5eb529..d743bf4fd8e6 100644 > > --- a/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts > > +++ b/arch/arm/boot/dts/imx6sll-kobo-clarahd.dts > > @@ -62,6 +62,20 @@ &iomuxc { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_hog>; > > > > + pinctrl_cyttsp5_gpio: cyttsp5-gpiogrp { > > + fsl,pins = < > > + MX6SLL_PAD_SD1_DATA3__GPIO5_IO06 0x17059 /* TP_INT */ > > + MX6SLL_PAD_SD1_DATA2__GPIO5_IO13 0x10059 /* TP_RST */ > > + >; > > + }; > > + > > + pinctrl_cyttsp5_gpio_sleep: cyttsp5-gpiogrp-sleep { > > + fsl,pins = < > > + MX6SLL_PAD_SD1_DATA3__GPIO5_IO06 0x10059 /* TP_INT */ > > + MX6SLL_PAD_SD1_DATA2__GPIO5_IO13 0x10059 /* TP_RST */ > > + >; > > + }; > > + > > pinctrl_gpio_keys: gpio-keysgrp { > > fsl,pins = < > > MX6SLL_PAD_SD1_DATA1__GPIO5_IO08 0x17059 /* PWR_SW */ > > -- > > 2.30.2 > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel