From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BEDCFA3740 for ; Thu, 27 Oct 2022 13:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5m4Vl0RjjynRV0SSdQbV+EL0jh1m4wb8q2o0npavAvY=; b=UcxOYhagBOp0vM zUgPFXhmKaTfVYQmNXYhBP+ta2urF6LNoomDyWOB6vXmzLlWn3YyTkGmJveHsj7Eho3F2pHQ6uNVV 05YRbklcksboHf99S78adE/ueLokNEm5GMDvHoJwJTxn/1TurrvYc5JUXs1FbMvdX22sqMyKH45gg urRcZownOlUI0sV+varUsqSZ+k16U0klIWZCfUUQ02FK02CscFsFD9kp5Z8tS123cqWN1uWYKw4Ht teyXH/yX3UTKnKXWOnx0Wnudu0tsoa5rghO9HHp2MClPStA47NgIJjledvnokRUxUrDLf4f3zy77l YJP6HWOULaR1N72ebrCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oo2Ts-00DHjJ-8y; Thu, 27 Oct 2022 12:59:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oo2T6-00DHQD-7c for linux-arm-kernel@lists.infradead.org; Thu, 27 Oct 2022 12:58:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4699D23A; Thu, 27 Oct 2022 05:58:46 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5EBD3F7B4; Thu, 27 Oct 2022 05:58:38 -0700 (PDT) Date: Thu, 27 Oct 2022 13:58:36 +0100 From: Sudeep Holla To: Mark Rutland Cc: Johan Hovold , Sudeep Holla , Lorenzo Pieralisi , Ulf Hansson , Dmitry Baryshkov , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] firmware/psci: demote suspend-mode warning to info level Message-ID: <20221027125836.jlqis3qzyh232smy@bogus> References: <20221026135445.8004-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221027_055844_352988_1E70CC82 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 27, 2022 at 01:15:59PM +0100, Mark Rutland wrote: > On Wed, Oct 26, 2022 at 03:54:45PM +0200, Johan Hovold wrote: > > On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode > > during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb > > ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this > > is now logged at warning level: > > > > psci: failed to set PC mode: -3 > > > > As there is nothing users can do about the firmware behaving this way, > > demote the warning to info level and clearly mark it as a firmware bug: > > > > psci: [Firmware Bug]: failed to set PC mode: -3 > > > > Signed-off-by: Johan Hovold > > On the assumption that we don't have any latent issues in this case, this looks > ok to me, so: > > Acked-by: Mark Rutland > > Sudeep, does this reasonable to you? > > Are there any latent issues that mean we should keep this as a pr_warn()? I am fine removing it as warning but making it debug may mask the issue completely on the platforms that are using Linux itself for validation of their PSCI firmware implementation. This sounds like a good compromise instead of jumping from warning directly to debug. I just want to give a chance for platforms noticing this and working on getting their firmware fixed. So for this version: Acked-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel