From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73829FA373D for ; Thu, 27 Oct 2022 23:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/gD6FCdtTVpq4P0kPGAbc1B/zLq9tSgLlvO/++lkYMs=; b=mB7jKO06r8mYHo lZLUik0d25SsBkntjmeGNuyeNZ3H1pes5KKjyaxpTCp8quAPxivKtWeaIQrn1FWF/pnedaCNoyM49 ZNclAAQ7rxsUHF3ATA8coeUO/rllnjTrxB2V9VMRCQEYjgrXMgV+T8RkfHPsLZuvNBicWUlx1dV4w pLiJP7Io7TNXKPp1JBPzaxCGO/l/8fA8t0KdMlhUaibMJKQcFx0rueyI8YyBT9g38Pgj2L2s9eWYy T+10wrMs6iXtNRenE7lLlsCec++XTxrN8K9WnOMwEVkxATED4Ge0HIjJXxbYRN23IY00MbdH+IHwd YhgJ5lAtq1m/cyJgV3Gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooCKZ-00FEYR-KH; Thu, 27 Oct 2022 23:30:35 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooCKW-00FEXx-OZ; Thu, 27 Oct 2022 23:30:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 62872B8280A; Thu, 27 Oct 2022 23:30:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F3FAC433D6; Thu, 27 Oct 2022 23:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666913430; bh=N3/tiBBM65lbA3Kx0jToCOjz1sXOtHVXWYvgKgpiDFc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=iu6ONbFOuNtcJM4mQaxWpdNWxM/V/eSzUpZ73hpm3Qffo2BJqyPDWAqe0OR9TbNOh B6erzkAR+KYefBQnqAlUM8ofjzhedfcAsQ1QXRNpCxC8iBexmKJt0eFujzgcVORvLO ptEYjNYbC7CBC3v/yVO/a47eUK/wU08m8G/rEi0Jru8z4X302KFe3HCx/B/E2EksS1 nQm7pGTZlJCCceE2Ma/wWzDQpD5elcc16qEbDL5rxpmLWCohB4x1y9LSIGmLkgnF2M gsUfd5eWBCbTN3nxWBKyNUR8izsE3bNEJuJ0hIeYOeIqBFjs7u0ncaNsawDK/qgOYz EQRxkyggrj46w== MIME-Version: 1.0 In-Reply-To: References: <9bde77be-f4ec-11e7-e645-7c4465bcf6db@collabora.com> <5e55012567da74870e1fb2edc2dc513b5821e523.1666801017.git.daniel@makrotopia.org> <20221027214151.7F112C433D6@smtp.kernel.org> Subject: Re: [PATCH v2] clk: mediatek: fix dependency of MT7986 ADC clocks From: Stephen Boyd Cc: Matthias Brugger , Michael Turquette , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Sam Shih , Miles Chen , AngeloGioacchino Del Regno , Chen-Yu Tsai To: Daniel Golle Date: Thu, 27 Oct 2022 16:30:27 -0700 User-Agent: alot/0.10 Message-Id: <20221027233030.0F3FAC433D6@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221027_163032_965733_3206EB0E X-CRM114-Status: GOOD ( 20.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Daniel Golle (2022-10-27 16:24:35) > On Thu, Oct 27, 2022 at 02:41:49PM -0700, Stephen Boyd wrote: > > Quoting Daniel Golle (2022-10-26 09:18:07) > > > It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for > > > CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the > > > mtk-thermal and mt6577_auxadc drivers, add dependency to the clock > > > driver clk-mt7986-infracfg.c. > > > > Is this a cleanup patch? Or a pre-requisite for thermal and auxadc > > drivers? I don't understand the priority of this patch. Should I apply > > it to fix a regression? > > I'd say 'no', as AUXADC and thermal has not yet been added to > mt7986a.dtsi, also the corresponding clocks are currently still unused. > So while this commit does fix a previous commit, it doesn't have a direct > impact and will only matter once thermal and auxadc units are added to > mt7986.dtsi. Thanks! Please include these details next time. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel