From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97A3FC38A02 for ; Fri, 28 Oct 2022 17:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6OVZMNDcRI/6QPHluBeSmbwAh6/MwrHWZIbl2Di4HHs=; b=gRz912su8vs1IK P8prA8o8rhafinXpTJs+LEvUztrIeLYqNbqb6C1CjF+62H8lKiIpyMO1u4BicC97VuBcKNFXFj3Y0 eQW5EIYpIJ/CH5TVabusQDT68guk22SLYbFxqvIMIsk7RJRw5ppM2mwcVJ+fXKSovsaQD26zMH+Nk ZxPGjdtZAGIRZ0bQ4rUYoVx1ELiV0DRxy6c6b7fAfF5NajGw+QYuzC6cYVXpO9Ur2h3/VDnmourub O8ZkD73XkuIrwSrEgKPUo+MCkVifx0AKqT422fHaAhV/CgDPga9SpvCyWfpRtSbKkw6o2lybPLfAI 8UW8zVFS6F/ZaHQNX69A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooTQG-001TMa-7W; Fri, 28 Oct 2022 17:45:36 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooTQ6-001TCu-E9 for linux-arm-kernel@lists.infradead.org; Fri, 28 Oct 2022 17:45:28 +0000 Received: by mail-pl1-x62b.google.com with SMTP id io19so5444896plb.8 for ; Fri, 28 Oct 2022 10:45:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sq+4+K8W7qz9CqdPYKGdGPJUiIj89nYCMsj4hrq+PXE=; b=Qk8LjvSnKQ+nIz7iqqSWHFadvUV7NzJ6KPQ1r3p/lUiuWBKuG4/YdTl8U2LDkwWWQX ZTdEZPBQv33zkr7IS54F9tB+LCHpxqUrERaqe7kqttssTQmiUT8DJ26n3dEcMAIJPPmw 2uAFLRTwFf+091cseHU88g11bR5cZGAOVEfyg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sq+4+K8W7qz9CqdPYKGdGPJUiIj89nYCMsj4hrq+PXE=; b=idehIt3GyQYh3/w4oUX93RSdNG8Vag5gPLjLpvbtvTSbydVs3xqDv4xSHGl6PxtGrI +JAKlP/wrYdCzEL8HjKLB0jA8y0G5TQbHq/thxIEVCZAbaluC6yJvhZW0Wcqvk06bFFO HVXN1FnrKaz8JUjnCDzEG0yXnSfJJO/yF6JTldTO14fO0yWo0UbSXa9rW5x7VYHfLq1m blTtY/zSn+tyHn1LzgYTjJHRgjwRr9bo1Rq4lGQFRTIiV3Fn2ykxhM98gaY+AL5zguiY J2v6nv5o770crEqfd9GZnH5QunJOlLKr8q+Iwr1eXyedgPUta5+owxlFylTSR7BmxTN/ mTqg== X-Gm-Message-State: ACrzQf2C9kpKz4MnA6FPdUu8tgYgjfj1AVRcRM4a4GOpDJT7V02Ifwck TLybzVA+Jq3cPSIw+YXsz9jVvw== X-Google-Smtp-Source: AMsMyM5xMG3TVG7u/78SN5J7HmVo4/yAWKlp64gxV3zMh7Cx/cWT4TaKn1MTwMTg+/YXh4xKD0Cd8A== X-Received: by 2002:a17:90a:cf82:b0:20b:3525:81ec with SMTP id i2-20020a17090acf8200b0020b352581ecmr452552pju.42.1666979123537; Fri, 28 Oct 2022 10:45:23 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u8-20020a17090341c800b001866a019010sm3368538ple.97.2022.10.28.10.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 10:45:22 -0700 (PDT) Date: Fri, 28 Oct 2022 10:45:21 -0700 From: Kees Cook To: Joey Gouly Cc: Catalin Marinas , Andrew Morton , Lennart Poettering , Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= , Alexander Viro , Szabolcs Nagy , Mark Brown , Jeremy Linton , Topi Miettinen , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-abi-devel@lists.sourceforge.net, nd@arm.com, shuah@kernel.org Subject: Re: [PATCH v1 2/2] kselftest: vm: add tests for memory-deny-write-execute Message-ID: <202210281043.DFC05DEF@keescook> References: <20221026150457.36957-1-joey.gouly@arm.com> <20221026150457.36957-3-joey.gouly@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221026150457.36957-3-joey.gouly@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221028_104526_506999_60A855EF X-CRM114-Status: UNSURE ( 9.41 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 26, 2022 at 04:04:57PM +0100, Joey Gouly wrote: > +#include "../kselftest.h" I recommend using kselftest_harness.h instead; it provides much of the infrastructure that is open-coded here. But yes, testing is good; thank you! :) -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel