From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7E80ECAAA1 for ; Sun, 30 Oct 2022 17:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QwBWnHSb8GtZA9JFbUUn3Ofm8tKC/Qu384DkBRX0xSM=; b=A529xCqzoGU+yO Jpdhvnybdakgb1Fb6O0fE7nyyT2fT6RaH45KSImxmArPc+mxXZlzHSIp8d0dewVfedqtbZ7EauHKg HgssQsD7ST/RuykjySdjoN3Bhj2rFXvO+APgmW+nZgj2KgCOq4yVt0ioIUVY+3gzsPTU7Bn0j3sKm evPVyMn8P24gWZEL2T+xdoHoARNr0blfCCeZ29QyUHr6K1nls344yxU6NMwHPKuD1Lye5O6eNXBi5 VnCpgmy1EpL01XS87nFDoLvLP0XFgnIKtmzixOeqUHUjbfOmuY+up+PpoZkssEdrgaXAKafGHqyIP r7rYF4oKaBV9DyAN3bCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opBl3-000uPm-SP; Sun, 30 Oct 2022 17:06:01 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opBkz-000uHj-9R for linux-arm-kernel@lists.infradead.org; Sun, 30 Oct 2022 17:05:59 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opBju-0002tX-Qd; Sun, 30 Oct 2022 18:04:50 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1opBjm-0000cU-6B; Sun, 30 Oct 2022 18:04:42 +0100 Date: Sun, 30 Oct 2022 18:04:42 +0100 From: Oleksij Rempel To: Krzysztof Kozlowski Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Sergey Shtylyov , Manivannan Sadhasivam , Srinivas Kandagatla , Jonathan Marek , Martin Botka , Taniya Das , Christian Marangi , Stephan Gerhold , Shawn Guo , Vinod Koul , krishna Lanka , Iskren Chernev , Del Regno , Robert Foss , Jeffrey Hugo , Govind Singh , Loic Poulain , Vladimir Zapolskiy , Dmitry Baryshkov , Oleksij Rempel , Horatiu Vultur , Vladimir Oltean , Claudiu Manoil , Alexandre Belloni , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] dt-bindings: net: constrain number of 'reg' in ethernet ports Message-ID: <20221030170442.GA7508@pengutronix.de> References: <20221028140326.43470-1-krzysztof.kozlowski@linaro.org> <20221028140326.43470-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221028140326.43470-2-krzysztof.kozlowski@linaro.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221030_100557_505425_172C4F4E X-CRM114-Status: GOOD ( 22.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 28, 2022 at 10:03:25AM -0400, Krzysztof Kozlowski wrote: > 'reg' without any constraints allows multiple items which is not the > intention for Ethernet controller's port number. > > Signed-off-by: Krzysztof Kozlowski For asix,ax88178.yaml and microchip,lan95xx.yaml Reviewed-by: Oleksij Rempel > > --- > > Please give it a time for Rob's bot to process this. > --- > Documentation/devicetree/bindings/net/asix,ax88178.yaml | 4 +++- > Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 4 +++- > .../devicetree/bindings/net/microchip,lan966x-switch.yaml | 4 ++-- > .../devicetree/bindings/net/microchip,sparx5-switch.yaml | 3 ++- > .../devicetree/bindings/net/mscc,vsc7514-switch.yaml | 3 ++- > .../bindings/net/renesas,r8a779f0-ether-switch.yaml | 4 ++-- > 6 files changed, 14 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/asix,ax88178.yaml b/Documentation/devicetree/bindings/net/asix,ax88178.yaml > index 1af52358de4c..a81dbc4792f6 100644 > --- a/Documentation/devicetree/bindings/net/asix,ax88178.yaml > +++ b/Documentation/devicetree/bindings/net/asix,ax88178.yaml > @@ -27,7 +27,9 @@ properties: > - usbb95,772b # ASIX AX88772B > - usbb95,7e2b # ASIX AX88772B > > - reg: true > + reg: > + maxItems: 1 > + > local-mac-address: true > mac-address: true > > diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml > index cf91fecd8909..3715c5f8f0e0 100644 > --- a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml > +++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml > @@ -39,7 +39,9 @@ properties: > - usb424,9e08 # SMSC LAN89530 USB Ethernet Device > - usb424,ec00 # SMSC9512/9514 USB Hub & Ethernet Device > > - reg: true > + reg: > + maxItems: 1 > + > local-mac-address: true > mac-address: true > > diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml > index dc116f14750e..583d70c51be6 100644 > --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml > +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml > @@ -83,8 +83,8 @@ properties: > const: 0 > > reg: > - description: > - Switch port number > + items: > + - description: Switch port number > > phys: > description: > diff --git a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml > index 57ffeb8fc876..ccb912561446 100644 > --- a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml > +++ b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml > @@ -89,7 +89,8 @@ properties: > > properties: > reg: > - description: Switch port number > + items: > + - description: Switch port number > > phys: > maxItems: 1 > diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml > index ee0a504bdb24..1cf82955d75e 100644 > --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml > +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml > @@ -109,7 +109,8 @@ properties: > > properties: > reg: > - description: Switch port number > + items: > + - description: Switch port number > > phy-handle: true > > diff --git a/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml b/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml > index 581fff8902f4..0eba66a29c6c 100644 > --- a/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml > +++ b/Documentation/devicetree/bindings/net/renesas,r8a779f0-ether-switch.yaml > @@ -106,8 +106,8 @@ properties: > > properties: > reg: > - description: > - Port number of ETHA (TSNA). > + items: > + - description: Port number of ETHA (TSNA). > > phys: > maxItems: 1 > -- > 2.34.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel