From: Sudeep Holla <sudeep.holla@arm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 7/8] hwmon: (scmi) Register explicitly with Thermal Framework
Date: Mon, 31 Oct 2022 14:04:17 +0000 [thread overview]
Message-ID: <20221031140417.sn6xeypj3624tjtu@bogus> (raw)
In-Reply-To: <20221031140021.GB948107@roeck-us.net>
On Mon, Oct 31, 2022 at 07:00:21AM -0700, Guenter Roeck wrote:
> On Mon, Oct 31, 2022 at 01:25:23PM +0000, Sudeep Holla wrote:
> > On Mon, Oct 31, 2022 at 11:40:18AM +0000, Cristian Marussi wrote:
> > > Available sensors are enumerated and reported by the SCMI platform server
> > > using a 16bit identification number; not all such sensors are of a type
> > > supported by hwmon subsystem and, among the supported ones, only a subset
> > > could be temperature sensors that have to be registered with the Thermal
> > > Framework.
> > > Potential clashes between hwmon channels indexes and the underlying real
> > > sensors IDs do not play well with the hwmon<-->thermal bridge automatic
> > > registration routines and could need a sensible number of fake dummy
> > > sensors to be made up in order to keep indexes and IDs in sync.
> > >
> > > Avoid to use the hwmon<-->thermal bridge dropping the HWMON_C_REGISTER_TZ
> > > attribute and instead explicit register temperature sensors directly with
> > > the Thermal Framework.
> > >
> >
> > Hi Guenter,
> >
> > FWIW from scmi perspective,
> >
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> >
> > I was about to ask for your ack to pickup myself but I see there is no
> > strict dependency for that. Not sure if you want to take this as fix for
> > v6.1 as the thermal changes broke the existing support in SCMI hwmon
> > or do you still prefer v6.2 ?
> >
>
> It is a regression and should be applied to 6.1. I'll pick it up and send
> a pull request to Linus later this week.
Indeed, thanks for the confirmation.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-31 14:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 14:08 [PATCH 1/8] firmware: arm_scmi: Cleanup core driver removal callback Cristian Marussi
2022-10-28 14:08 ` [PATCH 2/8] firmware: arm_scmi: Suppress bind attributes Cristian Marussi
2022-10-28 14:08 ` [PATCH 3/8] firmware: arm_scmi: Make tx_prepare time out eventually Cristian Marussi
2022-10-28 14:08 ` [PATCH 4/8] firmware: arm_scmi: Make RX chan_setup fail on memory errors Cristian Marussi
2022-10-28 14:08 ` [PATCH 5/8] firmware: arm_scmi: Fix devres allocation device in virtio Cristian Marussi
2022-10-28 14:08 ` [PATCH 6/8] firmware: arm_scmi: Fix deferred_tx_wq release on error paths Cristian Marussi
2022-10-28 14:08 ` [PATCH 7/8] hwmon: (scmi) Register explicitly with Thermal Framework Cristian Marussi
2022-10-28 15:11 ` Guenter Roeck
2022-10-28 15:35 ` Cristian Marussi
2022-10-28 15:58 ` Guenter Roeck
2022-10-28 16:15 ` Cristian Marussi
2022-10-28 16:34 ` Guenter Roeck
2022-10-28 17:12 ` Cristian Marussi
2022-10-31 11:40 ` [PATCH v2 " Cristian Marussi
2022-10-31 13:25 ` Sudeep Holla
2022-10-31 14:00 ` Guenter Roeck
2022-10-31 14:04 ` Sudeep Holla [this message]
2022-10-28 14:08 ` [PATCH 8/8] arm64: dts: juno: Add Thermal critical trip points Cristian Marussi
2022-11-03 7:14 ` Sudeep Holla
2022-11-03 7:09 ` [PATCH 1/8] firmware: arm_scmi: Cleanup core driver removal callback Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031140417.sn6xeypj3624tjtu@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox