linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	Naga Sureshkumar Relli <nagasure@xilinx.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 01/12] dt-bindings: mtd: Clarify all partition subnodes
Date: Mon, 31 Oct 2022 14:43:30 -0500	[thread overview]
Message-ID: <20221031194330.GA3299482-robh@kernel.org> (raw)
In-Reply-To: <20221028235933.934850-2-miquel.raynal@bootlin.com>

On Sat, Oct 29, 2022 at 01:59:22AM +0200, Miquel Raynal wrote:
> Over time the various ways to define MTD partitions has evolved. Most of
> the controllers support several different bindings. Let's define all
> possible choices in one file and mark the legacy ones deprecated. This
> way, we can just reference this file and avoid dupplicating these
> definitions.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  Documentation/devicetree/bindings/mtd/mtd.yaml | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/mtd.yaml b/Documentation/devicetree/bindings/mtd/mtd.yaml
> index 25b91f25fcf4..9fcaa61b046c 100644
> --- a/Documentation/devicetree/bindings/mtd/mtd.yaml
> +++ b/Documentation/devicetree/bindings/mtd/mtd.yaml
> @@ -21,7 +21,25 @@ properties:
>        based name) in order to ease flash device identification and/or
>        describe what they are used for.
>  
> +  partitions:
> +    type: object

Also, this node needs 'additionalProperties: false'. Unless there cases 
of custom properties here. If so, then it gets more complicated and 
we'll need a partitions.yaml schema instead so we can do:

$ref: partitions.yaml
properties:
  my-extra-custom-property: true

unevaluatedProperties: false

(Multiple node levels doesn't work for that as child nodes from 2 
different schemas can't 'see' each other.)

> +    properties:
> +      '#address-cells': true
> +      '#size-cells': true
> +
> +    patternProperties:
> +      "partition@[0-9a-f]+":
> +        $ref: partitions/partition.yaml
> +
>  patternProperties:
> +  "@[0-9a-f]+$":
> +    $ref: partitions/partition.yaml
> +    deprecated: true
> +
> +  "^partition@[0-9a-f]+":
> +    $ref: partitions/partition.yaml
> +    deprecated: true
> +
>    "^otp(-[0-9]+)?$":
>      type: object
>      $ref: ../nvmem/nvmem.yaml#
> -- 
> 2.34.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-10-31 19:44 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 23:59 [PATCH 00/12] Improve MTD bindings Miquel Raynal
2022-10-28 23:59 ` [PATCH 01/12] dt-bindings: mtd: Clarify all partition subnodes Miquel Raynal
2022-10-31 19:32   ` Rob Herring
2022-10-31 19:43   ` Rob Herring [this message]
2022-10-28 23:59 ` [PATCH 02/12] dt-bindings: mtd: Mention basic properties Miquel Raynal
2022-10-31 19:33   ` Rob Herring
2022-10-28 23:59 ` [PATCH 03/12] dt-bindings: mtd: Remove useless file about partitions Miquel Raynal
2022-10-31 19:35   ` Rob Herring
2022-10-28 23:59 ` [PATCH 04/12] dt-bindings: mtd: ingenic: Mark partitions in the controller node as deprecated Miquel Raynal
2022-10-30 13:50   ` Rob Herring
2022-10-31 19:46   ` Rob Herring
2022-10-28 23:59 ` [PATCH 05/12] dt-bindings: mtd: onenand: Mention the expected node name Miquel Raynal
2022-10-31 20:54   ` Rob Herring
2022-11-02 16:50     ` Miquel Raynal
2022-11-02 21:46       ` Rob Herring
2022-10-28 23:59 ` [PATCH 06/12] dt-bindings: mtd: nand-chip: Reference mtd.yaml Miquel Raynal
2022-10-31 20:55   ` Rob Herring
2022-10-28 23:59 ` [PATCH 07/12] dt-bindings: mtd: Drop common properties from NAND controllers Miquel Raynal
2022-10-31 20:55   ` Rob Herring
2022-10-28 23:59 ` [PATCH 08/12] dt-bindings: mtd: spi-nor: Drop common properties Miquel Raynal
2022-10-31 20:56   ` Rob Herring
2022-10-28 23:59 ` [PATCH 09/12] dt-bindings: mtd: phymap: Reuse the generic definitions Miquel Raynal
2022-10-30 13:50   ` Rob Herring
2022-10-28 23:59 ` [PATCH 10/12] dt-bindings: mtd: Drop object types when referencing other files Miquel Raynal
2022-10-31 20:59   ` Rob Herring
2022-10-28 23:59 ` [PATCH 11/12] dt-bindings: mtd: Argue in favor of keeping additionalProperties set to true Miquel Raynal
2022-10-31 21:01   ` Rob Herring
2022-10-28 23:59 ` [PATCH 12/12] dt-bindings: mtd: Constrain the list of parsers Miquel Raynal
2022-10-31 21:10   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221031194330.GA3299482-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mani@kernel.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=mripard@kernel.org \
    --cc=naga.sureshkumar.relli@xilinx.com \
    --cc=nagasure@xilinx.com \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).