From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85063C4332F for ; Thu, 3 Nov 2022 04:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ge4uZuB10C+aoTU2+oHCy/NwuraiUltUXcgkTNsBPoI=; b=JN46LYlfc0SEX+ dxWydU7oUcpfy3yfdyuhALeN653LtmGePwXELKo9zu+5PBTnu0uYk0U3n6A0FwmMGUp2RpCc3ovo/ rytzWiu0YIC/PAHfBoKjqY5l6LDlkg1rJBx13vLxqN0co1bk/Smm3qi6sqsFVPxLgpqI7dGe9WYSM ZQN/Pf14TD+RE/YErfhwzzt1R9Bn88j/1NBgwQsLPThgE8UX06fNGW5jKMRJKKsFjdmeFBpeQb7f0 Ci7RDkGeY1sPFvsql5PaWPwp+yQ6GcBvvausX01vOEFn+Op4X+RTkvBbZ+7idqthSd2cuJ+urC206 sG1354WeW4o6jqSrep0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqRsI-00FzH7-Il; Thu, 03 Nov 2022 04:30:42 +0000 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqRsF-00FzGY-NS for linux-arm-kernel@lists.infradead.org; Thu, 03 Nov 2022 04:30:41 +0000 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-13bd2aea61bso1001587fac.0 for ; Wed, 02 Nov 2022 21:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=beWe+uN+ON3DnKB4aGPZ3xvAANzoMjyW6vf2PFY929c=; b=jacehTQdxGORVtrgfvg0hPn0N5GQ2IUEGiL/11ZLmE5QRgqMbF6clRydJ/bAvwS1O8 8Z9UR6DiWWKEVePi87bU5voHcQV4UUftDtF/6e95DaD5ELfNE8JHWHhWwkraGlHT/ig8 jVeu1W283oM+9PRjGW7YZCKVy6Y+RNb+STI4bXXVQI/4SK3STy0z5ozLwJ7779WSKKvP z84gR7ImXU45qb4g7G4KfA4XepQw63t0iJzOVlrVzotBWrSuaJOIJalsiBwyDhXJ4jTV aSlLd0jNwOjRv85WYRIR5emtjHLsA7hQuNulGRxDWHQkyM41tHOLr/kpaknE0i/eknpt Ok4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=beWe+uN+ON3DnKB4aGPZ3xvAANzoMjyW6vf2PFY929c=; b=ZkSFnI1Ix1HaOaKuoDOkpItuJ0KgewU2f54q89qdqiyj0Cc+4Ah1L1yo4A/Yxea2WZ AbJLSjJW3ZgkrywZQwQyxeph7N9IYnM0nl6nwnerqWOMnxJW71PZz95Ba/9vHl9QAQi5 iwLrnmwaBIfj9DzD2R76tygGpNxFkPdy+eksbXigp6IxrbMsT5uCAhO79qPeifRXVB6B UNOc33lWge0L/0uEZDSXARz/MVajqFvdtuuFzW9M88lELp/f6ldt4CrVlYOVJBFWymhj EP61wANob9i256+jAnJ0VH5huVjMaHY8AgiXhGjfmY7J0T1MwVCuNsnI40yNt9nHXw4N 9hiQ== X-Gm-Message-State: ACrzQf0DNuV3dKYW1HO/SInichmFmnbAps57aVSegDCf7U6LB+klgLvW xEM2/Dsb3Dri1TLLlhuJQNc= X-Google-Smtp-Source: AMsMyM5/TXw3maOdtX+B4EYEcC9BeJj3uMEM0QxNLDKW/206hGsoRzr8X5YYyqpVqpk3jT6Tc3lf4w== X-Received: by 2002:a05:6870:2487:b0:131:4fee:aec2 with SMTP id s7-20020a056870248700b001314feeaec2mr26066038oaq.69.1667449835919; Wed, 02 Nov 2022 21:30:35 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id i3-20020a4addc3000000b0049201e2b8f4sm5150583oov.4.2022.11.02.21.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 21:30:35 -0700 (PDT) Date: Wed, 2 Nov 2022 21:30:34 -0700 From: Guenter Roeck To: Billy Tsai Cc: "jdelvare@suse.com" , "robh+dt@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "lee.jones@linaro.org" , "thierry.reding@gmail.com" , "u.kleine-koenig@pengutronix.de" , "p.zabel@pengutronix.de" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , BMC-SW , "garnermic@meta.com" Subject: Re: [v2 3/3] hwmon: Add Aspeed ast2600 TACH support Message-ID: <20221103043034.GA2113834@roeck-us.net> References: <20221101095156.30591-1-billy_tsai@aspeedtech.com> <20221101095156.30591-4-billy_tsai@aspeedtech.com> <20221101131456.GA1310110@roeck-us.net> <271C521D-8F20-4C86-B3DA-9C0AD74242D4@aspeedtech.com> <20221102170138.GA2913353@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_213039_781558_C23393CA X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 03, 2022 at 03:52:59AM +0000, Billy Tsai wrote: > > Can't I use a min/max RPM to let the driver know a reasonable timeout/polling period when > the driver is trying to get RPM? > Beacause that our tach controller have the falg to indicates the hardware detected the change > in the input signal. I need the proper timout to rule out slow RPMs. > If the chip measures the fan speed continuously, why would that ever be a problem, and why wait in the first place instead of just taking the most recent result ? Pretty much every other driver is doing that, so I really don't understand why that would not work here. Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel