From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 202EEC4332F for ; Thu, 3 Nov 2022 20:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tYkDemS+LvRdt6RJ53loqhX3x6zI11E5duz2fNSO6xg=; b=Nnt6gdFBG0errZ eUwrxnh1TtEyC6GNp+pcdlMVEa1heeCYWMU1apa3d5Z6YfVwya8qYbwG5eRiHO4J+te6ofopXU7H8 YXdXBverymR38aCordYGusnFuDy6FDHAb4NMdXzWDR6ASYpW1scoW/T88+CDGUA4S+CNJaJ5Mau0O q9QoCCMHBxQoMdTV66eKf7MzYrdChjTERxTjSLQpaw58M7aBl35NpFa5mr+esu5vvpi3RPPoD5n6B 4mMXxDDRaYJVQFlTYNukg0QBVBIKzF7pmppgMldMFyUGmAkYh7k6pRtsG1ilvA5kKmVJpqGHgpamx Uzf15q/+kh9+uH79/Zyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqgtQ-001diJ-Me; Thu, 03 Nov 2022 20:32:52 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqgtM-001dhW-UT; Thu, 03 Nov 2022 20:32:50 +0000 Received: from notapiano (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9F0FD660295F; Thu, 3 Nov 2022 20:32:42 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1667507565; bh=s7VMS6sqPzrxI8wodWazep6RmdDGQpqaH/k/O9pHKSU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PyWTvoWWaPdngbDHe6Uw6YzacdFUVXdkGMEna87bwd7WXTwo7FBZlufZIkMHJJLEy GHf4bVNU4VLMlQxhB+3hMwsKv/szkmIh8atjChM7QikeF3pQtpDvUT1TUh1ix3GyTA Gt7Z0cqtZBPgBqcAf9onCOHOEoFlN6S4b/fC75qKhqu9oavCf0T3HMfqEkRisS1odX WsAA1nTCMG5qF0aWuNAnC0fDyeCP9H0TaOEFwOJLFFqxyMdPg5pdbDPEeoavSrKRAQ y1KhleAdaAeC1pxVT7LIbZ9gfHjNfp0eOXLf10t8XwpJhV6d28jeOFloLW1rRwnUKJ RBu8+uxv8tkHA== Date: Thu, 3 Nov 2022 16:32:38 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: "Nancy.Lin" Cc: Rob Herring , Matthias Brugger , Chun-Kuang Hu , Philipp Zabel , wim@linux-watchdog.org, AngeloGioacchino Del Regno , linux@roeck-us.net, David Airlie , Daniel Vetter , Nathan Chancellor , Nick Desaulniers , "jason-jh . lin" , Yongqiang Niu , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, llvm@lists.linux.dev, singo.chang@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v27 05/11] soc: mediatek: refine code to use mtk_mmsys_update_bits API Message-ID: <20221103203238.fryjwpgjtwccnjwu@notapiano> References: <20221103032512.9144-1-nancy.lin@mediatek.com> <20221103032512.9144-6-nancy.lin@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221103032512.9144-6-nancy.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221103_133249_270382_B548E71A X-CRM114-Status: UNSURE ( 8.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 03, 2022 at 11:25:06AM +0800, Nancy.Lin wrote: [..] > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c [..] > +static void mtk_mmsys_update_bits(struct mtk_mmsys *mmsys, u32 offset, u= 32 mask, u32 val) > +{ > + u32 tmp; > + > + tmp =3D readl_relaxed(mmsys->regs + offset); > + tmp =3D (tmp & ~mask) | val; You should mask the value before writing to prevent bad values from overwri= ting bits outside the mask. tmp =3D (tmp & ~mask) | (val & mask); With that, Reviewed-by: N=EDcolas F. R. A. Prado Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel