From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05581C4321E for ; Fri, 4 Nov 2022 15:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4gPVniWlYJc2xKX+8PC1e+LFllEmizuS+PYvB1Ttd/4=; b=Bh7wK89HuaPhmx 7lLNVFYltzH5Je6El8oYEiRingM3NyAmfganuE63aKvT4FuMduHoGFvCdAV4eQV0KnFcj18TJ9WhS WWonr+/SQTWJiFPDcbwFwO7+soUk+TBFUHGTvo5ZrsjKikOYiApPmBEi8Y4GYSKqysLD5BGh3EWhz /FhF2eocVnclxlpZuDMeg9Ymx0Edjo4gRzuhwx2WLSFNVmzcsFwn/rw0u852B1KHVF4ceI2A9yKL+ P/l6NTn2ftBGSkOEpAuTKI9MFfRFzW/Ro7CX4Mg1QoyolFdQGsFxmapiOC7M/TjdpSHu0N2g2fzKi 0E38+gAtYQ3urox1grLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqycB-004DDO-9Q; Fri, 04 Nov 2022 15:28:16 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqybZ-004Cwx-RI for linux-arm-kernel@lists.infradead.org; Fri, 04 Nov 2022 15:27:39 +0000 Received: by mail-pf1-x433.google.com with SMTP id b29so4780334pfp.13 for ; Fri, 04 Nov 2022 08:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O2Nd6bNvUe0UVcRt3WitzDx9mV2ITpv1BTXOeCveRv8=; b=udRcro9xs4r+r6ted7rjPa79NMf0EsS7OK6uHxFq9z46/Z8czPMaZxT/685iGOaWU5 lVV6U47yiHKL3pVxz332BlQaPXDP7ntcdzw5kwnO5VhlVZeOouUqdBQd3dB12hoNH7uj 19wzID8mx/+pEcobJBZpArkSVSCsG/fah0GrmxDge/jEUC+jxRTbQt84nBRYSQ4SiFZM YAI6OwQ4GXpmBX1+vNqdMkYWOpFnpQ3boXg0arqy9yQ1w3y8O6i49EVDJx8npUl/07FA F25NunijPdaLvBjbgVU6zmscMqI+nEKXvmm+nV4/bGlC1t2nWFPV682N2SiEUcRcVmmx v/hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O2Nd6bNvUe0UVcRt3WitzDx9mV2ITpv1BTXOeCveRv8=; b=CcH0D94gdLsWf0Nh5MdpSqSOFkyGFHCUnQvPr12GgBXI892L8k/NScc8XpG6e/Y/X/ IPGr53gQo5tH3Sq2vV5hDt56WaEYTxSmmAkWmCTNK8IqTc1ZxP7DoFms7z5agyIHpSJD 95Bg4w7OAnTOFOhv7AIkNElWjGmlD/J+oxk56hUOR4Mj8OidpcP3SbKWTC9Tvuf/EvMm oad7LXm4RZEEJGodIUm8vmpc35eY4wlF7SSGIyCPiqiaR4BzihbKOWkat3ZO/Rwak59a lWwxZlZ3qh5QYuvQBz6/Os1kMgMe/yHf7GxLuB6aOJfXUaCQH4j9gpdHN3Hj6cgfN7Ry 1zLA== X-Gm-Message-State: ACrzQf2m1HP47W4UByr6a0j56oggmjdOl5UiO5ZHYSRKnbNgw/ZWLxVn bsB1XOmD9cnpPajuoqi0vpSuwg== X-Google-Smtp-Source: AMsMyM5rdAb7s+O02h1GUn9LmOSQvSTQUB9WGaUhWTbGZ1jAIxW2thw1XRv+RNRbRTlgrnFhXBzQcQ== X-Received: by 2002:a05:6a00:88f:b0:530:dec:81fd with SMTP id q15-20020a056a00088f00b005300dec81fdmr36370451pfj.64.1667575655145; Fri, 04 Nov 2022 08:27:35 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id z12-20020a170903018c00b00186e8526790sm2812772plg.127.2022.11.04.08.27.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 08:27:34 -0700 (PDT) Date: Fri, 4 Nov 2022 09:27:32 -0600 From: Mathieu Poirier To: Peng Fan Cc: "Peng Fan (OSS)" , "andersson@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-remoteproc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping Message-ID: <20221104152732.GA1873068@p14s> References: <20221102111410.38737-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_082737_931953_B316FD65 X-CRM114-Status: GOOD ( 25.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 03, 2022 at 06:11:46AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping > > > > On Wed, 2 Nov 2022 at 05:12, Peng Fan (OSS) > > wrote: > > > > > > From: Peng Fan > > > > > > According to updated reference mannual, the M33 DRAM view of > > > 0x[C,D]0000000 maps to A55 0xC0000000, so correct it. > > > > > > Fixes: 9222fabf0e39 ("remoteproc: imx_rproc: Support i.MX93") > > > Signed-off-by: Peng Fan > > > --- > > > drivers/remoteproc/imx_rproc.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index 2c471e46f4ca..9fc978e0393c > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -134,8 +134,8 @@ static const struct imx_rproc_att > > imx_rproc_att_imx93[] = { > > > { 0x80000000, 0x80000000, 0x10000000, 0 }, > > > { 0x90000000, 0x80000000, 0x10000000, 0 }, > > > > > > - { 0xC0000000, 0xa0000000, 0x10000000, 0 }, > > > - { 0xD0000000, 0xa0000000, 0x10000000, 0 }, > > > + { 0xC0000000, 0xC0000000, 0x10000000, 0 }, > > > + { 0xD0000000, 0xC0000000, 0x10000000, 0 }, > > > > But how did this work before? Were some SoC released with the old > > mapping? As it is regularly the case, you have not answered all my questions. > The current m33 firmware release with Linux SDK only has > TCM version, so I not have image to test the DDR mapping. > > Initially we got the information that M33 mapping of DRAM. > DRAM (offset 0 MB) DRAM 80000000 > DRAM (offset 256 MB) DRAM A0000000 > DRAM (offset 512 MB) DRAM C0000000 > > However the information is wrong after we check more, > there is an 256MB hole, 0MB [0x80000000, 0x8fffffff], > 512MB [0xa0000000, 0xafffffff], > 1024MB [0xc0000000, 0xcfffffff] > > I use JTAG to confirm it. > > Thanks, > Peng. > > > > > }; > > > > > > static const struct imx_rproc_att imx_rproc_att_imx8qm[] = { > > > -- > > > 2.37.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel