* [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping
@ 2022-11-02 11:14 Peng Fan (OSS)
2022-11-02 17:40 ` Mathieu Poirier
0 siblings, 1 reply; 7+ messages in thread
From: Peng Fan (OSS) @ 2022-11-02 11:14 UTC (permalink / raw)
To: andersson, mathieu.poirier, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, linux-remoteproc, linux-arm-kernel,
linux-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
According to updated reference mannual, the M33 DRAM view of
0x[C,D]0000000 maps to A55 0xC0000000, so correct it.
Fixes: 9222fabf0e39 ("remoteproc: imx_rproc: Support i.MX93")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/remoteproc/imx_rproc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 2c471e46f4ca..9fc978e0393c 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -134,8 +134,8 @@ static const struct imx_rproc_att imx_rproc_att_imx93[] = {
{ 0x80000000, 0x80000000, 0x10000000, 0 },
{ 0x90000000, 0x80000000, 0x10000000, 0 },
- { 0xC0000000, 0xa0000000, 0x10000000, 0 },
- { 0xD0000000, 0xa0000000, 0x10000000, 0 },
+ { 0xC0000000, 0xC0000000, 0x10000000, 0 },
+ { 0xD0000000, 0xC0000000, 0x10000000, 0 },
};
static const struct imx_rproc_att imx_rproc_att_imx8qm[] = {
--
2.37.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping 2022-11-02 11:14 [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping Peng Fan (OSS) @ 2022-11-02 17:40 ` Mathieu Poirier 2022-11-03 6:11 ` Peng Fan 0 siblings, 1 reply; 7+ messages in thread From: Mathieu Poirier @ 2022-11-02 17:40 UTC (permalink / raw) To: Peng Fan (OSS) Cc: andersson, shawnguo, s.hauer, kernel, festevam, linux-imx, linux-remoteproc, linux-arm-kernel, linux-kernel, Peng Fan On Wed, 2 Nov 2022 at 05:12, Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote: > > From: Peng Fan <peng.fan@nxp.com> > > According to updated reference mannual, the M33 DRAM view of > 0x[C,D]0000000 maps to A55 0xC0000000, so correct it. > > Fixes: 9222fabf0e39 ("remoteproc: imx_rproc: Support i.MX93") > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/remoteproc/imx_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 2c471e46f4ca..9fc978e0393c 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -134,8 +134,8 @@ static const struct imx_rproc_att imx_rproc_att_imx93[] = { > { 0x80000000, 0x80000000, 0x10000000, 0 }, > { 0x90000000, 0x80000000, 0x10000000, 0 }, > > - { 0xC0000000, 0xa0000000, 0x10000000, 0 }, > - { 0xD0000000, 0xa0000000, 0x10000000, 0 }, > + { 0xC0000000, 0xC0000000, 0x10000000, 0 }, > + { 0xD0000000, 0xC0000000, 0x10000000, 0 }, But how did this work before? Were some SoC released with the old mapping? > }; > > static const struct imx_rproc_att imx_rproc_att_imx8qm[] = { > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping 2022-11-02 17:40 ` Mathieu Poirier @ 2022-11-03 6:11 ` Peng Fan 2022-11-04 15:27 ` Mathieu Poirier 0 siblings, 1 reply; 7+ messages in thread From: Peng Fan @ 2022-11-03 6:11 UTC (permalink / raw) To: Mathieu Poirier, Peng Fan (OSS) Cc: andersson@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping > > On Wed, 2 Nov 2022 at 05:12, Peng Fan (OSS) <peng.fan@oss.nxp.com> > wrote: > > > > From: Peng Fan <peng.fan@nxp.com> > > > > According to updated reference mannual, the M33 DRAM view of > > 0x[C,D]0000000 maps to A55 0xC0000000, so correct it. > > > > Fixes: 9222fabf0e39 ("remoteproc: imx_rproc: Support i.MX93") > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > drivers/remoteproc/imx_rproc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > b/drivers/remoteproc/imx_rproc.c index 2c471e46f4ca..9fc978e0393c > > 100644 > > --- a/drivers/remoteproc/imx_rproc.c > > +++ b/drivers/remoteproc/imx_rproc.c > > @@ -134,8 +134,8 @@ static const struct imx_rproc_att > imx_rproc_att_imx93[] = { > > { 0x80000000, 0x80000000, 0x10000000, 0 }, > > { 0x90000000, 0x80000000, 0x10000000, 0 }, > > > > - { 0xC0000000, 0xa0000000, 0x10000000, 0 }, > > - { 0xD0000000, 0xa0000000, 0x10000000, 0 }, > > + { 0xC0000000, 0xC0000000, 0x10000000, 0 }, > > + { 0xD0000000, 0xC0000000, 0x10000000, 0 }, > > But how did this work before? Were some SoC released with the old > mapping? The current m33 firmware release with Linux SDK only has TCM version, so I not have image to test the DDR mapping. Initially we got the information that M33 mapping of DRAM. DRAM (offset 0 MB) DRAM 80000000 DRAM (offset 256 MB) DRAM A0000000 DRAM (offset 512 MB) DRAM C0000000 However the information is wrong after we check more, there is an 256MB hole, 0MB [0x80000000, 0x8fffffff], 512MB [0xa0000000, 0xafffffff], 1024MB [0xc0000000, 0xcfffffff] I use JTAG to confirm it. Thanks, Peng. > > > }; > > > > static const struct imx_rproc_att imx_rproc_att_imx8qm[] = { > > -- > > 2.37.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping 2022-11-03 6:11 ` Peng Fan @ 2022-11-04 15:27 ` Mathieu Poirier 2022-11-07 0:27 ` Peng Fan 0 siblings, 1 reply; 7+ messages in thread From: Mathieu Poirier @ 2022-11-04 15:27 UTC (permalink / raw) To: Peng Fan Cc: Peng Fan (OSS), andersson@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On Thu, Nov 03, 2022 at 06:11:46AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping > > > > On Wed, 2 Nov 2022 at 05:12, Peng Fan (OSS) <peng.fan@oss.nxp.com> > > wrote: > > > > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > According to updated reference mannual, the M33 DRAM view of > > > 0x[C,D]0000000 maps to A55 0xC0000000, so correct it. > > > > > > Fixes: 9222fabf0e39 ("remoteproc: imx_rproc: Support i.MX93") > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > drivers/remoteproc/imx_rproc.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index 2c471e46f4ca..9fc978e0393c > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -134,8 +134,8 @@ static const struct imx_rproc_att > > imx_rproc_att_imx93[] = { > > > { 0x80000000, 0x80000000, 0x10000000, 0 }, > > > { 0x90000000, 0x80000000, 0x10000000, 0 }, > > > > > > - { 0xC0000000, 0xa0000000, 0x10000000, 0 }, > > > - { 0xD0000000, 0xa0000000, 0x10000000, 0 }, > > > + { 0xC0000000, 0xC0000000, 0x10000000, 0 }, > > > + { 0xD0000000, 0xC0000000, 0x10000000, 0 }, > > > > But how did this work before? Were some SoC released with the old > > mapping? As it is regularly the case, you have not answered all my questions. > The current m33 firmware release with Linux SDK only has > TCM version, so I not have image to test the DDR mapping. > > Initially we got the information that M33 mapping of DRAM. > DRAM (offset 0 MB) DRAM 80000000 > DRAM (offset 256 MB) DRAM A0000000 > DRAM (offset 512 MB) DRAM C0000000 > > However the information is wrong after we check more, > there is an 256MB hole, 0MB [0x80000000, 0x8fffffff], > 512MB [0xa0000000, 0xafffffff], > 1024MB [0xc0000000, 0xcfffffff] > > I use JTAG to confirm it. > > Thanks, > Peng. > > > > > }; > > > > > > static const struct imx_rproc_att imx_rproc_att_imx8qm[] = { > > > -- > > > 2.37.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping 2022-11-04 15:27 ` Mathieu Poirier @ 2022-11-07 0:27 ` Peng Fan 2022-11-15 18:33 ` Mathieu Poirier 0 siblings, 1 reply; 7+ messages in thread From: Peng Fan @ 2022-11-07 0:27 UTC (permalink / raw) To: Mathieu Poirier Cc: Peng Fan (OSS), andersson@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org > -----Original Message----- > From: Mathieu Poirier <mathieu.poirier@linaro.org> > Sent: 2022年11月4日 23:28 > To: Peng Fan <peng.fan@nxp.com> > Cc: Peng Fan (OSS) <peng.fan@oss.nxp.com>; andersson@kernel.org; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux- > remoteproc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping > > On Thu, Nov 03, 2022 at 06:11:46AM +0000, Peng Fan wrote: > > > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM > > > mapping > > > > > > On Wed, 2 Nov 2022 at 05:12, Peng Fan (OSS) <peng.fan@oss.nxp.com> > > > wrote: > > > > > > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > > > According to updated reference mannual, the M33 DRAM view of > > > > 0x[C,D]0000000 maps to A55 0xC0000000, so correct it. > > > > > > > > Fixes: 9222fabf0e39 ("remoteproc: imx_rproc: Support i.MX93") > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > > --- > > > > drivers/remoteproc/imx_rproc.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > > b/drivers/remoteproc/imx_rproc.c index 2c471e46f4ca..9fc978e0393c > > > > 100644 > > > > --- a/drivers/remoteproc/imx_rproc.c > > > > +++ b/drivers/remoteproc/imx_rproc.c > > > > @@ -134,8 +134,8 @@ static const struct imx_rproc_att > > > imx_rproc_att_imx93[] = { > > > > { 0x80000000, 0x80000000, 0x10000000, 0 }, > > > > { 0x90000000, 0x80000000, 0x10000000, 0 }, > > > > > > > > - { 0xC0000000, 0xa0000000, 0x10000000, 0 }, > > > > - { 0xD0000000, 0xa0000000, 0x10000000, 0 }, > > > > + { 0xC0000000, 0xC0000000, 0x10000000, 0 }, > > > > + { 0xD0000000, 0xC0000000, 0x10000000, 0 }, > > > > > > But how did this work before? Were some SoC released with the old > > > mapping? > > As it is regularly the case, you have not answered all my questions. The DRAM mapping was not tested, I just wrote them down according to the information I had. In this patch, I just fix the mapping at address 0xC0000000, I not add 0xA0000000, I may also add it or use a separate patch, which would you prefer? The i.MX93 SoC is still in pre-production phase, and there is no public Information for now. Regards, Peng. > > > The current m33 firmware release with Linux SDK only has TCM version, > > so I not have image to test the DDR mapping. > > > > Initially we got the information that M33 mapping of DRAM. > > DRAM (offset 0 MB) DRAM 80000000 > > DRAM (offset 256 MB) DRAM A0000000 > > DRAM (offset 512 MB) DRAM C0000000 > > > > However the information is wrong after we check more, there is an > > 256MB hole, 0MB [0x80000000, 0x8fffffff], 512MB [0xa0000000, > > 0xafffffff], 1024MB [0xc0000000, 0xcfffffff] > > > > I use JTAG to confirm it. > > > > Thanks, > > Peng. > > > > > > > }; > > > > > > > > static const struct imx_rproc_att imx_rproc_att_imx8qm[] = { > > > > -- > > > > 2.37.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping 2022-11-07 0:27 ` Peng Fan @ 2022-11-15 18:33 ` Mathieu Poirier 2022-11-16 2:52 ` Peng Fan 0 siblings, 1 reply; 7+ messages in thread From: Mathieu Poirier @ 2022-11-15 18:33 UTC (permalink / raw) To: Peng Fan Cc: Peng Fan (OSS), andersson@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On Mon, Nov 07, 2022 at 12:27:58AM +0000, Peng Fan wrote: > > > > -----Original Message----- > > From: Mathieu Poirier <mathieu.poirier@linaro.org> > > Sent: 2022年11月4日 23:28 > > To: Peng Fan <peng.fan@nxp.com> > > Cc: Peng Fan (OSS) <peng.fan@oss.nxp.com>; andersson@kernel.org; > > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux- > > remoteproc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org > > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping > > > > On Thu, Nov 03, 2022 at 06:11:46AM +0000, Peng Fan wrote: > > > > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM > > > > mapping > > > > > > > > On Wed, 2 Nov 2022 at 05:12, Peng Fan (OSS) <peng.fan@oss.nxp.com> > > > > wrote: > > > > > > > > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > > > > > According to updated reference mannual, the M33 DRAM view of > > > > > 0x[C,D]0000000 maps to A55 0xC0000000, so correct it. > > > > > > > > > > Fixes: 9222fabf0e39 ("remoteproc: imx_rproc: Support i.MX93") > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > > > --- > > > > > drivers/remoteproc/imx_rproc.c | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > > > b/drivers/remoteproc/imx_rproc.c index 2c471e46f4ca..9fc978e0393c > > > > > 100644 > > > > > --- a/drivers/remoteproc/imx_rproc.c > > > > > +++ b/drivers/remoteproc/imx_rproc.c > > > > > @@ -134,8 +134,8 @@ static const struct imx_rproc_att > > > > imx_rproc_att_imx93[] = { > > > > > { 0x80000000, 0x80000000, 0x10000000, 0 }, > > > > > { 0x90000000, 0x80000000, 0x10000000, 0 }, > > > > > > > > > > - { 0xC0000000, 0xa0000000, 0x10000000, 0 }, > > > > > - { 0xD0000000, 0xa0000000, 0x10000000, 0 }, > > > > > + { 0xC0000000, 0xC0000000, 0x10000000, 0 }, > > > > > + { 0xD0000000, 0xC0000000, 0x10000000, 0 }, > > > > > > > > But how did this work before? Were some SoC released with the old > > > > mapping? > > > > As it is regularly the case, you have not answered all my questions. > > The DRAM mapping was not tested, I just wrote them down according > to the information I had. In this patch, I just fix the mapping at address > 0xC0000000, I not add 0xA0000000, I may also add it or use a separate > patch, which would you prefer? Seperate patch? This is a seperate patch... > > The i.MX93 SoC is still in pre-production phase, and there is no public > Information for now. > That is all I wanted to know. Other implementation can't be affected by this change because the sillicon is still under development. Simple isn't? I am applying this patch. > Regards, > Peng. > > > > > The current m33 firmware release with Linux SDK only has TCM version, > > > so I not have image to test the DDR mapping. > > > > > > Initially we got the information that M33 mapping of DRAM. > > > DRAM (offset 0 MB) DRAM 80000000 > > > DRAM (offset 256 MB) DRAM A0000000 > > > DRAM (offset 512 MB) DRAM C0000000 > > > > > > However the information is wrong after we check more, there is an > > > 256MB hole, 0MB [0x80000000, 0x8fffffff], 512MB [0xa0000000, > > > 0xafffffff], 1024MB [0xc0000000, 0xcfffffff] > > > > > > I use JTAG to confirm it. > > > > > > Thanks, > > > Peng. > > > > > > > > > }; > > > > > > > > > > static const struct imx_rproc_att imx_rproc_att_imx8qm[] = { > > > > > -- > > > > > 2.37.1 > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping 2022-11-15 18:33 ` Mathieu Poirier @ 2022-11-16 2:52 ` Peng Fan 0 siblings, 0 replies; 7+ messages in thread From: Peng Fan @ 2022-11-16 2:52 UTC (permalink / raw) To: Mathieu Poirier Cc: Peng Fan (OSS), andersson@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping > > On Mon, Nov 07, 2022 at 12:27:58AM +0000, Peng Fan wrote: > > > > > > > -----Original Message----- > > > From: Mathieu Poirier <mathieu.poirier@linaro.org> > > > Sent: 2022年11月4日 23:28 > > > To: Peng Fan <peng.fan@nxp.com> > > > Cc: Peng Fan (OSS) <peng.fan@oss.nxp.com>; andersson@kernel.org; > > > shawnguo@kernel.org; s.hauer@pengutronix.de; > kernel@pengutronix.de; > > > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux- > > > remoteproc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > linux- kernel@vger.kernel.org > > > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM > > > mapping > > > > > > On Thu, Nov 03, 2022 at 06:11:46AM +0000, Peng Fan wrote: > > > > > Subject: Re: [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM > > > > > mapping > > > > > > > > > > On Wed, 2 Nov 2022 at 05:12, Peng Fan (OSS) > > > > > <peng.fan@oss.nxp.com> > > > > > wrote: > > > > > > > > > > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > > > > > > > According to updated reference mannual, the M33 DRAM view of > > > > > > 0x[C,D]0000000 maps to A55 0xC0000000, so correct it. > > > > > > > > > > > > Fixes: 9222fabf0e39 ("remoteproc: imx_rproc: Support i.MX93") > > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > > > > --- > > > > > > drivers/remoteproc/imx_rproc.c | 4 ++-- > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > > > > b/drivers/remoteproc/imx_rproc.c index > > > > > > 2c471e46f4ca..9fc978e0393c > > > > > > 100644 > > > > > > --- a/drivers/remoteproc/imx_rproc.c > > > > > > +++ b/drivers/remoteproc/imx_rproc.c > > > > > > @@ -134,8 +134,8 @@ static const struct imx_rproc_att > > > > > imx_rproc_att_imx93[] = { > > > > > > { 0x80000000, 0x80000000, 0x10000000, 0 }, > > > > > > { 0x90000000, 0x80000000, 0x10000000, 0 }, > > > > > > > > > > > > - { 0xC0000000, 0xa0000000, 0x10000000, 0 }, > > > > > > - { 0xD0000000, 0xa0000000, 0x10000000, 0 }, > > > > > > + { 0xC0000000, 0xC0000000, 0x10000000, 0 }, > > > > > > + { 0xD0000000, 0xC0000000, 0x10000000, 0 }, > > > > > > > > > > But how did this work before? Were some SoC released with the > > > > > old mapping? > > > > > > As it is regularly the case, you have not answered all my questions. > > > > The DRAM mapping was not tested, I just wrote them down according to > > the information I had. In this patch, I just fix the mapping at > > address 0xC0000000, I not add 0xA0000000, I may also add it or use a > > separate patch, which would you prefer? > > Seperate patch? This is a seperate patch... I mean the DRAM mapping still not cover 0xA0000000, 0xB0000000. The current mapping is below: /* DDR */ { 0x80000000, 0x80000000, 0x10000000, 0 }, { 0x90000000, 0x80000000, 0x10000000, 0 }, { 0xC0000000, 0xc0000000, 0x10000000, 0 }, { 0xD0000000, 0xc0000000, 0x10000000, 0 }, For 0xA/B0000000, I could add later when I get an M33 image that really use that address in future. > > > > > The i.MX93 SoC is still in pre-production phase, and there is no > > public Information for now. > > > > That is all I wanted to know. Other implementation can't be affected by this > change because the sillicon is still under development. Simple isn't? > > I am applying this patch. Others are not affected. Thanks, Peng. > > > Regards, > > Peng. > > > > > > > The current m33 firmware release with Linux SDK only has TCM > > > > version, so I not have image to test the DDR mapping. > > > > > > > > Initially we got the information that M33 mapping of DRAM. > > > > DRAM (offset 0 MB) DRAM 80000000 > > > > DRAM (offset 256 MB) DRAM A0000000 > > > > DRAM (offset 512 MB) DRAM C0000000 > > > > > > > > However the information is wrong after we check more, there is an > > > > 256MB hole, 0MB [0x80000000, 0x8fffffff], 512MB [0xa0000000, > > > > 0xafffffff], 1024MB [0xc0000000, 0xcfffffff] > > > > > > > > I use JTAG to confirm it. > > > > > > > > Thanks, > > > > Peng. > > > > > > > > > > > }; > > > > > > > > > > > > static const struct imx_rproc_att imx_rproc_att_imx8qm[] = { > > > > > > -- > > > > > > 2.37.1 > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-11-16 2:54 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-11-02 11:14 [PATCH] remoteproc: imx_rproc: correct i.MX93 DRAM mapping Peng Fan (OSS) 2022-11-02 17:40 ` Mathieu Poirier 2022-11-03 6:11 ` Peng Fan 2022-11-04 15:27 ` Mathieu Poirier 2022-11-07 0:27 ` Peng Fan 2022-11-15 18:33 ` Mathieu Poirier 2022-11-16 2:52 ` Peng Fan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).