From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3141C433FE for ; Sat, 5 Nov 2022 14:07:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Era9gnDEHy4gU9U1NDPdPO+MJcqncsrw2zz9Yj6bR80=; b=yADk9OfxC69OUB m3nKAkKBda0SrhuS4et/Lzzod+gioLhQ66qN0WItef6ztwgzPG0DbfC/Jm63qCJXeDJOENfUGVj0+ KPKPKlwWF3A/jevAVdYHAUQ/WmWV1aEPP6tK/5woUHX8mPmrHpGgLLGhpJxQLk+8U7mpvRWuHdoxI eCo26Iioo5GCNzwb6eJbGNIeBA5Bn2SKQtFYWBFljhfjSavXvGBifoPiZmYXF85TmOUCU9N3fuYk+ lpDsUkR8Nr0wjTCLUa4DlDpPo2TCmOtCUcSlRB15F9sfU15BwhsZHD+/SVk/e99DVkNRn9NCON3Hg xU9Wpb3LiX/2aS73+Qbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1orJoD-006e6g-5D; Sat, 05 Nov 2022 14:06:05 +0000 Received: from mail-oa1-x2e.google.com ([2001:4860:4864:20::2e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1orJoA-006e52-5Z for linux-arm-kernel@lists.infradead.org; Sat, 05 Nov 2022 14:06:03 +0000 Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-13ba86b5ac0so8374503fac.1 for ; Sat, 05 Nov 2022 07:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=8Bw328y2bVSAsU6M+b6Cqflfx2UQ2J4p0Zb/NQFKXJ8=; b=S34IWwxCPFjK3gTNiS+7/ui94MFPB5mi1t+pWqvcgwfcOdSeFSwiAKrBJOOJKwh5C0 arTFR38OjfsJdLcM6Rv94GH56yEZ9TRfxQYQgc0CEi3mC8C3fm/hiuhP7eQQjAOdmJ6M +kbMnKKDMtOl95UhO+SB60NCGX6YoGz8W8rEjQrLFaUvXckvd+LkIfkXFcq3bSb4kic0 lUwdQDdQka484e6pkgx9eegVIiJjBDtlnoExNz1rMPoI6POBy9pWo9MbV9aL2UEzBiHM OuNrDHvwACgi4w9PDw+RiuaKezVnIu32dR61YJfsjg2HLOHK7ogeRkAXw0QUAutaBBHZ P4Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Bw328y2bVSAsU6M+b6Cqflfx2UQ2J4p0Zb/NQFKXJ8=; b=PVYjjAM1ZlHcHFjAqfdp6wBwnzMEoYDB1N6C/7RiCUg+ASnu/XcB5edOItp/zXFKs4 BgIBou8n7kBU9yKG58K3gpDILAuzV8bpjN4HQsRD++2uHT3RHRQwpQJBaqLXwDm+mzXU dvewHTznQiVhY/cqOf67/prkE0Q7H3MpS1/22Qeq5J5lwxteq7mf3xznLXVPzkDhSEEf qkkTYR8aKzDrwbTbGqi/pxKmQ8D5BN5xzOhE4uNzOYbEqaSxivD3tsdr9yUhxCagAzsC aC/I0bbQE/BjtV472hP39lFpT/Gb2Q3IddNvhvBKZyDKa9Rvvs1LplQSg6Aktk8UEhHT /9pQ== X-Gm-Message-State: ACrzQf2cRniKskDCqVJYCDECvoL1YgYjWVHMVrTDTyyO9yIcEXh7lltO bHY8/kchvm0CH4lq9khdNNM= X-Google-Smtp-Source: AMsMyM4O2xKxqglPQbMZ6j5scgQkj5CrqrKDHWc9w3V01Uf2BG/n3UTYNm7zcvvx8yCZB7S0ibZ2sA== X-Received: by 2002:a05:6870:7682:b0:13b:ba8f:413d with SMTP id dx2-20020a056870768200b0013bba8f413dmr353354oab.236.1667657156815; Sat, 05 Nov 2022 07:05:56 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id o198-20020a4a2ccf000000b004968311a31asm625577ooo.39.2022.11.05.07.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Nov 2022 07:05:54 -0700 (PDT) Date: Sat, 5 Nov 2022 07:05:53 -0700 From: Guenter Roeck To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Thomas Gleixner , Stephen Boyd , Anna-Maria Gleixner , Andrew Morton , Viresh Kumar , Shiraz Hashim , Russell King , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4a 02/38] ARM: spear: Do not use timer namespace for timer_shutdown() function Message-ID: <20221105140553.GC1606271@roeck-us.net> References: <20221105060024.598488967@goodmis.org> <20221105060155.228348078@goodmis.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221105060155.228348078@goodmis.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221105_070602_247992_9991F3EE X-CRM114-Status: GOOD ( 23.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Nov 05, 2022 at 02:00:26AM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > A new "shutdown" timer state is being added to the generic timer code. One > of the functions to change the timer into the state is called > "timer_shutdown()". This means that there can not be other functions > called "timer_shutdown()" as the timer code owns the "timer_*" name space. > > Rename timer_shutdown() to evt_timer_shutdown() to avoid this conflict. > > Cc: Viresh Kumar > Cc: Shiraz Hashim > Cc: Russell King > Cc: soc@kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Steven Rostedt (Google) Nitpick: I would have called it spear_timer_shutdown(). POV, so Reviewed-by: Guenter Roeck > --- > arch/arm/mach-spear/time.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-spear/time.c b/arch/arm/mach-spear/time.c > index e979e2197f8e..9629b8fae85f 100644 > --- a/arch/arm/mach-spear/time.c > +++ b/arch/arm/mach-spear/time.c > @@ -90,7 +90,7 @@ static void __init spear_clocksource_init(void) > 200, 16, clocksource_mmio_readw_up); > } > > -static inline void timer_shutdown(struct clock_event_device *evt) > +static inline void evt_timer_shutdown(struct clock_event_device *evt) > { > u16 val = readw(gpt_base + CR(CLKEVT)); > > @@ -101,7 +101,7 @@ static inline void timer_shutdown(struct clock_event_device *evt) > > static int spear_shutdown(struct clock_event_device *evt) > { > - timer_shutdown(evt); > + evt_timer_shutdown(evt); > > return 0; > } > @@ -111,7 +111,7 @@ static int spear_set_oneshot(struct clock_event_device *evt) > u16 val; > > /* stop the timer */ > - timer_shutdown(evt); > + evt_timer_shutdown(evt); > > val = readw(gpt_base + CR(CLKEVT)); > val |= CTRL_ONE_SHOT; > @@ -126,7 +126,7 @@ static int spear_set_periodic(struct clock_event_device *evt) > u16 val; > > /* stop the timer */ > - timer_shutdown(evt); > + evt_timer_shutdown(evt); > > period = clk_get_rate(gpt_clk) / HZ; > period >>= CTRL_PRESCALER16; > -- > 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel