From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEBE8C4332F for ; Mon, 7 Nov 2022 16:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u9rPQa5yfC4iCeGBb7jVYqewtin5iXMDfbKLJxVTg3w=; b=FRUfCGtefVp4SW tFx5U8LLj641adcEMQzVKlLB3iPwIAe/jZoGFAjDV+vSVLTwW611eovRJepV//g1pRYon4w96V+Ta WiE653gzMdkYj8Q+qCzzgR6fBGE/dMWqFsj82SBssRJsyoW9iSqfx3hqulFnwcfEXJZX8GPoud6YM FS/AD9F1l5jnKtMEusP7hrZfY7sFjubR5FrZa8cGT4jGZnSNRQKTEMOLLaC+fg4kGNBPHMjt5SXjK QZHVK7N8K29sFIijEFqiEbTBVZnif81yX++wiJNVTAaTMzNPkvl6IIPAzy9QSAb9u1eiXWi+iINnC 1qOYUPVLMlGj9Z/MkLAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1os4lW-00G4le-Co; Mon, 07 Nov 2022 16:14:27 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1os4lQ-00G4jW-2z for linux-arm-kernel@lists.infradead.org; Mon, 07 Nov 2022 16:14:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 73DF461172; Mon, 7 Nov 2022 16:14:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 597BEC433C1; Mon, 7 Nov 2022 16:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667837658; bh=8drlGFPWT+4zRBSJGyTdu5Q3x+jj0nADH5k69cVKWOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BA1A5ifIWCD5A52rdUTVJbghYPT4GLWS3cEeOuePzU+zC8zHluxCV1Bfvlkpm8viH 3sZsz07PQISTVga3BHnvC4fRJVKnlRhIvZvQuSuBY8r8bYQdiWZSV2hZ4zrJxZvyoG 8DQQ0jpscMw3e5R+k6zAvLJu9VA9oSVlKsCGecvZ8qT3KeYA2Od57twEPQ3o4NtnqS 9Udy3W4CQkdGgSnr93fyiZnEufgIWwmvRKyqeYTzLsZs/NmmNad0rHhxHdcCbzJfVN /lsjf4suUXEtvrRoHk0zo5tMx8cQdURfJsNvJA5pYb9RVsmIvkp/8p9Xdeda19jbgc ZeSwMmMh4m1Ww== Date: Mon, 7 Nov 2022 16:14:12 +0000 From: Will Deacon To: Pierre Gondois Cc: linux-kernel@vger.kernel.org, James Morse , Huacai Chen , John Garry , Shaokun Zhang , WANG Xuerui , Qi Liu , Bharat Bhushan , Huang Ying , Bibo Mao , "Jason A. Donenfeld" , Daniel Lezcano , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] firmware: arm_sdei: Fix sleep from invalid context BUG Message-ID: <20221107161411.GF21157@willie-the-truck> References: <20221018130456.1356081-1-pierre.gondois@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221018130456.1356081-1-pierre.gondois@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221107_081420_241019_EB0B5647 X-CRM114-Status: GOOD ( 19.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 18, 2022 at 03:04:53PM +0200, Pierre Gondois wrote: > On an Ampere Altra, > Running a preemp_rt kernel based on v5.19-rc3-rt5 on an > Ampere Altra triggers: > [ 15.683141] BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:46 > [ 15.683154] in_atomic(): 0, irqs_disabled(): 128, non_block: 0, pid: 24, name: cpuhp/0 > [ 15.683157] preempt_count: 0, expected: 0 > [ 15.683159] RCU nest depth: 0, expected: 0 > [ 15.683163] 3 locks held by cpuhp/0/24: > [ 15.683167] #0: ffffda30217c70d0 (cpu_hotplug_lock){++++}-{0:0}, at: cpuhp_thread_fun+0x5c/0x248 > [ 15.683201] #1: ffffda30217c7120 (cpuhp_state-up){+.+.}-{0:0}, at: cpuhp_thread_fun+0x5c/0x248 > [ 15.683205] #2: ffffda3021c711f0 (sdei_list_lock){....}-{3:3}, at: sdei_cpuhp_up+0x3c/0x130 > [ 15.683224] irq event stamp: 36 > [ 15.683226] hardirqs last enabled at (35): [] finish_task_switch+0xb4/0x2b0 > [ 15.683236] hardirqs last disabled at (36): [] cpuhp_thread_fun+0x21c/0x248 > [ 15.683238] softirqs last enabled at (0): [] copy_process+0x63c/0x1ac0 > [ 15.683245] softirqs last disabled at (0): [<0000000000000000>] 0x0 > [ 15.683258] CPU: 0 PID: 24 Comm: cpuhp/0 Not tainted 5.19.0-rc3-rt5-[...] > [ 15.683265] Hardware name: WIWYNN Mt.Jade Server System B81.03001.0005/Mt.Jade Motherboard, BIOS 1.08.20220218 (SCP: 1.08.20220218) 2022/02/18 > [ 15.683268] Call trace: > [ 15.683271] dump_backtrace+0x114/0x120 > [ 15.683277] show_stack+0x20/0x70 > [ 15.683279] dump_stack_lvl+0x9c/0xd8 > [ 15.683288] dump_stack+0x18/0x34 > [ 15.683289] __might_resched+0x188/0x228 > [ 15.683292] rt_spin_lock+0x70/0x120 > [ 15.683301] sdei_cpuhp_up+0x3c/0x130 > [ 15.683303] cpuhp_invoke_callback+0x250/0xf08 > [ 15.683305] cpuhp_thread_fun+0x120/0x248 > [ 15.683308] smpboot_thread_fn+0x280/0x320 > [ 15.683315] kthread+0x130/0x140 > [ 15.683321] ret_from_fork+0x10/0x20 > > sdei_cpuhp_up() is called in the STARTING hotplug section, > which runs whith interrupts disabled. Move CPUHP_AP_ARM_SDEI_ > state to the _ONLINE section to execute the cpuhp cb with > preemption enabled. > > Some SDEI calls (e.g. SDEI_1_0_FN_SDEI_PE_MASK) take actions on the > calling CPU. It is checked that preemption is disabled for them. > _ONLINE cpuhp cb are executed in the 'per CPU hotplug thread'. > Preemption is enabled in those threads, but their cpumask is limited > to 1 CPU. > Move 'WARN_ON_ONCE(preemptible())' statements so that SDEI cpuhp cb > don't trigger them. This means that no check will be done for some > cases, e.g. sdei_mask_local_cpu() invocations. > > Also add a check for the SDEI_1_0_FN_SDEI_PRIVATE_RESET SDEI call > which acts on the calling CPU. > > Suggested-by: James Morse > Signed-off-by: Pierre Gondois > --- > drivers/firmware/arm_sdei.c | 28 ++++++++++++++-------------- > include/linux/cpuhotplug.h | 2 +- > 2 files changed, 15 insertions(+), 15 deletions(-) James -- are you taking care of this one, or should I queue it via arm64? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel