From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, etnaviv@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-media@vger.kernel.org, linux-kselftest@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>, Nadav Amit <namit@vmware.com>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Muchun Song <songmuchun@bytedance.com>,
Lucas Stach <l.stach@pengutronix.de>,
David Airlie <airlied@gmail.com>,
Oded Gabbay <ogabbay@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH RFC 03/19] selftests/vm: cow: R/O long-term pinning reliability tests for non-anon pages
Date: Mon, 7 Nov 2022 17:17:24 +0100 [thread overview]
Message-ID: <20221107161740.144456-4-david@redhat.com> (raw)
In-Reply-To: <20221107161740.144456-1-david@redhat.com>
Let's test whether R/O long-term pinning is reliable for non-anonymous
memory: when R/O long-term pinning a page, the expectation is that we
break COW early before pinning, such that actual write access via the
page tables won't break COW later and end up replacing the R/O-pinned
page in the page table.
Consequently, R/O long-term pinning in private mappings would only target
exclusive anonymous pages.
For now, all tests fail:
# [RUN] R/O longterm GUP pin ... with shared zeropage
not ok 151 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP pin ... with memfd
not ok 152 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP pin ... with tmpfile
not ok 153 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP pin ... with huge zeropage
not ok 154 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP pin ... with memfd hugetlb (2048 kB)
not ok 155 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP pin ... with memfd hugetlb (1048576 kB)
not ok 156 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP-fast pin ... with shared zeropage
not ok 157 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP-fast pin ... with memfd
not ok 158 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP-fast pin ... with tmpfile
not ok 159 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP-fast pin ... with huge zeropage
not ok 160 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP-fast pin ... with memfd hugetlb (2048 kB)
not ok 161 Longterm R/O pin is reliable
# [RUN] R/O longterm GUP-fast pin ... with memfd hugetlb (1048576 kB)
not ok 162 Longterm R/O pin is reliable
Signed-off-by: David Hildenbrand <david@redhat.com>
---
tools/testing/selftests/vm/cow.c | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/vm/cow.c b/tools/testing/selftests/vm/cow.c
index 93c643bcdcf5..40ba45d0c6b4 100644
--- a/tools/testing/selftests/vm/cow.c
+++ b/tools/testing/selftests/vm/cow.c
@@ -534,6 +534,7 @@ static void test_iouring_fork(char *mem, size_t size)
#endif /* LOCAL_CONFIG_HAVE_LIBURING */
enum ro_pin_test {
+ RO_PIN_TEST,
RO_PIN_TEST_SHARED,
RO_PIN_TEST_PREVIOUSLY_SHARED,
RO_PIN_TEST_RO_EXCLUSIVE,
@@ -566,6 +567,8 @@ static void do_test_ro_pin(char *mem, size_t size, enum ro_pin_test test,
}
switch (test) {
+ case RO_PIN_TEST:
+ break;
case RO_PIN_TEST_SHARED:
case RO_PIN_TEST_PREVIOUSLY_SHARED:
/*
@@ -1150,6 +1153,16 @@ static void test_cow(char *mem, const char *smem, size_t size)
free(old);
}
+static void test_ro_pin(char *mem, const char *smem, size_t size)
+{
+ do_test_ro_pin(mem, size, RO_PIN_TEST, false);
+}
+
+static void test_ro_fast_pin(char *mem, const char *smem, size_t size)
+{
+ do_test_ro_pin(mem, size, RO_PIN_TEST, true);
+}
+
static void run_with_zeropage(non_anon_test_fn fn, const char *desc)
{
char *mem, *smem, tmp;
@@ -1390,7 +1403,7 @@ struct non_anon_test_case {
};
/*
- * Test cases that target any pages in private mappings that are non anonymous:
+ * Test cases that target any pages in private mappings that are not anonymous:
* pages that may get shared via COW ndependent of fork(). This includes
* the shared zeropage(s), pagecache pages, ...
*/
@@ -1403,6 +1416,19 @@ static const struct non_anon_test_case non_anon_test_cases[] = {
"Basic COW",
test_cow,
},
+ /*
+ * Take a R/O longterm pin. When modifying the page via the page table,
+ * the page content change must be visible via the pin.
+ */
+ {
+ "R/O longterm GUP pin",
+ test_ro_pin,
+ },
+ /* Same as above, but using GUP-fast. */
+ {
+ "R/O longterm GUP-fast pin",
+ test_ro_fast_pin,
+ },
};
static void run_non_anon_test_case(struct non_anon_test_case const *test_case)
--
2.38.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-07 16:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 16:17 [PATCH RFC 00/19] mm/gup: remove FOLL_FORCE usage from drivers (reliable R/O long-term pinning) David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 01/19] selftests/vm: anon_cow: prepare for non-anonymous COW tests David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 02/19] selftests/vm: cow: basic COW tests for non-anonymous pages David Hildenbrand
2022-11-07 16:17 ` David Hildenbrand [this message]
2022-11-07 16:17 ` [PATCH RFC 04/19] mm: add early FAULT_FLAG_UNSHARE consistency checks David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 05/19] mm: add early FAULT_FLAG_WRITE " David Hildenbrand
2022-11-07 19:03 ` Nadav Amit
2022-11-07 19:27 ` David Hildenbrand
2022-11-07 19:50 ` Nadav Amit
2022-11-07 16:17 ` [PATCH RFC 06/19] mm: rework handling in do_wp_page() based on private vs. shared mappings David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 07/19] mm: don't call vm_ops->huge_fault() in wp_huge_pmd()/wp_huge_pud() for private mappings David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 08/19] mm: extend FAULT_FLAG_UNSHARE support to anything in a COW mapping David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 09/19] mm/gup: reliable R/O long-term pinning in COW mappings David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 10/19] RDMA/umem: remove FOLL_FORCE usage David Hildenbrand
2022-11-14 8:30 ` Leon Romanovsky
2022-11-07 16:17 ` [PATCH RFC 11/19] RDMA/usnic: " David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 12/19] RDMA/siw: " David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 13/19] media: videobuf-dma-sg: " David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 14/19] drm/etnaviv: " David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 15/19] media: pci/ivtv: " David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 16/19] mm/frame-vector: " David Hildenbrand
2022-11-08 4:45 ` Tomasz Figa
2022-11-08 9:40 ` David Hildenbrand
2022-11-22 12:25 ` Hans Verkuil
2022-11-22 12:38 ` David Hildenbrand
2022-11-22 14:07 ` Hans Verkuil
2022-11-22 15:03 ` David Hildenbrand
2022-11-22 17:33 ` Linus Torvalds
2022-11-07 16:17 ` [PATCH RFC 17/19] drm/exynos: " David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 18/19] RDMA/hw/qib/qib_user_pages: " David Hildenbrand
2022-11-07 16:17 ` [PATCH RFC 19/19] habanalabs: " David Hildenbrand
2022-11-07 21:25 ` Oded Gabbay
2022-11-07 17:27 ` [PATCH RFC 00/19] mm/gup: remove FOLL_FORCE usage from drivers (reliable R/O long-term pinning) Linus Torvalds
2022-11-08 9:29 ` David Hildenbrand
2022-11-14 6:03 ` Christoph Hellwig
2022-11-14 8:07 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107161740.144456-4-david@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=namit@vmware.com \
--cc=ogabbay@kernel.org \
--cc=peterx@redhat.com \
--cc=songmuchun@bytedance.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).