From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 848DCC43219 for ; Mon, 7 Nov 2022 21:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f1AR1eA7sRqZroU5gk+aet/Cmvefem2xs32r+5xS5es=; b=X6nX0t7KyBV+pm DmGke0Is0xnRjVSCqRds6PiYSz9EaZjo3CVAkQBM6BS4kdv6czHEZB7YB5ILv/6gbQcJij6WqGVEw r84k1qfF9eO5U/EfgLgI7tGyM1ptWeamUQWot5xa35ZpsYeQBFTH52Rj/ZGKi1QD2Tvl2JFMnxXQk /GjbzzrlVPcQaC2M9YCTbjkVx5/r3bGLBpl++MVA3nOAQtB6/YJJa/2o6iEH90gTNNGTZwNqD0iJC BJe8frogXrS89IBZLeVPA1ljvksOc/lYw7lo/JwAWGNmZvsiVTaevq0Or11sNs1EbmtaYSSALItq+ 0qFj3CB1lBFJiWzMJSVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1os9ZU-000cYJ-SM; Mon, 07 Nov 2022 21:22:21 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1os9ZS-000cX5-0g; Mon, 07 Nov 2022 21:22:19 +0000 Received: by mail-ed1-x529.google.com with SMTP id l11so19635906edb.4; Mon, 07 Nov 2022 13:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ddfhd8XwpJplivFsJcCTYCRWaroeD5Sk1QzcIWWbS0c=; b=Vy+4wxJA858HcqoCK36dhDhINBXnhv2nNfAeudikvcqnMjt4BeCjjPNOutf2MHEISB rKnZa/bY+ndMJsOY+D9hqnnFJj7SVekwqfY7YUzgvyZnC2WFkL749Fqcvw2Ua7yddi58 J6VIqP+D9q0qWbMsDy6/Szyr+JjA8lByTCbKEbR/SbeWxHVT1ATRe//GcFKGfKLGNwCk WtS5mG9Y+Uq4IA2KxpKxFDZNNNaB2m9+1qDhGs3TuBKJlW75KGc5Zi4EAuBUoxdpzFMy qW7IInIrO9+7KZCObQPN7q0BRVaj6cf6HDk3e2Pb1jF5aW4VwTPxS6Xu8Dybb2d4v7CN LIKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ddfhd8XwpJplivFsJcCTYCRWaroeD5Sk1QzcIWWbS0c=; b=VjJ8zGTiY/c5gxYfXfJCtPH/0vR33S9Oj3j3hk4OkR5WCulqbJbK3L5zg3p0HR9bSp SKGTV09QmtyI+j+BF06amQYzwRgZSVR3IXLY/ZJYV7fGGCR4m+BhrbEFa4ZRb2ozc+jj SrAD9G1JPZq4hybR5cyXEH4hLD+A1+hgcQnqRG27jar9ybf53LR4FusNzosBHz4Ujapc Ty8NCucndUfmjhsOiv5Pb7AeF9/IYaLzp9zq5rCbulMK+Sxb/ai4pl4ITvf4nThZoi7e jCqV2+NZkeypjAmsdKg+jeM8XLzirBgKIuLBg2dM5NEeeNbjXHOxWEbo/2l85XqLXBLe gmRw== X-Gm-Message-State: ACrzQf2uLoVbD1nFDppnErDWt/GJSCdf2pcvmR+yukzXtHro6j2qTMfY kwIvpYWVCA4pcJdaJ2V2Q+k5gJKVBzm5UQ== X-Google-Smtp-Source: AMsMyM547z9exzJ4wJkpKqv+MqMTl8XFdxtr/iBjb4PZ9RziUaFERL6bJernT2uTQc2z4uSNEne6xg== X-Received: by 2002:aa7:d5c1:0:b0:459:2515:b27b with SMTP id d1-20020aa7d5c1000000b004592515b27bmr843867eds.338.1667856135756; Mon, 07 Nov 2022 13:22:15 -0800 (PST) Received: from skbuf ([188.27.184.197]) by smtp.gmail.com with ESMTPSA id m19-20020a056402051300b00459cd13fd34sm4615155edv.85.2022.11.07.13.22.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 13:22:15 -0800 (PST) Date: Mon, 7 Nov 2022 23:22:09 +0200 From: Vladimir Oltean To: Felix Fietkau Cc: netdev@vger.kernel.org, Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/14] net: dsa: tag_mtk: assign per-port queues Message-ID: <20221107212209.4pmoctkze4m2ggbv@skbuf> References: <20221107185452.90711-1-nbd@nbd.name> <20221107185452.90711-5-nbd@nbd.name> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221107185452.90711-5-nbd@nbd.name> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221107_132218_098838_45A320C0 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 07, 2022 at 07:54:43PM +0100, Felix Fietkau wrote: > Keeps traffic sent to the switch within link speed limits > > Signed-off-by: Felix Fietkau > --- > net/dsa/tag_mtk.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/dsa/tag_mtk.c b/net/dsa/tag_mtk.c > index 415d8ece242a..445d6113227f 100644 > --- a/net/dsa/tag_mtk.c > +++ b/net/dsa/tag_mtk.c > @@ -25,6 +25,9 @@ static struct sk_buff *mtk_tag_xmit(struct sk_buff *skb, > u8 xmit_tpid; > u8 *mtk_tag; > > + /* Reserve the first three queues for packets not passed through DSA */ > + skb_set_queue_mapping(skb, 3 + dp->index); > + Should DSA have to care about this detail, or could you rework your mtk_select_queue() procedure to adjust the queue mapping as needed? > /* Build the special tag after the MAC Source Address. If VLAN header > * is present, it's required that VLAN header and special tag is > * being combined. Only in this way we can allow the switch can parse > -- > 2.38.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel