From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41997C433FE for ; Tue, 8 Nov 2022 14:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bfXYQ/3w3spzTNhYvkl94wrqZcY0UxxlcGEaZGdg+ZU=; b=sTjIOdtqDtukpJ 0Z16XStYA3aeDs+OgLdxMyxminPo2ZAEp0NmBE8+MRNnlSXqhDHYKi9tMsbf8C8VqG7Xao80uTxCZ WiR9Dx+gMr3dMTdKIvr8dhMd0Mh9pvErwZRVE/+s3envmHZrbr/FidtoLUMapFHPklZLji7MoZUUz 96CgRGHPuSky5W7LXM4NwZZCnlgbciCtBF2twSjY8OjznjUkXq63h463eUcdITy+o5exBRw44tw/I nELXd7npXeuMKSctY3IfuF1IItVyBL5uXUoJw0eZHHLSPRpicDS05+ESb9KeqTtNVwRKqg0z2O+cc FAy7lT3udk03J+ooTopQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osQ2H-006ACN-HN; Tue, 08 Nov 2022 14:57:09 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osQ2E-006ABQ-Fc for linux-arm-kernel@lists.infradead.org; Tue, 08 Nov 2022 14:57:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 197B9B8171A; Tue, 8 Nov 2022 14:57:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4607C433D7; Tue, 8 Nov 2022 14:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667919423; bh=8/7+dZAfZ4oLmH8C5GDxy0YK9sTb0CaI2LgkvYa7ypQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZRp4TDwm4I6QtzjpO11Izbisr1RkIA9BCxRVOMSVPsbk18zDUBJ9ttSLeJHbIfbf9 L1eSjllGAic8am5jy6YYT56gFXtkN/46a3IxdvLgU+ksVStZxfofSJGjQZJhKgwEhL bNXDRi1yAal0PXnhf4o4WEKMXE8FWJ40A6j5W05XrVQEr/VWtQFbMVinKMYgQIHaDL 8URElVjmbBaraVEzwEaDDdN5RBwKKjb/aWjNI/B4B6AztrPlxCQzfFv1glqW3oBTiW RhXlSkPTse1RWcr9pHvmDc8i92xJQr1Q2q4rb2LSKHXdfaDRANkdCDJGhOQeVmiqa+ /3iQgOV061IJA== Date: Tue, 8 Nov 2022 14:56:57 +0000 From: Will Deacon To: Mark Rutland Cc: Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Eric Biggers , "Jason A . Donenfeld" , Kees Cook , Suzuki K Poulose , Adam Langley Subject: Re: [PATCH v2] arm64: Enable data independent timing (DIT) in the kernel Message-ID: <20221108145656.GA23059@willie-the-truck> References: <20221107172400.1851434-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221108_065706_684446_1FB0BCDD X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 08, 2022 at 02:41:26PM +0000, Mark Rutland wrote: > On Mon, Nov 07, 2022 at 06:24:00PM +0100, Ard Biesheuvel wrote: > > diff --git a/arch/arm64/kernel/suspend.c b/arch/arm64/kernel/suspend.c > > index 8b02d310838f9240..3032a82ea51a19f7 100644 > > --- a/arch/arm64/kernel/suspend.c > > +++ b/arch/arm64/kernel/suspend.c > > @@ -60,6 +60,8 @@ void notrace __cpu_suspend_exit(void) > > * PSTATE was not saved over suspend/resume, re-enable any detected > > * features that might not have been set correctly. > > */ > > + if (cpu_has_dit()) > > + set_pstate_dit(1); > > As above, I'd prefer if we either renamed cpu_has_dit() to cpus_have_dit(), or > just open-coded this as: > > if (cpus_have_const_cap(ARM64_HAS_DIT)) > set_pstate_dit(1); > > With either of those options: > > Acked-by: Mark Rutland > > I assume Will might fix that up when applying. Yup, I'll take care of that. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel