From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91B3FC4332F for ; Wed, 9 Nov 2022 06:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JRSndyTYWjm9oye6bAuP6JczNJWgtUr8ffXKkcr3AQA=; b=OKLDg+H8HmoUOa tFiXQ8jmop4Xj7WOLopDTizie3PMXKj4/IM8gE0be7GhkhgYvXz+JOdePZw0TCcU4aEi7G5QewfPP ubTqJLAoeczpFA8CucG13emZh5ip1XV6BcQQc8vz6FLDigyCkQTyMZv8ZAjn5yYtvHqsMzd7fLUnW 23ETwtuNVDEFGNVEEe/mwgpfQLGLMb6epjs60lwlggIlwKBJ03f5lMJomTPHQOEdQSaQXmJRoyNoR hvw/2N5yLy8r9LJ+/hZzXFgFF9GaJsNdtyEhJYfGHNpxTgr5vc9qxUIrIKxfzVQoSDvFcm0HETy5J FmB2ajSqnH4oLgA0+NDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oseZK-00BA3U-SB; Wed, 09 Nov 2022 06:28:14 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oseZH-00B9nt-P5; Wed, 09 Nov 2022 06:28:13 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 143A868AFE; Wed, 9 Nov 2022 07:28:09 +0100 (CET) Date: Wed, 9 Nov 2022 07:28:08 +0100 From: Christoph Hellwig To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , Chaitanya Kulkarni , Gerd Bayer , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 04/12] nvme-pci: put the admin queue in nvme_dev_remove_admin Message-ID: <20221109062808.GE10528@lst.de> References: <20221108150252.2123727-1-hch@lst.de> <20221108150252.2123727-5-hch@lst.de> <679cf80b-3e30-e393-d5c4-d3941e853bfb@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <679cf80b-3e30-e393-d5c4-d3941e853bfb@grimberg.me> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221108_222811_976870_ECB5EAFF X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 09, 2022 at 04:58:46AM +0200, Sagi Grimberg wrote: >> @@ -2774,8 +2775,6 @@ static void nvme_pci_free_ctrl(struct nvme_ctrl *ctrl) >> nvme_dbbuf_dma_free(dev); >> nvme_free_tagset(dev); >> - if (dev->ctrl.admin_q) >> - blk_put_queue(dev->ctrl.admin_q); > > Is the check here valid? meaning can we get here with > a NULL admin_q? Yes, the admin queue is only set in the middle of nvme_reset_work, and for errors before that we can get here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel