From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF9E5C4332F for ; Wed, 9 Nov 2022 06:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5BkziUePS+CiUVOKuEsectvrEtqDlLlmc99TSlJxtKM=; b=2T0eMxB/Hi3tZa 6hoWVZRbBygl4sVdPla6O3W825SJAu7ZbvwjAijsrz+6TZ8ArLRBphAFfSXFRrVYMkt2ZpDlrMzo3 5eQEK/VuXEaICSLJ/KAPvBDQHiCcMlPoobQzeUEI/NjsWucuGqI/KRBAKcpJym78Crqm0gqp9uqI/ ZG3xhj+yd0YTS5RCdMA+hC9zVOa4uue8HB2nJIhlPEWiyqKAyywKCQnfnXXo6vKqXk9cqwnVV0Gdu DRzIycFUHIsKQCpnASXJfNmVM0V04KhwpjZz7ub6KQufiBUIwMGwPTC1C7rlchiEbIVf9M7IzWZDZ IFRdy0XLa40AlGBri7WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oseZt-00BATa-F4; Wed, 09 Nov 2022 06:28:49 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oseZr-00BASX-4a; Wed, 09 Nov 2022 06:28:48 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 7557C68AFE; Wed, 9 Nov 2022 07:28:44 +0100 (CET) Date: Wed, 9 Nov 2022 07:28:44 +0100 From: Christoph Hellwig To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , Chaitanya Kulkarni , Gerd Bayer , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 07/12] nvme-pci: factor out a nvme_pci_alloc_ctrl helper Message-ID: <20221109062844.GF10528@lst.de> References: <20221108150252.2123727-1-hch@lst.de> <20221108150252.2123727-8-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221108_222847_345116_1725E289 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 09, 2022 at 05:03:19AM +0200, Sagi Grimberg wrote: >> -static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id >> *id) >> +static struct nvme_dev *nvme_pci_alloc_ctrl(struct pci_dev *pdev, >> + const struct pci_device_id *id) > > kinda weird that nvme_pci_alloc_ctrl return struct nvme_dev. Patch looks > fine though... We can call it alloc_dev instead. But that whole nvme_dev naming is weird, it really should be nvme_pci_ctrl. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel