From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 851DDC4332F for ; Wed, 9 Nov 2022 06:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yQpW5uGF9q8Le3+yjavQ9atrihfOR0WOypadCTZ4W9Q=; b=F6UpxLfulycKzg 2cRnF/AQ1YiOdf+03EJ8A4s5qPTpk9/Hg7mzG26EjFZ58X9Czrb0ooVI4xdsI5xg2xf0wB1p1ncEh QdXMllLApBKoWRiyR5j9Qg43l8prbIYbG0dVJz0FhJQU7P+Igo7uaGCfIOQtak8clBd0XE1RhJoM3 b5pYAvSBk/gg/q1MhY8/Pf6vDUZZEVH3pOkk9bF5dHT9rME3Rl0faaxjAyjoWHeMDiTo4gNnGqTX1 2zEc2k68AhKC6lv+SGJNCHqBPRE+6fYP0Afc1ioPMsWk58EFre9yLbFaSm4ftJZrRWDvFEaMH6ZpY bSsBAU5RWr78fL18YYyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osecP-00BCsa-UX; Wed, 09 Nov 2022 06:31:26 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osecN-00BCm6-C1; Wed, 09 Nov 2022 06:31:24 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 9EDF068AFE; Wed, 9 Nov 2022 07:31:19 +0100 (CET) Date: Wed, 9 Nov 2022 07:31:19 +0100 From: Christoph Hellwig To: Sagi Grimberg Cc: Christoph Hellwig , Keith Busch , Chaitanya Kulkarni , Gerd Bayer , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 11/12] nvme-pci: split the initial probe from the rest path Message-ID: <20221109063119.GG10528@lst.de> References: <20221108150252.2123727-1-hch@lst.de> <20221108150252.2123727-12-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221108_223123_586405_AFA6999C X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 09, 2022 at 05:14:02AM +0200, Sagi Grimberg wrote: >> - if (dev->online_queues > 1) { >> - nvme_pci_alloc_tag_set(dev); >> - nvme_dbbuf_set(dev); >> - } else { >> - dev_warn(dev->ctrl.device, "IO queues not created\n"); >> - } >> + dev_warn(dev->ctrl.device, "IO queues lost\n"); >> + nvme_mark_namespaces_dead(&dev->ctrl); >> + nvme_start_queues(&dev->ctrl); >> + nvme_remove_namespaces(&dev->ctrl); > > Is this needed? isn't nvme_remove coming soon? > In fact, shouldn't all these calls be in nvme_remove? This handles the case where a controller controller does not have I/O queues. For controllers that never had them (e.g. admin controllers) none of the three calls above is needed, but they deal with the case where a controller had queues, but they are going away. I'm not sure if that can happen, but it keeps the behavior of the existing code. Keith wrote it to deal with Intel controllers that can be in a degraded state where having the admin queue live even without I/O queues allows updating the firmware, so he might know more. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel