From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: Shaokun Zhang <zhangshaokun@hisilicon.com>, <liuqi6124@gmail.com>,
Jonathan Corbet <corbet@lwn.net>, Will Deacon <will@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
John Garry <john.garry@huawei.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-doc@vger.kernel.org>, <linuxarm@huawei.com>,
<f.fangjian@huawei.com>, <prime.zeng@huawei.com>
Subject: Re: [PATCH 1/3] drivers/perf: hisi: Fix some event id for hisi-pcie-pmu
Date: Wed, 9 Nov 2022 16:59:52 +0000 [thread overview]
Message-ID: <20221109165952.000053f3@Huawei.com> (raw)
In-Reply-To: <20221025113242.58271-2-yangyicong@huawei.com>
On Tue, 25 Oct 2022 19:32:40 +0800
Yicong Yang <yangyicong@huawei.com> wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> Some event id of hisi-pcie-pmu is incorrect, fix them.
>
> Fixes: 8404b0fbc7fb ("drivers/perf: hisi: Add driver for HiSilicon PCIe PMU")
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
FWIW given these are magic value updates.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/perf/hisilicon/hisi_pcie_pmu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c
> index 21771708597d..071e63d9a9ac 100644
> --- a/drivers/perf/hisilicon/hisi_pcie_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c
> @@ -693,10 +693,10 @@ static struct attribute *hisi_pcie_pmu_events_attr[] = {
> HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_cnt, 0x10210),
> HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_latency, 0x0011),
> HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_cnt, 0x10011),
> - HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_flux, 0x1005),
> - HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_time, 0x11005),
> - HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_flux, 0x2004),
> - HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_time, 0x12004),
> + HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_flux, 0x0804),
> + HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_time, 0x10804),
> + HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_flux, 0x0405),
> + HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_time, 0x10405),
> NULL
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-09 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 11:32 [PATCH 0/3] Add TLP filter support and some fixes for HiSilicon PCIe PMU Yicong Yang
2022-10-25 11:32 ` [PATCH 1/3] drivers/perf: hisi: Fix some event id for hisi-pcie-pmu Yicong Yang
2022-11-09 16:59 ` Jonathan Cameron [this message]
2022-10-25 11:32 ` [PATCH 2/3] docs: perf: Fix PMU instance name of hisi-pcie-pmu Yicong Yang
2022-11-09 17:02 ` Jonathan Cameron
2022-10-25 11:32 ` [PATCH 3/3] drivers/perf: hisi: Add TLP filter support Yicong Yang
2022-11-09 17:09 ` Jonathan Cameron
2022-11-10 2:45 ` Yicong Yang
2022-11-10 4:16 ` Bagas Sanjaya
2022-11-10 8:34 ` Yicong Yang
2022-11-08 11:20 ` [PATCH 0/3] Add TLP filter support and some fixes for HiSilicon PCIe PMU Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109165952.000053f3@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=corbet@lwn.net \
--cc=f.fangjian@huawei.com \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuqi6124@gmail.com \
--cc=mark.rutland@arm.com \
--cc=prime.zeng@huawei.com \
--cc=will@kernel.org \
--cc=yangyicong@huawei.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).