From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0089C4332F for ; Wed, 9 Nov 2022 17:03:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9/J/EW+lKczPdC1CuP+aU4azsKOj4Cw8Ti7heDudhlw=; b=IskDImKU8r6Du7 rymCO328YsR7kmMG3kS8qKPEveO+MwhZDM5dAFVAOWd3v9M+B2QNyEVmnTEjwvGZ+vluF+6W2VWVa QQcCrO0WS4KLTPFO6y1Gre4bh890swUs1ObFJY9fwb6OmHWvyvABSRxSdcOiL17iljqPnkEdth073 U5i36OYN0uSz4m/XjONrZXvrnvsfVFHxNbAhMQ7zzxQ85hfsOCBdU7SVx31fBao1lvbxb10qpaHEI JCvf70PgXH6p+NRppGG99h0YWa0idT3sH+edpE3rL8tVRrk7JjKNSg5Gs5NWZ7oIZLOEYl9vCjFGh bI1gNaaP3puWIerT703A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osoSr-00FJz6-3G; Wed, 09 Nov 2022 17:02:13 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osoSk-00FJsr-7m for linux-arm-kernel@lists.infradead.org; Wed, 09 Nov 2022 17:02:08 +0000 Received: from frapeml100004.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4N6rmv4jP7z67yhg; Thu, 10 Nov 2022 00:59:59 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by frapeml100004.china.huawei.com (7.182.85.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 18:02:03 +0100 Received: from localhost (10.45.145.27) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 17:02:02 +0000 Date: Wed, 9 Nov 2022 17:02:02 +0000 From: Jonathan Cameron To: Yicong Yang CC: Shaokun Zhang , , Jonathan Corbet , Will Deacon , "Mark Rutland" , John Garry , , , , , , Subject: Re: [PATCH 2/3] docs: perf: Fix PMU instance name of hisi-pcie-pmu Message-ID: <20221109170202.00002ddd@Huawei.com> In-Reply-To: <20221025113242.58271-3-yangyicong@huawei.com> References: <20221025113242.58271-1-yangyicong@huawei.com> <20221025113242.58271-3-yangyicong@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.45.145.27] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221109_090206_617629_189CC3C6 X-CRM114-Status: GOOD ( 17.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 25 Oct 2022 19:32:41 +0800 Yicong Yang wrote: > From: Yicong Yang > > The PMU instance will be called hisi_pcie_core rather than > hisi_pcie_. Fix this in the documentation. > > Fixes: c8602008e247 ("docs: perf: Add description for HiSilicon PCIe PMU driver") > Signed-off-by: Yicong Yang Indeed matches with naming from the driver: https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/perf/hisilicon/hisi_pcie_pmu.c#L774 Reviewed-by: Jonathan Cameron > --- > .../admin-guide/perf/hisi-pcie-pmu.rst | 22 +++++++++---------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/Documentation/admin-guide/perf/hisi-pcie-pmu.rst b/Documentation/admin-guide/perf/hisi-pcie-pmu.rst > index 294ebbdb22af..bbe66480ff85 100644 > --- a/Documentation/admin-guide/perf/hisi-pcie-pmu.rst > +++ b/Documentation/admin-guide/perf/hisi-pcie-pmu.rst > @@ -15,10 +15,10 @@ HiSilicon PCIe PMU driver > The PCIe PMU driver registers a perf PMU with the name of its sicl-id and PCIe > Core id.:: > > - /sys/bus/event_source/hisi_pcie_ > + /sys/bus/event_source/hisi_pcie_core > > PMU driver provides description of available events and filter options in sysfs, > -see /sys/bus/event_source/devices/hisi_pcie_. > +see /sys/bus/event_source/devices/hisi_pcie_core. > > The "format" directory describes all formats of the config (events) and config1 > (filter options) fields of the perf_event_attr structure. The "events" directory > @@ -33,13 +33,13 @@ monitored by PMU. > Example usage of perf:: > > $# perf list > - hisi_pcie0_0/rx_mwr_latency/ [kernel PMU event] > - hisi_pcie0_0/rx_mwr_cnt/ [kernel PMU event] > + hisi_pcie0_core0/rx_mwr_latency/ [kernel PMU event] > + hisi_pcie0_core0/rx_mwr_cnt/ [kernel PMU event] > ------------------------------------------ > > - $# perf stat -e hisi_pcie0_0/rx_mwr_latency/ > - $# perf stat -e hisi_pcie0_0/rx_mwr_cnt/ > - $# perf stat -g -e hisi_pcie0_0/rx_mwr_latency/ -e hisi_pcie0_0/rx_mwr_cnt/ > + $# perf stat -e hisi_pcie0_core0/rx_mwr_latency/ > + $# perf stat -e hisi_pcie0_core0/rx_mwr_cnt/ > + $# perf stat -g -e hisi_pcie0_core0/rx_mwr_latency/ -e hisi_pcie0_core0/rx_mwr_cnt/ > > The current driver does not support sampling. So "perf record" is unsupported. > Also attach to a task is unsupported for PCIe PMU. > @@ -64,7 +64,7 @@ bit8 is set, port=0x100; if these two Root Ports are both monitored, port=0x101. > > Example usage of perf:: > > - $# perf stat -e hisi_pcie0_0/rx_mwr_latency,port=0x1/ sleep 5 > + $# perf stat -e hisi_pcie0_core0/rx_mwr_latency,port=0x1/ sleep 5 > > -bdf > > @@ -76,7 +76,7 @@ For example, "bdf=0x3900" means BDF of target Endpoint is 0000:39:00.0. > > Example usage of perf:: > > - $# perf stat -e hisi_pcie0_0/rx_mrd_flux,bdf=0x3900/ sleep 5 > + $# perf stat -e hisi_pcie0_core0/rx_mrd_flux,bdf=0x3900/ sleep 5 > > 2. Trigger filter > Event statistics start when the first time TLP length is greater/smaller > @@ -90,7 +90,7 @@ means start when TLP length < condition. > > Example usage of perf:: > > - $# perf stat -e hisi_pcie0_0/rx_mrd_flux,trig_len=0x4,trig_mode=1/ sleep 5 > + $# perf stat -e hisi_pcie0_core0/rx_mrd_flux,trig_len=0x4,trig_mode=1/ sleep 5 > > 3. Threshold filter > Counter counts when TLP length within the specified range. You can set the > @@ -103,4 +103,4 @@ when TLP length < threshold. > > Example usage of perf:: > > - $# perf stat -e hisi_pcie0_0/rx_mrd_flux,thr_len=0x4,thr_mode=1/ sleep 5 > + $# perf stat -e hisi_pcie0_core0/rx_mrd_flux,thr_len=0x4,thr_mode=1/ sleep 5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel