From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 584DBC433FE for ; Thu, 10 Nov 2022 19:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0fD/CtUMbq7dtvEbh3bVGK7ppB/WKwYjA7l6SR+JsFE=; b=BWjr/xmXVdgIQc O8QjOXAZ/DK+XvOvI5ENphyFMbiTFjgmdIOHmHkt95LMDEyFW0KNy4CgYBJ360WAvK3+iQPtLZYyA ye1CddPkk5ytnvsJncL0oeXLqegyx5wKA0J8IF5gTcFKDol8Cz06Ff4urXh22Fp3spP5ewnzQkZ92 fprY43MAvcVfKgwx8O2eHpfeAGAscCcaybjWkYfBIA5vD8uWi4/96EFkcYPscou1G+I5ErPEpdj4O SuZOXsoQuJhVuDu3LnQxYzkKk/3z2/K1K4Apf9lreXYPWyPC3okNcUMxP9bfPHSsZ3LN9tCrOyEMi d0cCdqvUcQVIS8Dm2Drg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otDKf-008oKP-IW; Thu, 10 Nov 2022 19:35:26 +0000 Received: from mail-oa1-f53.google.com ([209.85.160.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otDGZ-008lEM-A7 for linux-arm-kernel@lists.infradead.org; Thu, 10 Nov 2022 19:31:13 +0000 Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-13b6c1c89bdso3205833fac.13 for ; Thu, 10 Nov 2022 11:31:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pbf6I3VckrQCC7hSKLsVUD0gImYqojfbkHrsMs7jXfE=; b=rDOBcXj53CFvMr/2PNjDyudzv06cPkbYwjMqfR3ES1q4Fwvgg4OmpkFGedN3c+Gd7j gxXhSDLCP2yvtKHJ3ECQcpccZifG5TFMBgDkI2PIuKTEZfe3r/PufwShkSpWvcfxkBBn RkG3KGVKymHywWis8JxaxdzeqelwO8sHhRpqUaq1ZVAGwF8KkmugyqT0sfjq9LYjq4uM +36+Znf+lEaCH51weFumY2/yvfV4c5mDxsEbFCg1ISeFD3UJIru7YNGOAo678OJi6q2j qCcRKr8/HyI8F2plJRzEawVU4Z6nCLwXILa27C3l8BLc+TJ0wbzYT65X/qix9l0edCdU o6SA== X-Gm-Message-State: ACrzQf3D+wAFJe0lk0VTfnTEena0I6bP5l6h9h7udARFJPFlXPIB8WEo VNgO4q8Sy8gjvSZoRW6sZg== X-Google-Smtp-Source: AMsMyM4uWnD7gNNBGmff+/RJ1tj0X2d0N4xYeV7Qc3LrN/VhEhrJejG3uGPhsaEiB40x/jun3dEA8w== X-Received: by 2002:a05:6870:b017:b0:13d:5532:d00a with SMTP id y23-20020a056870b01700b0013d5532d00amr1912864oae.71.1668108667437; Thu, 10 Nov 2022 11:31:07 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id a11-20020a056870468b00b0010d7242b623sm248602oap.21.2022.11.10.11.31.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 11:31:06 -0800 (PST) Received: (nullmailer pid 856960 invoked by uid 1000); Thu, 10 Nov 2022 19:31:08 -0000 Date: Thu, 10 Nov 2022 13:31:08 -0600 From: Rob Herring To: Miquel Raynal Cc: Krzysztof Kozlowski , devicetree@vger.kernel.org, Srinivas Kandagatla , linux-kernel@vger.kernel.org, Robert Marko , Luka Perkov , Thomas Petazzoni , Michael Walle , linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski , Christian Eggers , Cory Tusar Subject: Re: [PATCH v3 4/6] dt-bindings: nvmem: add YAML schema for the sl28 vpd layout Message-ID: <20221110193108.GA854032-robh@kernel.org> References: <20221104163833.1289857-1-miquel.raynal@bootlin.com> <20221104163833.1289857-5-miquel.raynal@bootlin.com> <20221110134918.GB3436769-robh@kernel.org> <20221110183855.05ced2a0@xps-13> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221110183855.05ced2a0@xps-13> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221110_113111_407385_64D563D3 X-CRM114-Status: GOOD ( 31.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 10, 2022 at 06:38:55PM +0100, Miquel Raynal wrote: > Hi Rob, > > robh@kernel.org wrote on Thu, 10 Nov 2022 07:49:18 -0600: > > > On Fri, Nov 04, 2022 at 05:38:31PM +0100, Miquel Raynal wrote: > > > From: Michael Walle > > > > > > Add a schema for the NVMEM layout on Kontron's sl28 boards. > > > > > > Signed-off-by: Michael Walle > > > Signed-off-by: Miquel Raynal > > > --- > > > .../nvmem/layouts/kontron,sl28-vpd.yaml | 60 +++++++++++++++++++ > > > .../bindings/nvmem/layouts/nvmem-layout.yaml | 3 + > > > 2 files changed, 63 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml > > > new file mode 100644 > > > index 000000000000..44088c8b4153 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/nvmem/layouts/kontron,sl28-vpd.yaml > > > @@ -0,0 +1,60 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/nvmem/layouts/kontron,sl28-vpd.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: NVMEM layout of the Kontron SMARC-sAL28 vital product data > > > + > > > +maintainers: > > > + - Michael Walle > > > + > > > +description: > > > + The vital product data (VPD) of the sl28 boards contains a serial > > > + number and a base MAC address. The actual MAC addresses for the > > > + on-board ethernet devices are derived from this base MAC address by > > > + adding an offset. > > > + > > > +properties: > > > + compatible: > > > + const: kontron,sl28-vpd > > > + > > > + serial-number: > > > + type: object > > > + description: The board's serial number > > > + > > > + base-mac-address: > > > + type: object > > > + description: > > > + Base MAC address for all on-module network interfaces. The first > > > + argument of the phandle will be treated as an offset. > > > + > > > + properties: > > > + "#nvmem-cell-cells": > > > + const: 1 > > > + > > > + additionalProperties: false > > > + > > > +required: > > > + - compatible > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + otp-1 { > > > + compatible = "user-otp"; > > > + > > > + nvmem-layout { > > > + compatible = "kontron,sl28-vpd"; > > > + > > > + serial_number: serial-number { > > > + }; > > > + > > > + base_mac_address: base-mac-address { > > > + #nvmem-cell-cells = <1>; > > > + }; > > > + }; > > > + }; > > > + > > > +... > > > diff --git a/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml b/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml > > > index ecc7c37cbc1f..f64ea2fa362d 100644 > > > --- a/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml > > > +++ b/Documentation/devicetree/bindings/nvmem/layouts/nvmem-layout.yaml > > > @@ -17,6 +17,9 @@ description: | > > > define and might require dynamic reading of the NVMEM device in order to > > > perform their parsing. The nvmem-layout container is here to describe these. > > > > > > +oneOf: > > > + - $ref: kontron,sl28-vpd.yaml > > > > This is the other way around from how we normally structure things. > > Normally, the specific schema would reference the common/base schema. > > This works, though you will be applying the schema twice. Once here and > > then by matching on compatible string. Not a big deal as that happens > > fairly often, but a 'select: false' in kontron,sl28-vpd.yaml would > > prevent that. This way does more to enforce the overall structure of > > nodes. > > Oh right, I knew about the "select: false" thing, but I forgot it in > the two layouts. > > > The one downside I see with it this way is nvmem-layout can't ever have > > common properties defined without listing them in each layout schema. > > Oh that's right, actually I solved it in the mtd dt-binding series with: > > partitions.yaml: > > oneOf: > - $ref: .yaml > > generic-property: > $ref: something > min/max...: foo > > .yaml: > generic-property: true > > But in this case, are the constraints provided by partitions.yaml on > "generic-property" actually still enforced? Yes, they are. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel