From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23422C4332F for ; Fri, 11 Nov 2022 18:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iuUOf45ORnYAiqLe8gVRyNtZjosipy+F0A+bmwPGpPA=; b=s4rly2ZAPV8zPu Knn/zA7X0FdS4F153AdU2x3/7QUepBYUTYxRqVZQ+SwQzxevJC2XgAQ1xpqwGmjQgtqvCM5ODmDkE xpf104WUaCbzNkjk4TMD30ULiVj7FRG/CBkITzZhvexX84P50ZAe+S/S+/E7LFt7Vpm7V1FWXTvxy bsjpov7WpVSgRAsSyUV0HXXuaDIy0PNlSztterSiVhHnPTv4pNQBdpyM1Snpk0y8NR2g1SM/DbUM3 YtBtpGjl4xNeQFubIJKRrUBYDUQ4LMy6oDtm2pWTjabIaEp9LIt/VpPxynUwrSCYwygA/OU4NVHHe +bKkGJwd5FYpjJitUSUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otYpr-0007g5-Pt; Fri, 11 Nov 2022 18:33:04 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otYpn-0007d3-W8 for linux-arm-kernel@lists.infradead.org; Fri, 11 Nov 2022 18:33:01 +0000 Received: by mail-pg1-x52d.google.com with SMTP id f63so5024400pgc.2 for ; Fri, 11 Nov 2022 10:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xt34YV/MZZV7jS+W7OwiyVMKxHZ9NnWwfH2nxadlAxU=; b=W7/H5ujz3DpGriSq86yiYiFYWYn/JcloeHWl05yqWHS+xIMd87ea4LAtjMK0+9ZxXi 2OW5d+S1bLlyWclTcsFjipuxKIrB9vnuqOXu/Tl0SSIzm3nxcrOUgYcfoH/DznABkSf9 Y6kXj8prg7D2DrEXqrsIrb1vYxXuqEA1PqCb4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xt34YV/MZZV7jS+W7OwiyVMKxHZ9NnWwfH2nxadlAxU=; b=pVoEzP5fNBNobxdZ8AGGZlIH+4sqK7ZJi2use4/donwaJNdbgh0QOiUic3QO41hbjx BPQv/gt2Spcz2B3foY3jNJYA7PLQBM6Fn4bqCck8Fy0ggekyOEsd15/13SbncSbxUVUS AaGuyzyWK5gJrYPnoszml+hKn3EaNSrxlnRiynRWbeOzjhlImv9B6DC7gnfXmiB6EaJ8 fCxCCXXCohCBYwWQY0/K6ic83SwkOsU/5FvUPK0WDR4+BV50a6F4FZUtf/R20uU+Dvz8 SOyeoi+/TXGnCxNK5xFMkqTgOKvmZoB3k/ArHcsxJGQh1F9SXZndD0CUeAgmLQwye4ib d5UQ== X-Gm-Message-State: ANoB5pknX3NtxV4BDeR3nAtDCU+gnVq4F6+ML9EiOtmBa3rxw5LQVnhh S7Fg3tUtIDmY+OCj3+kaZ7AZYg== X-Google-Smtp-Source: AA0mqf7g6ESXQ+rrvwAbk1yvs3nSG+WSbuhodtw7X5MrTk3bKHz+9SuBMOj1iwwoG1OxjpMvd2yyHg== X-Received: by 2002:a63:fe51:0:b0:459:a339:89e0 with SMTP id x17-20020a63fe51000000b00459a33989e0mr2758570pgj.300.1668191576394; Fri, 11 Nov 2022 10:32:56 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v10-20020a17090a0c8a00b00205f013f275sm5157870pja.22.2022.11.11.10.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 10:32:56 -0800 (PST) Date: Fri, 11 Nov 2022 10:32:55 -0800 From: Kees Cook To: Sami Tolvanen Cc: Peter Zijlstra , Mark Rutland , Catalin Marinas , Will Deacon , Steven Rostedt , Masami Hiramatsu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: ftrace: Define ftrace_stub_graph only with FUNCTION_GRAPH_TRACER Message-ID: <202211111032.BBEEDFA0@keescook> References: <20221109192831.3057131-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221109192831.3057131-1-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221111_103300_087156_CD0FB17F X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 09, 2022 at 07:28:31PM +0000, Sami Tolvanen wrote: > The 0-day bot reports that arm64 builds with CONFIG_CFI_CLANG + > CONFIG_FTRACE are broken when CONFIG_FUNCTION_GRAPH_TRACER is not > enabled: > > ld.lld: error: undefined symbol: __kcfi_typeid_ftrace_stub_graph > >>> referenced by entry-ftrace.S:299 (arch/arm64/kernel/entry-ftrace.S:299) > >>> arch/arm64/kernel/entry-ftrace.o:(.text+0x48) in archive vmlinux.a > > This is caused by ftrace_stub_graph using SYM_TYPE_FUNC_START when > the address of the function is not taken in any C translation unit. > > Fix the build by only defining ftrace_stub_graph when it's actually > needed, i.e. with CONFIG_FUNCTION_GRAPH_TRACER. > > Link: https://lore.kernel.org/lkml/202210251659.tRMs78RH-lkp@intel.com/ > Fixes: 883bbbffa5a4 ("ftrace,kcfi: Separate ftrace_stub() and ftrace_stub_graph()") > Reported-by: kernel test robot > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel