From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A315C433FE for ; Sat, 12 Nov 2022 04:07:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r6wjc6ptm53xWH7bSI54FkC7OJicAxWrX1lAC0voJKw=; b=WmMANmh+tgxES2 v40d0G2xQiEkd84t5f5qR+YjE3BUS7mjTCsptdpq9xFZics4FZfuVVZfZ43c/tSwuSqmYefEUTcpq Cjwi6mIZ6TSOP4I+JzfYLHxWIsuKB4qLghr9X622AQxY+rF31bvcn3YuVEC15lr8oEM5ueu3iQ60T PIMnv3XWzbeinIO06YEHZfWP+1w5MD3Dh9ZtGdM+GjBZdoWWVpebnz42Gk+75Cyzvc2O/bXxbmze4 cNJc4GP+F7baM5Cu1fpsdRddjC5JTgqa1Nt5yv/j9bANe0vG17wFRktmR0d02Qvi+8QdIpUYf5xAF BCWhN1cUyun8LByQLQ4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1othlv-00329i-O3; Sat, 12 Nov 2022 04:05:35 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1othls-00328M-Ep for linux-arm-kernel@lists.infradead.org; Sat, 12 Nov 2022 04:05:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 574FA62162; Sat, 12 Nov 2022 04:05:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B837C433C1; Sat, 12 Nov 2022 04:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668225929; bh=nfkO2oakwXbsXV+Bx9tVN0tDdiORcPa8UJoKUe4po1o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XHngi1vXRn1yXKYcAWqqEHGNPWpF9/2uxfjNIoSQQ0AWIHZFAVEauX9LLAf13ppwe Hu1pxqHtFPgQc/FBeSf1Lve30eKZNI+AnWXZNvVh6sgsq+L4kZ7IwK7R8DC3xi/uDn GrzLQ31zwVMKp9Cgafv6C0aIuwejtkROhV8VYDoEOheacgglXCm3ydNGeqwJmgqJxq rs2NqegdMUvC569Ubtdth0Wte12yOuZwybbghLuDZM/8RuB6kapQTY8dEbfVIJD18A xoj6oaDPL7z7gnoiyXhbUiKEJ91Ki0vwmTXxIwF9beH3Ms/DZIsaaHmqB0KsIbNYz9 bKM8jLEMK8gKg== Date: Fri, 11 Nov 2022 20:05:28 -0800 From: Jakub Kicinski To: Noor Azura Ahmad Tarmizi Cc: "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Ong Boon Leong , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Song Yoong Siang , Mohd Faizal Abdul Rahim Subject: Re: [PATCH net 1/1] net: stmmac: ensure tx function is not running in stmmac_xdp_release() Message-ID: <20221111200528.1ca0aa29@kernel.org> In-Reply-To: <20221110064552.22504-1-noor.azura.ahmad.tarmizi@linux.intel.com> References: <20221110064552.22504-1-noor.azura.ahmad.tarmizi@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221111_200532_631941_C96C2133 X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Nov 2022 14:45:52 +0800 Noor Azura Ahmad Tarmizi wrote: > When stmmac_xdp_release() is called, there is a possibility that tx > function is still running on other queues which will lead to tx queue > timed out and reset adapter. > > This commit ensure that tx function is not running xdp before release > flow continue to run. Do we still need that netif_trans_update() later in the function? That looks odd. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel