From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DF54C4332F for ; Mon, 14 Nov 2022 14:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yVihPe+UAJ7PgWduuHhMJ+Hw+sUHBjACYyg553UIIWM=; b=GCZDQSvkMxdz4o e5g83hTlWy1O1S6J5KR8QOKS+WCTELolTzwnydjJLu+bnzpoYukALiT0e2C076BQU6Buy4BYVfn7Q X85lgPM4cCamIZHYpo3E56c1tCSPX/F1PiPX5dNqlRuVG57XJgF+NFyFr8GGg+3lFZTexEphwDxmU qIjPfK3IjS5acIS52fLFb9+QXsdyEOyN8YSoWhUbjeRIi3z+DicLwWUCEQ2+HowQq3nV6sjs7oCE2 R0LNsByagNUHlzMQtgVXdFKoGkpXyl2/1gxr7Z//HCGA7TpBmUx4LDVcxce8O/RuwUrj1VWd9x+rs zJB2JCcMiKd4U87K2Utw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oua9D-001ZDm-C5; Mon, 14 Nov 2022 14:09:15 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oua99-001ZC7-0S for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2022 14:09:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 40887611CD; Mon, 14 Nov 2022 14:09:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 323C7C4314E; Mon, 14 Nov 2022 14:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668434950; bh=OkrAT6K7xXq9Vzf1rCG22jNAzcXb4Qf+jlQwNH73UMs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iq5PrCv3X7ahO2e6vQs3RtEsBWbomTwydrPK/sVMFTrVjMBYLQfICWPjKmyYsBbS7 5mcCb1Ngb0BXr/qnKXupqwOERiELJNRBSm0XQJHmMKQsmClYP4PaoPNn/iy/Z2W0Sa QQah3p2+AxBKWDM3qWcRlm5MlFBMN2CWMi6bVw6FskSb4Tyuah8UkRtc2/i+r2Q1YA 3bnf04mbb6iXym/bpIFRAZP0tmRI8Jf8z4Q+x1ZI0/eMzYYs39zgFED/VkzWlQNqGp 1G3WFWUzP3sS5r7UbGDBm38z+HacyaIk5KRLef7rHXCBSXGBDeJcAsJLoIfhgk2AUm mErzc7IUs6nZQ== Date: Mon, 14 Nov 2022 14:09:04 +0000 From: Will Deacon To: Manivannan Sadhasivam Cc: Catalin Marinas , Amit Pundir , Robin Murphy , Bjorn Andersson , Sibi Sankar , Linus Torvalds , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov Subject: Re: [GIT PULL] arm64 updates for 6.1-rc1 Message-ID: <20221114140903.GF30263@willie-the-truck> References: <20221005144116.2256580-1-catalin.marinas@arm.com> <20221111173952.GB5393@thinkpad> <20221111191820.GC5393@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221111191820.GC5393@thinkpad> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_060911_152915_065C50AC X-CRM114-Status: GOOD ( 47.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Nov 12, 2022 at 12:48:20AM +0530, Manivannan Sadhasivam wrote: > On Fri, Nov 11, 2022 at 11:10:01PM +0530, Manivannan Sadhasivam wrote: > > On Fri, Nov 11, 2022 at 11:15:11AM +0000, Catalin Marinas wrote: > > > On Tue, Nov 08, 2022 at 10:58:16PM +0530, Amit Pundir wrote: > > > > On Tue, 25 Oct 2022 at 18:08, Amit Pundir wrote: > > > > > On Wed, 12 Oct 2022 at 17:24, Catalin Marinas wrote: > > > > > > On Sat, Oct 08, 2022 at 08:28:26PM +0530, Amit Pundir wrote: > > > > > > > On Wed, 5 Oct 2022 at 20:11, Catalin Marinas wrote: > > > > > > > > Will Deacon (2): > > > > > > > > arm64: dma: Drop cache invalidation from arch_dma_prep_coherent() > > > > > > > > > > > > > > This patch broke AOSP on Dragonboard 845c (SDM845). I don't see any > > > > > > > relevant crash in the attached log and device silently reboots into > > > > > > > USB crash dump mode. The crash is fairly reproducible on db845c. I > > > > > > > could trigger it twice in 5 reboots and it always crash at the same > > > > > > > point during the boot process. Reverting this patch fixes the crash. > > > > > > > > > > > > > > I'm happy to test run any debug patche(s), that would help narrow > > > > > > > down this breakage. > > > [...] > > > > > Further narrowed down the breakage to the userspace daemon rmtfs > > > > > https://github.com/andersson/rmtfs. Is there anything specific in the > > > > > userspace code that I should be paying attention to? > > > > > > Since you don't see anything in the logs like a crash and the system > > > restarts, I suspect it's some deadlock and that's triggering the > > > watchdog. We have an erratum (826319) but that's for Cortex-A53. IIUC > > > SDM845 has Kryo 3xx series which based on some random google searches is > > > derived from A75/A55. Unfortunately the MIDR_EL1 register doesn't match > > > the Arm Ltd numbering, so I have no idea what CPUs these are by looking > > > at the boot log. > > > > > > I wouldn't be surprised if you hit a similar bug, though I couldn't find > > > anything close in the A55 errata notice. > > > > > > While we could revert commit c44094eee32f ("arm64: dma: Drop cache > > > invalidation from arch_dma_prep_coherent()"), if you hit a real hardware > > > issue it may trigger in other scenario where we only do cache cleaning > > > (without invalidate), like arch_sync_dma_for_device(). So I'd rather get > > > to the bottom of this and potentially enable the workaround for this > > > chipset. > > > > > > You could give it a quick try to by adding the MIDR ranges for SDM845 to > > > struct midr_range workaround_clean_cache[]. > > > > > > > I gave it a shot and indeed it fixes the crash on DB845. > > > > > After that I suggest you raise it with Qualcomm to investigate. Normally > > > we ask for an erratum number to enable a workaround and it's only > > > Qualcomm that can provide one here. > > > > > > > I will check with Qualcomm folks and update. > > > > I digged a little further and found that the crash was due to the secure > processor (XPU) violation. It happens because, CPU tried acccessing the memory > after sharing it with the modem for firmware metadata validation. Can you share more details about this violation, please? For example, is it s read or a write, what size is it, how is it detected? > Sibi tried fixing this problem earlier by using a hack in the remoteproc driver > [1], but I guess that got negated due to c44094eee32f? Performing a clean rather than a clean+invalidate when the buffer is allocated (which is what is achieved by c44094eee32f) shouldn't affect this afaict. > This is a common issue for other Qcom remoteproc drivers as well where CPU > shares a chunk of memory with the modem. There is one more hack in place where > the a chunk of memory is reserved and the driver will do memremap/copy the > data/memunmap using it and share it with modem. > > But is there a better solution overall that you could advise? I think we need a better understanding of what Qualcomm's SCM firmware is expecting about the state of the buffer pages being shared with the modem before we can suggest other solutions. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel