From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26D46C4332F for ; Mon, 14 Nov 2022 15:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MkOfmSknBvNz38f2phKpaOwMUdH6Dr68jREK5Syedho=; b=csQhtcIBrnOqVr 9GeMXaoFyu35NsfQdoH8QsiWZa24AQ7XG7AvFB+apE2Q/U9K6HHMMBDWoxiuYF8HGMSXYJXjhGHud 8PznoMbP3Knfaq5z3sm7xgh+9n/vQcTkZc0FxdD3zmbLMXuNHe/AVfj9OUO7utQS/QJGEZFujP4ZY VXnBXyg2M37rnZSElmhGvSC6N7+vc7lM9qkGn3ecfD0qnG3Kcz4P8qi9o0EEBWvq8RtDIT4d9lznN S+xrSL/gXQy3ob12TxLxYhhoxicm+7rOPyOaTq/RiAW/Jturla7v0syjhrhFYmiDx1gtOwrjYmees 1qorUHHAIvNKLvm7zQ9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouayz-0024Lb-S7; Mon, 14 Nov 2022 15:02:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouayx-0024K4-6v for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2022 15:02:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5812A60F0E; Mon, 14 Nov 2022 15:02:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBE95C433C1; Mon, 14 Nov 2022 15:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668438161; bh=mIJLH0EVFBeFe8YzOotBpI0JMX8zV93RkJObUlPqPs8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UubGHyzCI+2ZfaiPUOOpi8hfPxI7IX69KTC8egOLblIkodeC12tWWd0vmMAgQ8Sv5 Tkvwr9d26f6De2qPB/tjVYwXlQ1G5qFCz90F4jirhWVLS5AcfJKgJAO0pdHBpIsoT1 UbdJJNedqFuywbOaq9/JqDTyoXG0l5cRkuyYg5fQ29yD2uMDK9wYCxF2wocA4lKrun 5YohBXkFRP2U8LDr5H9qma3cMGEFOudU3TVrrpG5xsy7qSj/g3CnZFhlshQ7f5r2SN qsQiaaiEj0BSMGC5QcTEpzz93gN8yWx0UqUOBO6Z41acnQ7LBSacsuiFlj6quv5y5j x4qDwRPjk2Sgw== Date: Mon, 14 Nov 2022 15:02:37 +0000 From: Will Deacon To: Mark Brown Cc: James Morse , linux-arm-kernel@lists.infradead.org, Catalin Marinas Subject: Re: [PATCH 29/38] arm64/sysreg: Convert ID_PFR0_EL1 to automatic generation Message-ID: <20221114150236.GA31141@willie-the-truck> References: <20221028165426.1707896-1-james.morse@arm.com> <20221028165426.1707896-30-james.morse@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_070243_314581_60B6E09B X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 28, 2022 at 06:17:48PM +0100, Mark Brown wrote: > On Fri, Oct 28, 2022 at 05:54:17PM +0100, James Morse wrote: > > > Convert ID_PFR0_EL1 to be automatically generated as per DDI0487I.a, > > no functional changes. > > > +Enum 19:16 CSV2 > > + 0b0000 IMP > > + 0b0001 IMP > > + 0b0010 CSV2p1 > > +EndEnum > > Should 0b0000 not be something like UNDISCLOSED (DDI0487I.a says "The > implementation does not disclose whether FEAT_CSV2 is implemented.")? > > (I'm vaugely surprised the compiler didn't moan about the redefinition > of the constant.) I'm not fussed about the name, but the duplicate field definitely needs fixing otherwise defconfig is really noisy: ./arch/arm64/include/generated/asm/sysreg-defs.h:42:9: warning: 'ID_PFR0_EL1_CSV2_IMP' macro redefined [-Wmacro-redefined] #define ID_PFR0_EL1_CSV2_IMP UL(0b0001) ^ ./arch/arm64/include/generated/asm/sysreg-defs.h:41:9: note: previous definition is here #define ID_PFR0_EL1_CSV2_IMP UL(0b0000) ^ James -- please can you spin a v2 with this fixed? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel