* Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller
2022-10-23 21:56 [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller Michael Grzeschik
@ 2022-11-14 15:57 ` Michael Grzeschik
2022-11-30 16:57 ` Michal Simek
2022-11-30 17:02 ` Meaning of commented out dma-coherent in ZynqMP DWC3 DT node (Was: Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller) Ahmad Fatoum
2 siblings, 0 replies; 7+ messages in thread
From: Michael Grzeschik @ 2022-11-14 15:57 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: kernel, robh+dt, michal.simek, krzysztof.kozlowski+dt
[-- Attachment #1.1: Type: text/plain, Size: 1424 bytes --]
On Sun, Oct 23, 2022 at 11:56:49PM +0200, Michael Grzeschik wrote:
>Since we need to support legacy phys with the dwc3 controller,
>we enable this quirk on the zynqmp platforms.
Gentle Ping!
>Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>---
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>index a549265e55f6e7..7c1af75f33a05b 100644
>--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>@@ -825,6 +825,7 @@ dwc3_0: usb@fe200000 {
> clock-names = "bus_early", "ref";
> iommus = <&smmu 0x860>;
> snps,quirk-frame-length-adjustment = <0x20>;
>+ snps,resume-hs-terminations;
> /* dma-coherent; */
> };
> };
>@@ -851,6 +852,7 @@ dwc3_1: usb@fe300000 {
> clock-names = "bus_early", "ref";
> iommus = <&smmu 0x861>;
> snps,quirk-frame-length-adjustment = <0x20>;
>+ snps,resume-hs-terminations;
> /* dma-coherent; */
> };
> };
>--
>2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller
2022-10-23 21:56 [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller Michael Grzeschik
2022-11-14 15:57 ` Michael Grzeschik
@ 2022-11-30 16:57 ` Michal Simek
2022-11-30 17:02 ` Meaning of commented out dma-coherent in ZynqMP DWC3 DT node (Was: Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller) Ahmad Fatoum
2 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2022-11-30 16:57 UTC (permalink / raw)
To: Michael Grzeschik, linux-arm-kernel
Cc: michal.simek, robh+dt, krzysztof.kozlowski+dt, kernel
On 10/23/22 23:56, Michael Grzeschik wrote:
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
>
>
> Since we need to support legacy phys with the dwc3 controller,
> we enable this quirk on the zynqmp platforms.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index a549265e55f6e7..7c1af75f33a05b 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -825,6 +825,7 @@ dwc3_0: usb@fe200000 {
> clock-names = "bus_early", "ref";
> iommus = <&smmu 0x860>;
> snps,quirk-frame-length-adjustment = <0x20>;
> + snps,resume-hs-terminations;
> /* dma-coherent; */
> };
> };
> @@ -851,6 +852,7 @@ dwc3_1: usb@fe300000 {
> clock-names = "bus_early", "ref";
> iommus = <&smmu 0x861>;
> snps,quirk-frame-length-adjustment = <0x20>;
> + snps,resume-hs-terminations;
> /* dma-coherent; */
> };
> };
> --
> 2.30.2
>
Applied.
M
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Meaning of commented out dma-coherent in ZynqMP DWC3 DT node (Was: Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller)
2022-10-23 21:56 [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller Michael Grzeschik
2022-11-14 15:57 ` Michael Grzeschik
2022-11-30 16:57 ` Michal Simek
@ 2022-11-30 17:02 ` Ahmad Fatoum
2022-11-30 17:08 ` Michal Simek
2 siblings, 1 reply; 7+ messages in thread
From: Ahmad Fatoum @ 2022-11-30 17:02 UTC (permalink / raw)
To: Michael Grzeschik, linux-arm-kernel
Cc: kernel, robh+dt, michal.simek, krzysztof.kozlowski+dt
Hello!
On 23.10.22 23:56, Michael Grzeschik wrote:
> Since we need to support legacy phys with the dwc3 controller,
> we enable this quirk on the zynqmp platforms.
Slightly off-topic question below.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index a549265e55f6e7..7c1af75f33a05b 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -825,6 +825,7 @@ dwc3_0: usb@fe200000 {
> clock-names = "bus_early", "ref";
> iommus = <&smmu 0x860>;
> snps,quirk-frame-length-adjustment = <0x20>;
> + snps,resume-hs-terminations;
> /* dma-coherent; */
Is it possible to configure coherent DMA for the device and this is currently
not done or how should this comment be interpreted?
Thanks!
Ahmad
> };
> };
> @@ -851,6 +852,7 @@ dwc3_1: usb@fe300000 {
> clock-names = "bus_early", "ref";
> iommus = <&smmu 0x861>;
> snps,quirk-frame-length-adjustment = <0x20>;
> + snps,resume-hs-terminations;
> /* dma-coherent; */
> };
> };
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Meaning of commented out dma-coherent in ZynqMP DWC3 DT node (Was: Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller)
2022-11-30 17:02 ` Meaning of commented out dma-coherent in ZynqMP DWC3 DT node (Was: Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller) Ahmad Fatoum
@ 2022-11-30 17:08 ` Michal Simek
2022-11-30 17:12 ` Ahmad Fatoum
0 siblings, 1 reply; 7+ messages in thread
From: Michal Simek @ 2022-11-30 17:08 UTC (permalink / raw)
To: Ahmad Fatoum, Michael Grzeschik, linux-arm-kernel
Cc: kernel, robh+dt, michal.simek, krzysztof.kozlowski+dt
Hi,
On 11/30/22 18:02, Ahmad Fatoum wrote:
> Hello!
>
> On 23.10.22 23:56, Michael Grzeschik wrote:
>> Since we need to support legacy phys with the dwc3 controller,
>> we enable this quirk on the zynqmp platforms.
>
> Slightly off-topic question below.
>
>>
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>> ---
>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> index a549265e55f6e7..7c1af75f33a05b 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> @@ -825,6 +825,7 @@ dwc3_0: usb@fe200000 {
>> clock-names = "bus_early", "ref";
>> iommus = <&smmu 0x860>;
>> snps,quirk-frame-length-adjustment = <0x20>;
>> + snps,resume-hs-terminations;
>> /* dma-coherent; */
>
> Is it possible to configure coherent DMA for the device and this is currently
> not done or how should this comment be interpreted?
I didn't try it for a while but before you start a53 you can enable CCI and then
dma-coherent flags should be enabled.
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Meaning of commented out dma-coherent in ZynqMP DWC3 DT node (Was: Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller)
2022-11-30 17:08 ` Michal Simek
@ 2022-11-30 17:12 ` Ahmad Fatoum
2022-11-30 17:17 ` Michal Simek
0 siblings, 1 reply; 7+ messages in thread
From: Ahmad Fatoum @ 2022-11-30 17:12 UTC (permalink / raw)
To: Michal Simek, Michael Grzeschik, linux-arm-kernel
Cc: kernel, robh+dt, michal.simek, krzysztof.kozlowski+dt
Hello,
On 30.11.22 18:08, Michal Simek wrote:
> Hi,
>
> On 11/30/22 18:02, Ahmad Fatoum wrote:
>> Hello!
>>
>> On 23.10.22 23:56, Michael Grzeschik wrote:
>>> Since we need to support legacy phys with the dwc3 controller,
>>> we enable this quirk on the zynqmp platforms.
>>
>> Slightly off-topic question below.
>>
>>>
>>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>>> ---
>>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> index a549265e55f6e7..7c1af75f33a05b 100644
>>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>> @@ -825,6 +825,7 @@ dwc3_0: usb@fe200000 {
>>> clock-names = "bus_early", "ref";
>>> iommus = <&smmu 0x860>;
>>> snps,quirk-frame-length-adjustment = <0x20>;
>>> + snps,resume-hs-terminations;
>>> /* dma-coherent; */
>>
>> Is it possible to configure coherent DMA for the device and this is currently
>> not done or how should this comment be interpreted?
>
>
> I didn't try it for a while but before you start a53 you can enable CCI and then dma-coherent flags should be enabled.
I see. Wouldn't this apply to all DMA-capable devices then? So this comment would be better
placed top-level in /soc?
Also, why did you decide against having cache coherency be the default?
I'd expect this to be a performance improvement (if it functions correctly).
The Layerscape LS1046A also has a CCI and normal setup is to configure it
and have /soc/dma-coherent.
Thanks,
Ahmad
>
> Thanks,
> Michal
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Meaning of commented out dma-coherent in ZynqMP DWC3 DT node (Was: Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller)
2022-11-30 17:12 ` Ahmad Fatoum
@ 2022-11-30 17:17 ` Michal Simek
0 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2022-11-30 17:17 UTC (permalink / raw)
To: Ahmad Fatoum, Michael Grzeschik, linux-arm-kernel
Cc: kernel, robh+dt, michal.simek, krzysztof.kozlowski+dt
Hi,
On 11/30/22 18:12, Ahmad Fatoum wrote:
> Hello,
>
> On 30.11.22 18:08, Michal Simek wrote:
>> Hi,
>>
>> On 11/30/22 18:02, Ahmad Fatoum wrote:
>>> Hello!
>>>
>>> On 23.10.22 23:56, Michael Grzeschik wrote:
>>>> Since we need to support legacy phys with the dwc3 controller,
>>>> we enable this quirk on the zynqmp platforms.
>>>
>>> Slightly off-topic question below.
>>>
>>>>
>>>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>>>> ---
>>>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>>> index a549265e55f6e7..7c1af75f33a05b 100644
>>>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>>>> @@ -825,6 +825,7 @@ dwc3_0: usb@fe200000 {
>>>> clock-names = "bus_early", "ref";
>>>> iommus = <&smmu 0x860>;
>>>> snps,quirk-frame-length-adjustment = <0x20>;
>>>> + snps,resume-hs-terminations;
>>>> /* dma-coherent; */
>>>
>>> Is it possible to configure coherent DMA for the device and this is currently
>>> not done or how should this comment be interpreted?
>>
>>
>> I didn't try it for a while but before you start a53 you can enable CCI and then dma-coherent flags should be enabled.
>
> I see. Wouldn't this apply to all DMA-capable devices then? So this comment would be better
> placed top-level in /soc?
yes of course.
>
> Also, why did you decide against having cache coherency be the default?
> I'd expect this to be a performance improvement (if it functions correctly).
I haven't seen such a request to enable it by default but from build perspective
you need to do one more additional step which none is really doing. Definitely
there is missing code in bootloader which is also sharing the same DT description.
I know that we were trying that configuration in past but not sure if this is in
regression or if there is any issue with any driver.
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread