From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FC75C433FE for ; Tue, 15 Nov 2022 03:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g0+Lvcg5vbBQ/e+ljLW034ONF/YkYRUIGi4wlJgeIto=; b=1XUQV5fARksiGE Ti7Xk4+yDFeQ/qVV+46QMnrsxdLu//Mc4sM5E6USCoDQELEqsBZ4A4PR+OyKAOJEbzezRjFGajO58 dKb7wuLcLpTKOZNu7H20bUFUG+gRLdHH/HzmVRIMbxtIaFWiuz5npq7WFnbiYxqT1LhiWVhOFhjG6 bAXCB4T528MaGsqIRpAOixSVu50eXSCdvYAZVCFQDlb4YMFJaNLDDlOBHbgn96Fb4aFxk1y0tgCth BHsH1fXonjzwk46lGSmzirwTsZTVKx4tcagsiBZtuvZ6GbEewDbAc2BU/cnPktHFls9DSEJx53XWE mxITGFtfAv/5gOkY9IAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oumrM-007FkF-Pg; Tue, 15 Nov 2022 03:43:40 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oumrJ-007Fhp-QO for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 03:43:39 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2AF3hOoj046493; Mon, 14 Nov 2022 21:43:24 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1668483805; bh=vW4Na6MUWNFRZenOB8ly6uHS+ELtuXqlkGUOA9uhB+Y=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=JzxPMmLHUH0YD90PYMH06sxwLrRqqsyVyYZAYwSr8EcuK6v5EAdJEVmHunpzKH2jc CRqKkbZJ/TQKCvvPCH2xZxurVEGw6Ihki6QZGsAikqgBPdhGpNiH7edCpSva3mxnnB NJZwhNnbKBaxmBrs28V6GXcGVP7uDx1DI9tNfW+4= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2AF3hOl8012785 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Nov 2022 21:43:24 -0600 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Mon, 14 Nov 2022 21:43:24 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Mon, 14 Nov 2022 21:43:24 -0600 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2AF3hODx121431; Mon, 14 Nov 2022 21:43:24 -0600 Date: Mon, 14 Nov 2022 21:43:24 -0600 From: Nishanth Menon To: Bhavya Kapoor CC: , , , , , , Subject: Re: [PATCH] arm64: dts: ti: k3-j721e-main: Remove ti,strobe-sel property Message-ID: <20221115034324.6qpxl2774bzwbl3t@acorn> References: <20221107112246.69242-1-b-kapoor@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221107112246.69242-1-b-kapoor@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_194338_064015_A08CAF93 X-CRM114-Status: GOOD ( 23.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:52-20221107, Bhavya Kapoor wrote: > According to latest errata of J721e [1], HS400 mode is not supported > in MMCSD0 subsystem (i2024) . Speed modes supported has been already > updated in PATCH eb8f6194e807. 'ti,strobe-sel' property is only eb8f6194e807 isn't a PATCH :) See Documentation/process/submitting-patches.rst line 99 as an example how to refer to specific commits. > required by HS400 speed mode and thus needs to be removed from kernel > dtsi for J721e soc. s/soc/SoC > > 'ti,strobe-sel' is read in sdhci_am654.c line 733 and gets stored in > sdhci_am654->strb_sel. This sdhci_am654->strb_sel is used at only one > place in sdhci_am654.c line 291 which will only get used if HS400 > is enabled. Please don't describe driver behavior in device tree patch. DT binding should indicate the property behavior. > > Thus, drop 'ti,strobe-sel' property from kernel dtsi for J721e soc. > > [.] https://www.ti.com/lit/er/sprz455/sprz455.pdf Should be [1] ? I think we could simplify it by saying that the commit that implemented the patch missed dropping ti,strobe-sel property that is only meant for HS400. (please rephrase appropriately). Documentation/devicetree/bindings/mmc/sdhci-am654.yaml Now, that said - this could be enforced in dt-schema to prevent such a miss from taking place (if then required) Might be a case to post a separate patch for the enforcement? > > Fixes: eb8f6194e807 ("arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems") > Signed-off-by: Bhavya Kapoor > --- > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > index 917c9dc99efa..e4748a838d83 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > @@ -1094,7 +1094,6 @@ > ti,itap-del-sel-mmc-hs = <0xa>; > ti,itap-del-sel-ddr52 = <0x3>; > ti,trm-icp = <0x8>; > - ti,strobe-sel = <0x77>; > dma-coherent; > }; > > -- > 2.20.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel