From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68373C4332F for ; Tue, 15 Nov 2022 18:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=96uhm6O7g+yzvm/y10mbT8+iCtkZk4lVeLNLr+g4noQ=; b=AtHD/BXFeIk3cw K6DLvzL39dWOu0HCs72O/3jYOOlTM1aZ6D4qoNUtVaymTYnp7kPCw2+YG5nAkUffOumB0DQ+OsFFb Q2R7r/u6celz680jbGrrR96huml9znjddmfYNHeiL4u7fEtbItSPEtBPZCEHGU5fFHYKKrMn6UlxG QZiM97xFJqojFJCrju4WQLhMGg0ZFjsS2ssuS4DBYIaeEVKCKvTbRitU7T3RUeOLa2UBeYi3wyp/h CcbA1iw8YFv7bMK2mIoBQc5qEoU8XlYFsY/lfsVLgv8OIeR3gSqLXI8kqmMq0Bcu+IHFnlpPdwDhh i8PVqCZChyjmnUyyEjMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov0LY-00DdwE-5s; Tue, 15 Nov 2022 18:07:44 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov0LV-00Ddvb-CB for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 18:07:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6FA71B818DC; Tue, 15 Nov 2022 18:07:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7EBEC433C1; Tue, 15 Nov 2022 18:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668535656; bh=gVYcutXI++9bdrHBHueMBmsjqWSHjeoLZDZVF1qz2gY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Kj7PrOhLg29hSgQ0mhZwTHKYN6ylN97waXxxyCaBF9rHt/ZmxWNR0yjFiG0VWZNBO 7s6k6oaT/B4M6iA8qN9H9hmXAdr2jaYHY8FxJemnY9fSFMhtRaYpNoMYO2d56BZOQb qLDX6au8eVes2feP8rqwd4HC9EoOomckazimxAtkgSH2IvBMWjOBxnJFevFqH27pMg XDaML34HV0P5635S0Jp0Ri0GG35qf+mzDZ9WZJXTVl+kxM/SwjVO4qrh9p2a99PM5E vpWJtrjI/jAg1SLOJGYOdwbKxE+JfY9Wxb4zXiv+kXRXGDkMYh6PTMGFfBNEylgsRt kRTtgyUorBxRA== Date: Tue, 15 Nov 2022 12:07:34 -0600 From: Bjorn Helgaas To: Geert Uytterhoeven Cc: Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH 2/2] PCI: Drop controller CONFIG_OF dependencies Message-ID: <20221115180734.GA999206@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_100741_600971_FAF4E51F X-CRM114-Status: GOOD ( 20.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 15, 2022 at 04:56:10PM +0100, Geert Uytterhoeven wrote: > On Tue, Oct 25, 2022 at 9:16 PM Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > Many drivers depend on OF interfaces, so they won't be functional if > > CONFIG_OF is not set. But OF provides stub functions in that case, so drop > > the OF dependencies so we can at least compile-test the drivers. > > --- a/drivers/pci/controller/Kconfig > > +++ b/drivers/pci/controller/Kconfig > > @@ -8,7 +8,6 @@ config PCI_MVEBU > > depends on ARCH_MVEBU || ARCH_DOVE || COMPILE_TEST > > depends on MVEBU_MBUS > > depends on ARM > > - depends on OF > > This is exactly why we have the COMPILE_TEST symbol. > There is no point in bothering all users who configure kernels with > questions about drivers that won't function anyway due to missing > dependencies, unless the user explicitly wants to do compile-testing. > > So all of these should become: > > depends on OF || COMPILE_TEST Oh, yes, thanks for pointing this out, I totally blew it here. I dropped this while we figure it out. Do you have a preference between this: depends on ARCH_MVEBU || ARCH_DOVE || COMPILE_TEST depends on OF || COMPILE_TEST and this: depends on ((ARCH_MVEBU || ARCH_DOVE) && OF) || COMPILE_TEST The latter seems more common and doesn't repeat "COMPILE_TEST", but I can see advantages to the former. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel