From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4B1DC4332F for ; Tue, 15 Nov 2022 20:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=2pKKv6JXTkhDWK81ILoe8B70NpGDyN2SmYWO4khYsqk=; b=YjvCYXSDGu9vGm DoA1KiIer0cHKi6O9styxiZhiNR2NO7Py8M+kzRvMBYaLGorUL3ZW3SRmFcu7fNgp6Aagcra1dv0g xZOZxyXMBSQwIOhKZZ1dAUyltR0L15sVbFRCyR7b6Uc75/FK2pGnWv7WAZuoTHFCQDfyHuqBNeFdd /SGVg2fWp9fjCWG0FQQkadzgciTi6fkhUe7gwxzWFKqVsENHF74ooJX+kCygpuWbdEYvzp7jxuaVP 63LVk3AktjOK75oYuokQYUBUD8ew48YRpqXzc3T4ES+VY/cz4Ld1fz5qx7M448pwKyCNO0/OVPjtC 6R/IExjD2rzewSg6dncQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov2wK-00Elmz-Pp; Tue, 15 Nov 2022 20:53:52 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov2wH-00Eljo-W6 for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 20:53:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4DA6CB81B58; Tue, 15 Nov 2022 20:53:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B461BC433C1; Tue, 15 Nov 2022 20:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668545624; bh=QtEMXmU7rn5ebyaLLdCAgveTJ9apGDanAfmeQR5mDqw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nIg4L4bxNYzRM4/zjuO1mZ8QdSy7qK9WvzdtoOQDHm8PK4a3YNEniblOzzgI5vgPP sWV2keulBuZ72DytYmxrlX+5odfNRbrJxWJKBwRXPqenf4OL9VFJdnWEGSN8IX658v tEHugTVr3zNdI+r+mTAsFHlUleYAp3UlXJ65zOvXzu7J5wNH19hQxuo3LNUOo+81fm koxnMc45Jk1ndKYbfCATfDszOtvxal9gN2VpE9bENX4zAZYnKcgB0M2DKTdSsMPX7J DIjf/3vZTDoLrc8rYxMfQHZ0MQVgBF6ztq5Qi+JLGMnOOp/0NIWILG9pfm9IGIBVMS OYWXHQHqO+lpw== Date: Tue, 15 Nov 2022 14:53:43 -0600 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Geert Uytterhoeven , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH 2/2] PCI: Drop controller CONFIG_OF dependencies Message-ID: <20221115205343.GA1038784@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221115193155.mqdh6pzhiba4v4pa@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_125350_189768_4E397A48 X-CRM114-Status: GOOD ( 27.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 15, 2022 at 08:31:55PM +0100, Pali Roh=E1r wrote: > On Tuesday 15 November 2022 12:07:34 Bjorn Helgaas wrote: > > On Tue, Nov 15, 2022 at 04:56:10PM +0100, Geert Uytterhoeven wrote: > > > On Tue, Oct 25, 2022 at 9:16 PM Bjorn Helgaas wr= ote: > > > > From: Bjorn Helgaas > > > > > > > > Many drivers depend on OF interfaces, so they won't be functional if > > > > CONFIG_OF is not set. But OF provides stub functions in that case,= so drop > > > > the OF dependencies so we can at least compile-test the drivers. > > = > > > > --- a/drivers/pci/controller/Kconfig > > > > +++ b/drivers/pci/controller/Kconfig > > > > @@ -8,7 +8,6 @@ config PCI_MVEBU > > > > depends on ARCH_MVEBU || ARCH_DOVE || COMPILE_TEST > > > > depends on MVEBU_MBUS > > > > depends on ARM > > > > - depends on OF > > > = > > > This is exactly why we have the COMPILE_TEST symbol. > > > There is no point in bothering all users who configure kernels with > > > questions about drivers that won't function anyway due to missing > > > dependencies, unless the user explicitly wants to do compile-testing. > > > = > > > So all of these should become: > > > = > > > depends on OF || COMPILE_TEST > > = > > Oh, yes, thanks for pointing this out, I totally blew it here. I > > dropped this while we figure it out. > = > I agree too, it really makes sense to not provide pci-mvebu driver to > end users without OF - it would not work. > = > Anyway, it is needed to declare "depends on ARM" for pci-mvebu? > Both supported architectures (mvebu and dove) are ARM. If you're asking whether "depends on ARM" can be removed for PCI_MVEBU, I don't know the answer. I do see that CONFIG_ARCH_MVEBU is mentioned in arch/arm64, which doesn't seem to set CONFIG_ARM. In any event, I would consider a change like that to be a separate patch. Here I just want to focus on CONFIG_OF. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel