public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: MD Danish Anwar <danishanwar@ti.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: Suman Anna <s-anna@ti.com>, Roger Quadros <rogerq@kernel.org>,
	"Andrew F . Davis" <afd@ti.com>, <nm@ti.com>, <vigneshr@ti.com>,
	<srk@ti.com>, <linux-remoteproc@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	MD Danish Anwar <danishanwar@ti.com>
Subject: [PATCH v8 4/6] remoteproc: pru: Make sysfs entries read-only for PRU client driven boots
Date: Wed, 16 Nov 2022 17:46:32 +0530	[thread overview]
Message-ID: <20221116121634.2901265-5-danishanwar@ti.com> (raw)
In-Reply-To: <20221116121634.2901265-1-danishanwar@ti.com>

From: Suman Anna <s-anna@ti.com>

The PRU remoteproc driver is not configured for 'auto-boot' by default,
and allows to be booted either by in-kernel PRU client drivers or by
userspace using the generic remoteproc sysfs interfaces. The sysfs
interfaces should not be permitted to change the remoteproc firmwares
or states when a PRU is being managed by an in-kernel client driver.
Use the newly introduced remoteproc generic 'sysfs_read_only' flag to
provide these restrictions by setting and clearing it appropriately
during the PRU acquire and release steps.

Co-developed-by: Suman Anna <s-anna@ti.com>
Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 drivers/remoteproc/pru_rproc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index 7d4ed39b3772..bca7550d79d2 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -228,6 +228,7 @@ struct rproc *pru_rproc_get(struct device_node *np, int index,
 	}
 
 	pru->client_np = np;
+	rproc->sysfs_read_only = true;
 
 	mutex_unlock(&pru->lock);
 
@@ -266,6 +267,7 @@ void pru_rproc_put(struct rproc *rproc)
 	}
 
 	pru->client_np = NULL;
+	rproc->sysfs_read_only = false;
 	mutex_unlock(&pru->lock);
 
 	rproc_put(rproc);
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-11-16 12:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 12:16 [PATCH v8 0/6] Introduce PRU remoteproc consumer API MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings MD Danish Anwar
2022-11-16 16:09   ` Rob Herring
2022-11-16 18:09     ` Mathieu Poirier
2022-11-18  5:48       ` [EXTERNAL] " Md Danish Anwar
2022-11-18 18:56         ` Mathieu Poirier
2022-11-16 12:16 ` [PATCH v8 2/6] remoteproc: pru: Add APIs to get and put the PRU cores MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 3/6] remoteproc: pru: Add enum for PRU Core Indentifiers MD Danish Anwar
2022-11-16 12:16 ` MD Danish Anwar [this message]
2022-11-16 12:16 ` [PATCH v8 5/6] remoteproc: pru: Add pru_rproc_set_ctable() function MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 6/6] remoteproc: pru: Configure firmware based on client setup MD Danish Anwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221116121634.2901265-5-danishanwar@ti.com \
    --to=danishanwar@ti.com \
    --cc=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=s-anna@ti.com \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox