Re: [PATCH v2 3/3] treewide: use get_random_u32_between() when possible

Kees Cook
2022-11-17T00:48:41Z

On November 16, 2022 4:43:54 PM PST, "Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
>On Wed, Nov 16, 2022 at 04:31:18PM -0800, Kees Cook wrote:
>> On Thu, Nov 17, 2022 at 01:03:14AM +0100, Jason A. Donenfeld wrote:
>> > On Thu, Nov 17, 2022 at 12:55:47AM +0100, Jason A. Donenfeld wrote:
>> > > 2) What to call it:
>> > > - between I still like, because it mirrors "I'm thinking of a number
>> > > between 1 and 10 and..." that everybody knows,
>> > > - inclusive I guess works, but it's not a preposition,
>> > > - bikeshed color #3?
>> >
>> > - between
>> > - ranged
>> > - spanning
>> >
>> > https://www.thefreedictionary.com/List-of-prepositions.htm
>> > - amid
>> >
>> > Sigh, names.
>>
>> I think "inclusive" is best.
>
>I find it not very descriptive of what the function does. Is there one
>you like second best? Or are you convinced they're all much much much
>worse than "inclusive" that they shouldn't be considered?

Right, I don't think any are sufficiently descriptive. "Incluisve" with two arguments seems unambiguous and complete to me. :)

--
Kees Cook