* [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq [not found] <20221113191301.5526-1-Sergey.Semin@baikalelectronics.ru> @ 2022-11-13 19:12 ` Serge Semin 2022-11-14 0:06 ` Rob Herring 2022-11-16 20:38 ` Rob Herring 2022-11-13 19:12 ` [PATCH v7 02/20] dt-bindings: visconti-pcie: Fix interrupts array max constraints Serge Semin 2022-11-13 19:12 ` [PATCH v7 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes Serge Semin 2 siblings, 2 replies; 8+ messages in thread From: Serge Semin @ 2022-11-13 19:12 UTC (permalink / raw) To: Rob Herring, Rob Herring, Krzysztof Kozlowski, Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Robin Murphy, Jingoo Han, Gustavo Pimentel, Richard Zhu, Lucas Stach, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team Cc: Serge Semin, Serge Semin, Alexey Malahov, Pavel Parkhomenko, Krzysztof Wilczyński, Frank Li, Manivannan Sadhasivam, caihuoqing, Vinod Koul, linux-pci, devicetree, linux-kernel, Alexander Stein, linux-arm-kernel Originally as it was defined the legacy bindings the pcie_inbound_axi and pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and fsl,imx8mq-pcie devices respectively. But the bindings conversion has been incorrectly so now the fourth clock name is defined as "pcie_inbound_axi for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. Let's fix that by conditionally apply the clock-names constraints based on the compatible string content. Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Changelog v5: - This is a new patch added on the v5 release of the patchset. Changelog v7: - Move the allOf clause to the bottom of the bindings. (@Krzysztof) - Get back the names to the clock-names property and make sure the platform-specific name constraint is applied in the allOf clause. (@Rob) --- .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index 376e739bcad4..49b4f7a32e71 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml @@ -14,9 +14,6 @@ description: |+ This PCIe host controller is based on the Synopsys DesignWare PCIe IP and thus inherits all the common properties defined in snps,dw-pcie.yaml. -allOf: - - $ref: /schemas/pci/snps,dw-pcie.yaml# - properties: compatible: enum: @@ -61,7 +58,7 @@ properties: - const: pcie - const: pcie_bus - const: pcie_phy - - const: pcie_inbound_axi for imx6sx-pcie, pcie_aux for imx8mq-pcie + - enum: [ pcie_inbound_axi, pcie_aux ] num-lanes: const: 1 @@ -175,6 +172,47 @@ required: - clocks - clock-names +allOf: + - $ref: /schemas/pci/snps,dw-pcie.yaml# + - if: + properties: + compatible: + contains: + const: fsl,imx6sx-pcie + then: + properties: + clock-names: + items: + - {} + - {} + - {} + - const: pcie_inbound_axi + - if: + properties: + compatible: + contains: + const: fsl,imx8mq-pcie + then: + properties: + clock-names: + items: + - {} + - {} + - {} + - const: pcie_aux + - if: + properties: + compatible: + not: + contains: + enum: + - fsl,imx6sx-pcie + - fsl,imx8mq-pcie + then: + properties: + clock-names: + maxItems: 3 + unevaluatedProperties: false examples: -- 2.38.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq 2022-11-13 19:12 ` [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Serge Semin @ 2022-11-14 0:06 ` Rob Herring 2022-11-14 11:51 ` Serge Semin 2022-11-16 20:38 ` Rob Herring 1 sibling, 1 reply; 8+ messages in thread From: Rob Herring @ 2022-11-14 0:06 UTC (permalink / raw) To: Serge Semin Cc: Gustavo Pimentel, Krzysztof Wilczyński, caihuoqing, linux-pci, NXP Linux Team, Serge Semin, Alexey Malahov, devicetree, Vinod Koul, Bjorn Helgaas, Sascha Hauer, Jingoo Han, Krzysztof Kozlowski, Rob Herring, Lorenzo Pieralisi, Pavel Parkhomenko, linux-kernel, linux-arm-kernel, Frank Li, Pengutronix Kernel Team, Lucas Stach, Manivannan Sadhasivam, Richard Zhu, Robin Murphy, Cai Huoqing, Fabio Estevam, Alexander Stein, Shawn Guo On Sun, 13 Nov 2022 22:12:42 +0300, Serge Semin wrote: > Originally as it was defined the legacy bindings the pcie_inbound_axi and > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > Let's fix that by conditionally apply the clock-names constraints based on > the compatible string content. > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > Changelog v5: > - This is a new patch added on the v5 release of the patchset. > > Changelog v7: > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > - Get back the names to the clock-names property and make sure the > platform-specific name constraint is applied in the allOf clause. > (@Rob) > --- > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > 1 file changed, 42 insertions(+), 4 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ pcie@1ffc000: Unevaluated properties are not allowed ('disable-gpio' was unexpected) arch/arm/boot/dts/imx6dl-emcon-avari.dtb arch/arm/boot/dts/imx6q-emcon-avari.dtb pcie@33800000: clock-names:1: 'pcie_bus' was expected arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33800000: clock-names:2: 'pcie_phy' was expected arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb pcie@33800000: clock-names:3: 'pcie_aux' was expected arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33800000: clock-names:3: 'pcie_bus' is not one of ['pcie_inbound_axi', 'pcie_aux'] arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33800000: power-domains: [[102, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: power-domains: [[102]] is too short arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb pcie@33800000: power-domains: [[103]] is too short arch/arm/boot/dts/imx7d-colibri-emmc-iris.dtb arch/arm/boot/dts/imx7d-colibri-iris.dtb pcie@33800000: power-domains: [[104]] is too short arch/arm/boot/dts/imx7d-colibri-aster.dtb arch/arm/boot/dts/imx7d-colibri-emmc-aster.dtb arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dtb arch/arm/boot/dts/imx7d-colibri-iris-v2.dtb pcie@33800000: power-domains: [[106]] is too short arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb pcie@33800000: power-domains: [[107]] is too short arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dtb arch/arm/boot/dts/imx7d-colibri-eval-v3.dtb pcie@33800000: power-domains: [[108]] is too short arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb pcie@33800000: power-domains: [[125]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb pcie@33800000: power-domains: [[126]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb pcie@33800000: power-domains: [[49, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb pcie@33800000: power-domains: [[55]] is too short arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb pcie@33800000: power-domains: [[59]] is too short arch/arm/boot/dts/imx7d-cl-som-imx7.dtb pcie@33800000: power-domains: [[60, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb pcie@33800000: power-domains: [[61]] is too short arch/arm/boot/dts/imx7d-sbc-imx7.dtb pcie@33800000: power-domains: [[63]] is too short arch/arm/boot/dts/imx7d-zii-rmu2.dtb pcie@33800000: power-domains: [[64, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-evk.dtb pcie@33800000: power-domains: [[64]] is too short arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm/boot/dts/imx7d-remarkable2.dtb pcie@33800000: power-domains: [[67]] is too short arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb pcie@33800000: power-domains: [[68]] is too short arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm/boot/dts/imx7d-meerkat96.dtb pcie@33800000: power-domains: [[70, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb pcie@33800000: power-domains: [[70]] is too short arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb pcie@33800000: power-domains: [[72]] is too short arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb pcie@33800000: power-domains: [[73]] is too short arch/arm/boot/dts/imx7d-flex-concentrator.dtb arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dtb arch/arm/boot/dts/imx7d-smegw01.dtb pcie@33800000: power-domains: [[75]] is too short arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb pcie@33800000: power-domains: [[76, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb pcie@33800000: power-domains: [[76]] is too short arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb pcie@33800000: power-domains: [[77]] is too short arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb pcie@33800000: power-domains: [[78]] is too short arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb pcie@33800000: power-domains: [[79]] is too short arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb pcie@33800000: power-domains: [[80]] is too short arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb pcie@33800000: power-domains: [[81]] is too short arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-evk.dtb pcie@33800000: power-domains: [[82]] is too short arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb pcie@33800000: power-domains: [[83, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb pcie@33800000: power-domains: [[84]] is too short arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb pcie@33800000: power-domains: [[86, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb pcie@33800000: power-domains: [[86]] is too short arch/arm/boot/dts/imx7d-nitrogen7.dtb arch/arm/boot/dts/imx7d-pico-nymph.dtb pcie@33800000: power-domains: [[87]] is too short arch/arm/boot/dts/imx7d-sdb-reva.dtb pcie@33800000: power-domains: [[88]] is too short arch/arm/boot/dts/imx7d-pico-dwarf.dtb arch/arm/boot/dts/imx7d-pico-hobbit.dtb arch/arm/boot/dts/imx7d-sdb.dtb arch/arm/boot/dts/imx7d-sdb-sht11.dtb pcie@33800000: power-domains: [[89]] is too short arch/arm/boot/dts/imx7d-pico-pi.dtb arch/arm/boot/dts/imx7d-zii-rpu2.dtb pcie@33800000: power-domains: [[92]] is too short arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb pcie@33800000: power-domains: [[96]] is too short arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm/boot/dts/imx7d-mba7.dtb pcie@33800000: power-domains: [[97, 3]] is too short arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb pcie@33800000: power-domains: [[97]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb pcie@33800000: power-domains: [[98]] is too short arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33800000: reset-names:0: 'pciephy' was expected arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: reset-names:1: 'apps' was expected arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: reset-names: ['apps', 'turnoff'] is too short arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: resets: [[101, 26], [101, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: resets: [[25, 28], [25, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb pcie@33800000: resets: [[26, 28], [26, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb pcie@33800000: resets: [[27, 28], [27, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb pcie@33800000: resets: [[28, 28], [28, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb pcie@33800000: resets: [[29, 28], [29, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb pcie@33800000: resets: [[31, 28], [31, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb pcie@33800000: resets: [[34, 28], [34, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb pcie@33800000: resets: [[40, 28], [40, 29]] is too short arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb pcie@33800000: resets: [[48, 26], [48, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb pcie@33800000: resets: [[59, 26], [59, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb pcie@33800000: resets: [[63, 26], [63, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-evk.dtb pcie@33800000: resets: [[69, 26], [69, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb pcie@33800000: resets: [[75, 26], [75, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb pcie@33800000: resets: [[82, 26], [82, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb pcie@33800000: resets: [[85, 26], [85, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb pcie@33800000: resets: [[96, 26], [96, 27]] is too short arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb pcie@33800000: Unevaluated properties are not allowed ('clock-names', 'epdev_on-supply', 'hard-wired', 'power-domains' were unexpected) arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb pcie@33800000: Unevaluated properties are not allowed ('clock-names', 'power-domains' were unexpected) arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33800000: Unevaluated properties are not allowed ('power-domains', 'reset-names', 'resets' were unexpected) arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb arch/arm64/boot/dts/freescale/imx8mm-evk.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb arch/arm64/boot/dts/freescale/imx8mp-evk.dtb arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb pcie@33800000: Unevaluated properties are not allowed ('power-domains' was unexpected) arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb arch/arm/boot/dts/imx7d-cl-som-imx7.dtb arch/arm/boot/dts/imx7d-colibri-aster.dtb arch/arm/boot/dts/imx7d-colibri-emmc-aster.dtb arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dtb arch/arm/boot/dts/imx7d-colibri-emmc-iris.dtb arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dtb arch/arm/boot/dts/imx7d-colibri-eval-v3.dtb arch/arm/boot/dts/imx7d-colibri-iris.dtb arch/arm/boot/dts/imx7d-colibri-iris-v2.dtb arch/arm/boot/dts/imx7d-flex-concentrator.dtb arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dtb arch/arm/boot/dts/imx7d-mba7.dtb arch/arm/boot/dts/imx7d-meerkat96.dtb arch/arm/boot/dts/imx7d-nitrogen7.dtb arch/arm/boot/dts/imx7d-pico-dwarf.dtb arch/arm/boot/dts/imx7d-pico-hobbit.dtb arch/arm/boot/dts/imx7d-pico-nymph.dtb arch/arm/boot/dts/imx7d-pico-pi.dtb arch/arm/boot/dts/imx7d-remarkable2.dtb arch/arm/boot/dts/imx7d-sbc-imx7.dtb arch/arm/boot/dts/imx7d-sdb.dtb arch/arm/boot/dts/imx7d-sdb-reva.dtb arch/arm/boot/dts/imx7d-sdb-sht11.dtb arch/arm/boot/dts/imx7d-smegw01.dtb arch/arm/boot/dts/imx7d-zii-rmu2.dtb arch/arm/boot/dts/imx7d-zii-rpu2.dtb pcie@33c00000: 'bus-range' is a required property arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: clock-names:1: 'pcie_bus' was expected arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: clock-names:3: 'pcie_aux' was expected arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: clock-names:3: 'pcie_bus' is not one of ['pcie_inbound_axi', 'pcie_aux'] arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: power-domains: [[102]] is too short arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb pcie@33c00000: power-domains: [[125]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb pcie@33c00000: power-domains: [[126]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb pcie@33c00000: power-domains: [[70]] is too short arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb pcie@33c00000: power-domains: [[78]] is too short arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb pcie@33c00000: power-domains: [[79]] is too short arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb pcie@33c00000: power-domains: [[80]] is too short arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb pcie@33c00000: power-domains: [[81]] is too short arch/arm64/boot/dts/freescale/imx8mq-evk.dtb pcie@33c00000: power-domains: [[82]] is too short arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb pcie@33c00000: power-domains: [[92]] is too short arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb pcie@33c00000: power-domains: [[97]] is too short arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb pcie@33c00000: power-domains: [[98]] is too short arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: Unevaluated properties are not allowed ('clock-names', 'epdev_on-supply', 'hard-wired', 'power-domains' were unexpected) arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb pcie@33c00000: Unevaluated properties are not allowed ('clock-names', 'power-domains' were unexpected) arch/arm64/boot/dts/freescale/imx8mq-evk.dtb arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb pcie@33c00000: Unevaluated properties are not allowed ('power-domains' was unexpected) arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq 2022-11-14 0:06 ` Rob Herring @ 2022-11-14 11:51 ` Serge Semin 0 siblings, 0 replies; 8+ messages in thread From: Serge Semin @ 2022-11-14 11:51 UTC (permalink / raw) To: Rob Herring Cc: Serge Semin, Gustavo Pimentel, Krzysztof Wilczyński, caihuoqing, linux-pci, NXP Linux Team, Alexey Malahov, devicetree, Vinod Koul, Bjorn Helgaas, Sascha Hauer, Jingoo Han, Krzysztof Kozlowski, Rob Herring, Lorenzo Pieralisi, Pavel Parkhomenko, linux-kernel, linux-arm-kernel, Frank Li, Pengutronix Kernel Team, Lucas Stach, Manivannan Sadhasivam, Richard Zhu, Robin Murphy, Cai Huoqing, Fabio Estevam, Alexander Stein, Shawn Guo On Sun, Nov 13, 2022 at 06:06:28PM -0600, Rob Herring wrote: > > On Sun, 13 Nov 2022 22:12:42 +0300, Serge Semin wrote: > > Originally as it was defined the legacy bindings the pcie_inbound_axi and > > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > > Let's fix that by conditionally apply the clock-names constraints based on > > the compatible string content. > > > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > --- > > > > Changelog v5: > > - This is a new patch added on the v5 release of the patchset. > > > > Changelog v7: > > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > > - Get back the names to the clock-names property and make sure the > > platform-specific name constraint is applied in the allOf clause. > > (@Rob) > > --- > > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > > 1 file changed, 42 insertions(+), 4 deletions(-) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. Yeah, these are the old warnings. No semantic change causing them provided in this patch. -Sergey > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > pcie@1ffc000: Unevaluated properties are not allowed ('disable-gpio' was unexpected) > arch/arm/boot/dts/imx6dl-emcon-avari.dtb > arch/arm/boot/dts/imx6q-emcon-avari.dtb > > pcie@33800000: clock-names:1: 'pcie_bus' was expected > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33800000: clock-names:2: 'pcie_phy' was expected > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > > pcie@33800000: clock-names:3: 'pcie_aux' was expected > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33800000: clock-names:3: 'pcie_bus' is not one of ['pcie_inbound_axi', 'pcie_aux'] > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33800000: power-domains: [[102, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: power-domains: [[102]] is too short > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > > pcie@33800000: power-domains: [[103]] is too short > arch/arm/boot/dts/imx7d-colibri-emmc-iris.dtb > arch/arm/boot/dts/imx7d-colibri-iris.dtb > > pcie@33800000: power-domains: [[104]] is too short > arch/arm/boot/dts/imx7d-colibri-aster.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-aster.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dtb > arch/arm/boot/dts/imx7d-colibri-iris-v2.dtb > > pcie@33800000: power-domains: [[106]] is too short > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > > pcie@33800000: power-domains: [[107]] is too short > arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dtb > arch/arm/boot/dts/imx7d-colibri-eval-v3.dtb > > pcie@33800000: power-domains: [[108]] is too short > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > > pcie@33800000: power-domains: [[125]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb > > pcie@33800000: power-domains: [[126]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb > > pcie@33800000: power-domains: [[49, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > > pcie@33800000: power-domains: [[55]] is too short > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > > pcie@33800000: power-domains: [[59]] is too short > arch/arm/boot/dts/imx7d-cl-som-imx7.dtb > > pcie@33800000: power-domains: [[60, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > > pcie@33800000: power-domains: [[61]] is too short > arch/arm/boot/dts/imx7d-sbc-imx7.dtb > > pcie@33800000: power-domains: [[63]] is too short > arch/arm/boot/dts/imx7d-zii-rmu2.dtb > > pcie@33800000: power-domains: [[64, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > > pcie@33800000: power-domains: [[64]] is too short > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm/boot/dts/imx7d-remarkable2.dtb > > pcie@33800000: power-domains: [[67]] is too short > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > > pcie@33800000: power-domains: [[68]] is too short > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm/boot/dts/imx7d-meerkat96.dtb > > pcie@33800000: power-domains: [[70, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > > pcie@33800000: power-domains: [[70]] is too short > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb > arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb > > pcie@33800000: power-domains: [[72]] is too short > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > > pcie@33800000: power-domains: [[73]] is too short > arch/arm/boot/dts/imx7d-flex-concentrator.dtb > arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dtb > arch/arm/boot/dts/imx7d-smegw01.dtb > > pcie@33800000: power-domains: [[75]] is too short > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > > pcie@33800000: power-domains: [[76, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > > pcie@33800000: power-domains: [[76]] is too short > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > > pcie@33800000: power-domains: [[77]] is too short > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > > pcie@33800000: power-domains: [[78]] is too short > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb > > pcie@33800000: power-domains: [[79]] is too short > arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb > > pcie@33800000: power-domains: [[80]] is too short > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > > pcie@33800000: power-domains: [[81]] is too short > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > > pcie@33800000: power-domains: [[82]] is too short > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb > > pcie@33800000: power-domains: [[83, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > > pcie@33800000: power-domains: [[84]] is too short > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > > pcie@33800000: power-domains: [[86, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > > pcie@33800000: power-domains: [[86]] is too short > arch/arm/boot/dts/imx7d-nitrogen7.dtb > arch/arm/boot/dts/imx7d-pico-nymph.dtb > > pcie@33800000: power-domains: [[87]] is too short > arch/arm/boot/dts/imx7d-sdb-reva.dtb > > pcie@33800000: power-domains: [[88]] is too short > arch/arm/boot/dts/imx7d-pico-dwarf.dtb > arch/arm/boot/dts/imx7d-pico-hobbit.dtb > arch/arm/boot/dts/imx7d-sdb.dtb > arch/arm/boot/dts/imx7d-sdb-sht11.dtb > > pcie@33800000: power-domains: [[89]] is too short > arch/arm/boot/dts/imx7d-pico-pi.dtb > arch/arm/boot/dts/imx7d-zii-rpu2.dtb > > pcie@33800000: power-domains: [[92]] is too short > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > > pcie@33800000: power-domains: [[96]] is too short > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm/boot/dts/imx7d-mba7.dtb > > pcie@33800000: power-domains: [[97, 3]] is too short > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > > pcie@33800000: power-domains: [[97]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb > > pcie@33800000: power-domains: [[98]] is too short > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33800000: reset-names:0: 'pciephy' was expected > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: reset-names:1: 'apps' was expected > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: reset-names: ['apps', 'turnoff'] is too short > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: resets: [[101, 26], [101, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: resets: [[25, 28], [25, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > > pcie@33800000: resets: [[26, 28], [26, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > > pcie@33800000: resets: [[27, 28], [27, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > > pcie@33800000: resets: [[28, 28], [28, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > > pcie@33800000: resets: [[29, 28], [29, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > > pcie@33800000: resets: [[31, 28], [31, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > > pcie@33800000: resets: [[34, 28], [34, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > > pcie@33800000: resets: [[40, 28], [40, 29]] is too short > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > > pcie@33800000: resets: [[48, 26], [48, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > > pcie@33800000: resets: [[59, 26], [59, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > > pcie@33800000: resets: [[63, 26], [63, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > > pcie@33800000: resets: [[69, 26], [69, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > > pcie@33800000: resets: [[75, 26], [75, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > > pcie@33800000: resets: [[82, 26], [82, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > > pcie@33800000: resets: [[85, 26], [85, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > > pcie@33800000: resets: [[96, 26], [96, 27]] is too short > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > > pcie@33800000: Unevaluated properties are not allowed ('clock-names', 'epdev_on-supply', 'hard-wired', 'power-domains' were unexpected) > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > > pcie@33800000: Unevaluated properties are not allowed ('clock-names', 'power-domains' were unexpected) > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33800000: Unevaluated properties are not allowed ('power-domains', 'reset-names', 'resets' were unexpected) > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dtb > arch/arm64/boot/dts/freescale/imx8mm-ddr4-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb > arch/arm64/boot/dts/freescale/imx8mm-evk.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-ctouch2.dtb > arch/arm64/boot/dts/freescale/imx8mm-icore-mx8mm-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl.dtb > arch/arm64/boot/dts/freescale/imx8mm-kontron-bl-osm-s.dtb > arch/arm64/boot/dts/freescale/imx8mm-mx8menlo.dtb > arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dtb > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk2.dtb > arch/arm64/boot/dts/freescale/imx8mp-evk.dtb > arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp-edimm2.2.dtb > arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dtb > arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb > arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dtb > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-nonwifi-dev.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi-dev.dtb > > pcie@33800000: Unevaluated properties are not allowed ('power-domains' was unexpected) > arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb > arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb > arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb > arch/arm/boot/dts/imx7d-cl-som-imx7.dtb > arch/arm/boot/dts/imx7d-colibri-aster.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-aster.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-eval-v3.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-iris.dtb > arch/arm/boot/dts/imx7d-colibri-emmc-iris-v2.dtb > arch/arm/boot/dts/imx7d-colibri-eval-v3.dtb > arch/arm/boot/dts/imx7d-colibri-iris.dtb > arch/arm/boot/dts/imx7d-colibri-iris-v2.dtb > arch/arm/boot/dts/imx7d-flex-concentrator.dtb > arch/arm/boot/dts/imx7d-flex-concentrator-mfg.dtb > arch/arm/boot/dts/imx7d-mba7.dtb > arch/arm/boot/dts/imx7d-meerkat96.dtb > arch/arm/boot/dts/imx7d-nitrogen7.dtb > arch/arm/boot/dts/imx7d-pico-dwarf.dtb > arch/arm/boot/dts/imx7d-pico-hobbit.dtb > arch/arm/boot/dts/imx7d-pico-nymph.dtb > arch/arm/boot/dts/imx7d-pico-pi.dtb > arch/arm/boot/dts/imx7d-remarkable2.dtb > arch/arm/boot/dts/imx7d-sbc-imx7.dtb > arch/arm/boot/dts/imx7d-sdb.dtb > arch/arm/boot/dts/imx7d-sdb-reva.dtb > arch/arm/boot/dts/imx7d-sdb-sht11.dtb > arch/arm/boot/dts/imx7d-smegw01.dtb > arch/arm/boot/dts/imx7d-zii-rmu2.dtb > arch/arm/boot/dts/imx7d-zii-rpu2.dtb > > pcie@33c00000: 'bus-range' is a required property > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: clock-names:1: 'pcie_bus' was expected > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: clock-names:3: 'pcie_aux' was expected > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: clock-names:3: 'pcie_bus' is not one of ['pcie_inbound_axi', 'pcie_aux'] > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: power-domains: [[102]] is too short > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > > pcie@33c00000: power-domains: [[125]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb > > pcie@33c00000: power-domains: [[126]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb > > pcie@33c00000: power-domains: [[70]] is too short > arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb > arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb > > pcie@33c00000: power-domains: [[78]] is too short > arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb > > pcie@33c00000: power-domains: [[79]] is too short > arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb > > pcie@33c00000: power-domains: [[80]] is too short > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > > pcie@33c00000: power-domains: [[81]] is too short > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > > pcie@33c00000: power-domains: [[82]] is too short > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb > > pcie@33c00000: power-domains: [[92]] is too short > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > > pcie@33c00000: power-domains: [[97]] is too short > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb > > pcie@33c00000: power-domains: [[98]] is too short > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: Unevaluated properties are not allowed ('clock-names', 'epdev_on-supply', 'hard-wired', 'power-domains' were unexpected) > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb > > pcie@33c00000: Unevaluated properties are not allowed ('clock-names', 'power-domains' were unexpected) > arch/arm64/boot/dts/freescale/imx8mq-evk.dtb > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dtb > arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-rmb3.dtb > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra-zest.dtb > > pcie@33c00000: Unevaluated properties are not allowed ('power-domains' was unexpected) > arch/arm64/boot/dts/freescale/imx8mq-hummingboard-pulse.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtb > arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dtb > arch/arm64/boot/dts/freescale/imx8mq-nitrogen.dtb > arch/arm64/boot/dts/freescale/imx8mq-phanbell.dtb > arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dtb > arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq 2022-11-13 19:12 ` [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Serge Semin 2022-11-14 0:06 ` Rob Herring @ 2022-11-16 20:38 ` Rob Herring 2022-11-17 7:43 ` Serge Semin 1 sibling, 1 reply; 8+ messages in thread From: Rob Herring @ 2022-11-16 20:38 UTC (permalink / raw) To: Serge Semin Cc: Krzysztof Kozlowski, Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Robin Murphy, Jingoo Han, Gustavo Pimentel, Richard Zhu, Lucas Stach, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Serge Semin, Alexey Malahov, Pavel Parkhomenko, Krzysztof Wilczyński, Frank Li, Manivannan Sadhasivam, caihuoqing, Vinod Koul, linux-pci, devicetree, linux-kernel, Alexander Stein, linux-arm-kernel, Marek Vasut On Sun, Nov 13, 2022 at 10:12:42PM +0300, Serge Semin wrote: > Originally as it was defined the legacy bindings the pcie_inbound_axi and > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > Let's fix that by conditionally apply the clock-names constraints based on > the compatible string content. > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > Changelog v5: > - This is a new patch added on the v5 release of the patchset. > > Changelog v7: > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > - Get back the names to the clock-names property and make sure the > platform-specific name constraint is applied in the allOf clause. > (@Rob) > --- > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > 1 file changed, 42 insertions(+), 4 deletions(-) We have 2 patches doing the same thing: https://lore.kernel.org/all/20221109002449.35936-1-marex@denx.de/ Please hash out which one you all want. Both seem to have clock warnings still... Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq 2022-11-16 20:38 ` Rob Herring @ 2022-11-17 7:43 ` Serge Semin 2022-11-17 7:59 ` Serge Semin 0 siblings, 1 reply; 8+ messages in thread From: Serge Semin @ 2022-11-17 7:43 UTC (permalink / raw) To: Rob Herring, Marek Vasut, Alexander Stein, Fabio Estevam, Krzysztof Kozlowski Cc: Serge Semin, Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Robin Murphy, Jingoo Han, Gustavo Pimentel, Richard Zhu, Lucas Stach, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team, Alexey Malahov, Pavel Parkhomenko, Krzysztof Wilczyński, Frank Li, Manivannan Sadhasivam, caihuoqing, Vinod Koul, linux-pci, devicetree, linux-kernel, linux-arm-kernel On Wed, Nov 16, 2022 at 02:38:12PM -0600, Rob Herring wrote: > On Sun, Nov 13, 2022 at 10:12:42PM +0300, Serge Semin wrote: > > Originally as it was defined the legacy bindings the pcie_inbound_axi and > > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > > Let's fix that by conditionally apply the clock-names constraints based on > > the compatible string content. > > > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > --- > > > > Changelog v5: > > - This is a new patch added on the v5 release of the patchset. > > > > Changelog v7: > > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > > - Get back the names to the clock-names property and make sure the > > platform-specific name constraint is applied in the allOf clause. > > (@Rob) > > --- > > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > > 1 file changed, 42 insertions(+), 4 deletions(-) > > We have 2 patches doing the same thing: > > https://lore.kernel.org/all/20221109002449.35936-1-marex@denx.de/ It seems to me that that patch does two things at a time: 1. Fixes invalid fourth clock-names entry. 2. Fixes the fsl,imx8mm-pcie device having the "pcie_aux" clock name required instead of "pcie_phy". My patch does only the first part. What about moving my patch to that series and converting the Marek' patch to being applicable on top of it and fixing the imx8mm part only? That seems reasonable. -Sergey > > Please hash out which one you all want. Both seem to have clock > warnings still... > > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq 2022-11-17 7:43 ` Serge Semin @ 2022-11-17 7:59 ` Serge Semin 0 siblings, 0 replies; 8+ messages in thread From: Serge Semin @ 2022-11-17 7:59 UTC (permalink / raw) To: Rob Herring, Marek Vasut, Alexander Stein, Fabio Estevam, Krzysztof Kozlowski Cc: Serge Semin, Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Robin Murphy, Jingoo Han, Gustavo Pimentel, Richard Zhu, Lucas Stach, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team, Alexey Malahov, Pavel Parkhomenko, Krzysztof Wilczyński, Frank Li, Manivannan Sadhasivam, caihuoqing, Vinod Koul, linux-pci, devicetree, linux-kernel, linux-arm-kernel On Thu, Nov 17, 2022 at 10:43:22AM +0300, Serge Semin wrote: > On Wed, Nov 16, 2022 at 02:38:12PM -0600, Rob Herring wrote: > > On Sun, Nov 13, 2022 at 10:12:42PM +0300, Serge Semin wrote: > > > Originally as it was defined the legacy bindings the pcie_inbound_axi and > > > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > > > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > > > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > > > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > > > Let's fix that by conditionally apply the clock-names constraints based on > > > the compatible string content. > > > > > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > > > --- > > > > > > Changelog v5: > > > - This is a new patch added on the v5 release of the patchset. > > > > > > Changelog v7: > > > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > > > - Get back the names to the clock-names property and make sure the > > > platform-specific name constraint is applied in the allOf clause. > > > (@Rob) > > > --- > > > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > > > 1 file changed, 42 insertions(+), 4 deletions(-) > > > > We have 2 patches doing the same thing: > > > > https://lore.kernel.org/all/20221109002449.35936-1-marex@denx.de/ > > It seems to me that that patch does two things at a time: > 1. Fixes invalid fourth clock-names entry. > 2. Fixes the fsl,imx8mm-pcie device having the "pcie_aux" clock name > required instead of "pcie_phy". > > My patch does only the first part. What about moving my patch to that > series and converting the Marek' patch to being applicable on top of > it and fixing the imx8mm part only? That seems reasonable. BTW, if this patch is moved from here the series will fail the dt_binding_check procedure. -Sergey > > -Sergey > > > > > Please hash out which one you all want. Both seem to have clock > > warnings still... > > > > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v7 02/20] dt-bindings: visconti-pcie: Fix interrupts array max constraints [not found] <20221113191301.5526-1-Sergey.Semin@baikalelectronics.ru> 2022-11-13 19:12 ` [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Serge Semin @ 2022-11-13 19:12 ` Serge Semin 2022-11-13 19:12 ` [PATCH v7 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes Serge Semin 2 siblings, 0 replies; 8+ messages in thread From: Serge Semin @ 2022-11-13 19:12 UTC (permalink / raw) To: Rob Herring, Rob Herring, Krzysztof Kozlowski, Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Robin Murphy, Jingoo Han, Gustavo Pimentel, Nobuhiro Iwamatsu Cc: Serge Semin, Serge Semin, Alexey Malahov, Pavel Parkhomenko, Krzysztof Wilczyński, Frank Li, Manivannan Sadhasivam, caihuoqing, Vinod Koul, linux-pci, devicetree, linux-kernel, linux-arm-kernel In accordance with the way the device DT-node is actually defined in arch/arm64/boot/dts/toshiba/tmpv7708.dtsi and the way the device is probed by the DW PCIe driver there are two IRQs it actually has. It's MSI IRQ the DT-bindings lack. Let's extend the interrupts property constraints then and fix the schema example so one would be acceptable by the actual device DT-bindings. Fixes: 17c1b16340f0 ("dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller") Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Acked-by: Rob Herring <robh@kernel.org> Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> --- Changelog v5: - This is a new patch added on the v5 release of the patchset. --- .../devicetree/bindings/pci/toshiba,visconti-pcie.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml b/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml index 48ed227fc5b9..53da2edd7c9a 100644 --- a/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml @@ -36,7 +36,7 @@ properties: - const: mpu interrupts: - maxItems: 1 + maxItems: 2 clocks: items: @@ -94,8 +94,9 @@ examples: #interrupt-cells = <1>; ranges = <0x81000000 0 0x40000000 0 0x40000000 0 0x00010000>, <0x82000000 0 0x50000000 0 0x50000000 0 0x20000000>; - interrupts = <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "intr"; + interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "msi", "intr"; interrupt-map-mask = <0 0 0 7>; interrupt-map = <0 0 0 1 &gic GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH -- 2.38.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v7 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes [not found] <20221113191301.5526-1-Sergey.Semin@baikalelectronics.ru> 2022-11-13 19:12 ` [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Serge Semin 2022-11-13 19:12 ` [PATCH v7 02/20] dt-bindings: visconti-pcie: Fix interrupts array max constraints Serge Semin @ 2022-11-13 19:12 ` Serge Semin 2 siblings, 0 replies; 8+ messages in thread From: Serge Semin @ 2022-11-13 19:12 UTC (permalink / raw) To: Rob Herring, Rob Herring, Krzysztof Kozlowski, Bjorn Helgaas, Lorenzo Pieralisi, Cai Huoqing, Robin Murphy, Jingoo Han, Gustavo Pimentel, Heiko Stuebner, Shawn Lin, Simon Xue Cc: Serge Semin, Serge Semin, Alexey Malahov, Pavel Parkhomenko, Krzysztof Wilczyński, Frank Li, Manivannan Sadhasivam, caihuoqing, Vinod Koul, linux-pci, devicetree, linux-kernel, linux-arm-kernel, linux-rockchip As the DT-bindings description states the Rockchip PCIe controller is based on the DW PCIe RP IP-core thus its DT-nodes are supposed to be compatible with the common DW PCIe controller schema. Let's make sure they are evaluated against it by referring to the snps,dw-pcie.yaml schema in the allOf sub-schemas composition. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Rob Herring <robh@kernel.org> --- Changelog v3: - This is a new patch created on v3 lap of the series. Changelog v5: - Apply snps,dw-pcie.yaml instead of the snps,dw-pcie-common.yaml schema. --- Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml index bc0a9d1db750..2be72ae1169f 100644 --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml @@ -14,10 +14,10 @@ maintainers: description: |+ RK3568 SoC PCIe host controller is based on the Synopsys DesignWare PCIe IP and thus inherits all the common properties defined in - designware-pcie.txt. + snps,dw-pcie.yaml. allOf: - - $ref: /schemas/pci/pci-bus.yaml# + - $ref: /schemas/pci/snps,dw-pcie.yaml# properties: compatible: -- 2.38.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-17 8:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221113191301.5526-1-Sergey.Semin@baikalelectronics.ru>
2022-11-13 19:12 ` [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Serge Semin
2022-11-14 0:06 ` Rob Herring
2022-11-14 11:51 ` Serge Semin
2022-11-16 20:38 ` Rob Herring
2022-11-17 7:43 ` Serge Semin
2022-11-17 7:59 ` Serge Semin
2022-11-13 19:12 ` [PATCH v7 02/20] dt-bindings: visconti-pcie: Fix interrupts array max constraints Serge Semin
2022-11-13 19:12 ` [PATCH v7 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes Serge Semin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).