From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24818C4332F for ; Thu, 17 Nov 2022 07:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GD7roCn5hGJMeX4s+IFKhWrDWUEByH818Hyr6E/WGzI=; b=3mStV/d6R6fnTv ibgVA+41juLXtaqJsKtwzSVTp7OIxcZq/gAdpHRSnU89FdMi1d3ufOB31ZiHxQRmJ+g9YxR9Z5sBm SVcuZtsj/RtLbNLVJ5T4LLubtkOuhRXX2orLmYOo1g2O8FuLlWJYL6LZRTN4Idui6AJK7waBcGpd6 krNEs8BUZAMpgiXwwbMvG3S4/pULrPUDa3rlZTXry2x49ccfVSwPfv9Vtbp/wPDsjPg5HLb3CrWZ/ 7sDSyd35Fr1DV0pYwRuUbUNuCwIOxccFbRIralQluEGc718sl/g5rUPiFzP1MoC5gVnNXwFuToLfS UWApebTy6EUuzJNgNb/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovZYX-00BJsc-O7; Thu, 17 Nov 2022 07:43:29 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovZYU-00BJs1-BA for linux-arm-kernel@lists.infradead.org; Thu, 17 Nov 2022 07:43:27 +0000 Received: by mail-lf1-x12f.google.com with SMTP id s8so1470428lfc.8 for ; Wed, 16 Nov 2022 23:43:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nNAXKBtGSeRWoeTA7vve2sl147mbg/EYPDhDH8dLOgc=; b=CRZk9rEK6s7SNtff/bWseZb5knLL5lebeP9aso16FoCExHgCUWAraboRWFhJU6zkvg t4LLhCu3XMWnJY0m39qHYrNOHesCpgx1Ld2rXxBqGWmwB/jcU+gEX3cF5AcDo46pvdhK +UPmNSgxNzMALBLNfrdA9ZScaK/5ir/QglDIDwkPjkLslZkVGMG96jEDf6Bl5SWDs/In 9oQpRiAgpxMOdZwsbq5zzNeLwdplem3n3i3J79+A189xNRLQjSluCPs9RjNd7Bch3zb3 u2APYGEtMc5E/1K/qqRU5w/2kSwQOIlkd0nyjf0QcqoIcF4SprXVsAiFpGmlu1k/vsDv QVTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nNAXKBtGSeRWoeTA7vve2sl147mbg/EYPDhDH8dLOgc=; b=jocQzQUhplwAA83M2ZyK0OyjYm973Kqr5Jo+eTG/7FHG1yKVkvIRaueKMBye78YwM8 nmkrqjoGnfOkHLtcX3v9TeeSIig+9VSKvLe9RJJ8BsZeXtLzkZExLHIXSFQIrT0+iZz1 I8p8oEmYWRlOVDtCjKBtNrx5jx5aBhUaZYCpqRGZnP/QT/Gif45qJJXqAEvaUcYXkjA4 V08E+fADDdvfEIOMl8R2vRN7n1m8zREhoyJk4okKH1F2+/nT9/d/gpwlmFe9nw7S37RQ Un68rIXfGowcP9BRQx+ucfArM3yBY4mXSm4ieweB/dLC+H6FS9cKJpsSld1vAWfUQA+S 328w== X-Gm-Message-State: ANoB5pmhZr+0o9CtwSslrReAa+JExA87KkQAsCt/+Ie97HJQFklAfpkx nGwxNyuOVQC2qsEKbGLRqyU= X-Google-Smtp-Source: AA0mqf7IepfQFcb3diG+BAtuWDc5M//Q/p7NePZuD734IrU4330b95+BMtbtDyD6306P2XTryefO6w== X-Received: by 2002:a05:6512:3e2a:b0:4ab:534b:1b2c with SMTP id i42-20020a0565123e2a00b004ab534b1b2cmr443337lfv.426.1668671001885; Wed, 16 Nov 2022 23:43:21 -0800 (PST) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id w8-20020a2e9bc8000000b0026e00df2ed0sm53607ljj.30.2022.11.16.23.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 23:43:21 -0800 (PST) Date: Thu, 17 Nov 2022 10:43:18 +0300 From: Serge Semin To: Rob Herring , Marek Vasut , Alexander Stein , Fabio Estevam , Krzysztof Kozlowski Cc: Serge Semin , Bjorn Helgaas , Lorenzo Pieralisi , Cai Huoqing , Robin Murphy , Jingoo Han , Gustavo Pimentel , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Alexey Malahov , Pavel Parkhomenko , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Frank Li , Manivannan Sadhasivam , caihuoqing , Vinod Koul , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Message-ID: <20221117074318.cd52h5ks7ay4j4wb@mobilestation> References: <20221113191301.5526-1-Sergey.Semin@baikalelectronics.ru> <20221113191301.5526-2-Sergey.Semin@baikalelectronics.ru> <20221116203812.GA834519-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221116203812.GA834519-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221116_234326_420925_C658874B X-CRM114-Status: GOOD ( 23.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 16, 2022 at 02:38:12PM -0600, Rob Herring wrote: > On Sun, Nov 13, 2022 at 10:12:42PM +0300, Serge Semin wrote: > > Originally as it was defined the legacy bindings the pcie_inbound_axi and > > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > > Let's fix that by conditionally apply the clock-names constraints based on > > the compatible string content. > > > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > > Signed-off-by: Serge Semin > > Acked-by: Alexander Stein > > > > --- > > > > Changelog v5: > > - This is a new patch added on the v5 release of the patchset. > > > > Changelog v7: > > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > > - Get back the names to the clock-names property and make sure the > > platform-specific name constraint is applied in the allOf clause. > > (@Rob) > > --- > > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > > 1 file changed, 42 insertions(+), 4 deletions(-) > > We have 2 patches doing the same thing: > > https://lore.kernel.org/all/20221109002449.35936-1-marex@denx.de/ It seems to me that that patch does two things at a time: 1. Fixes invalid fourth clock-names entry. 2. Fixes the fsl,imx8mm-pcie device having the "pcie_aux" clock name required instead of "pcie_phy". My patch does only the first part. What about moving my patch to that series and converting the Marek' patch to being applicable on top of it and fixing the imx8mm part only? That seems reasonable. -Sergey > > Please hash out which one you all want. Both seem to have clock > warnings still... > > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel