From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C22EC433FE for ; Thu, 17 Nov 2022 08:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K0BUuvK5dp2SvptytyRNHSihjGyYlTa6mya49CQikCw=; b=iF55etiMBl3azZ dGDzWzhcRfES2LAuwgE6NRcMCGPwOy2BZXrVxkFQNJjC9Lu/w5ERQ1t21AX45VO91ejxAGD+UBsfr aWZPffojudCXHSURNjMeSttdGYpCkyFMMAHUWLGRPys6NV1Dwru2dKDNGAKqmQMgGzkmXfUdkD2T1 eQ0yppoPsFfseFbyrRJZsw1uiUbMO07FWT7j2PRRskCPvgad1QHFlAWp1lm7u1e+Oz/oDb/pM3oFZ 2Dq4Mz1HYumgj9PHXxAW2E8YI2zXj4iYbqapjGqEPe00CIa4nA86o867aHekELOONYElL6n0+ugjH 07IqI4wX8IXuxM7bgeqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovZob-00BPGM-9w; Thu, 17 Nov 2022 08:00:05 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovZoX-00BPBr-IL for linux-arm-kernel@lists.infradead.org; Thu, 17 Nov 2022 08:00:03 +0000 Received: by mail-lf1-x12b.google.com with SMTP id g7so1543774lfv.5 for ; Thu, 17 Nov 2022 00:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hy7NLr5hqE2CbJ9jouBdK1ZIwHDUPfh4zTUfGBjG5As=; b=n7y4fRjf6M5mskOzXdXUZu8ArEzlfdQw6BxAnS7gl3FgJm37oY7ADxdez6z4WWtTEk GZeTVdJPSVQyNhme1p8tRboH2k51cxTEp8FLujI3ksGvHyel2Gyta3T8gmbGylSm7rwA ZKFDykhol1g8+PCoHl1KQi6weDsspBkelXR/lkOk9fV9WD1QVDExKjbRjO/Adltz8PDH KljdCHYf+Ok5oN5ZLJ+Dxe9MFmgMQZB7M5h4ZaWFO68V2azjPzkURmfYgBkzoVIJCZjX 9fU97XTmcsYxdyLWTdI9jmgzKUFNnDrGjZW1+wVIo/BrtSaho6N/nwid7ytf5AzDXNIL tbfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Hy7NLr5hqE2CbJ9jouBdK1ZIwHDUPfh4zTUfGBjG5As=; b=Toj9w5bTcACcLTVFP7xFLzfgU+/zM9xN7NwkGw0GAD0hR87TedHRgOylHiuTfnn758 QolFsDt+Xo4tbubXpGmph4BWhBD+nUdj2Ydh/BIfp1wF8CnR3X79EcHuwjS4peDVdy1z KWHinjQOSMD3wFV3EQ80OJs9fBOo2/ITdvztlO7xUY/eKzKVyBy8cBWGxoZW/Jj5j6AM pcAgvR1qyQc/oxNePC+GcxYVERJXHJFvsIkPTvG+n9FkaSmriVBW9Gq3XWO1R5gVW0eZ ST2EvnZPo1BHmSlf+m2Emc0v7B8y8Iq/k5rLXgsDOobxjI83v5P4R1tE2veIJYLGpm/j kVpA== X-Gm-Message-State: ANoB5pmKSYt/LAobUJFUMLAyvThdlhHdofeEkYwEm5hQYIXYvFHjYcd5 yqEjqVTgrMh90UPT5gwCn44= X-Google-Smtp-Source: AA0mqf5/X/D4OGM7Km0DSNGgRsSX5HuHd40Bn19ehlIO61z4kcYkdVKpjil1rziL0MyeWcAlCyLmvw== X-Received: by 2002:ac2:4201:0:b0:4b1:7c15:e923 with SMTP id y1-20020ac24201000000b004b17c15e923mr512728lfh.320.1668671999651; Wed, 16 Nov 2022 23:59:59 -0800 (PST) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id b17-20020a196711000000b004a100c21eaesm28532lfc.97.2022.11.16.23.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 23:59:59 -0800 (PST) Date: Thu, 17 Nov 2022 10:59:56 +0300 From: Serge Semin To: Rob Herring , Marek Vasut , Alexander Stein , Fabio Estevam , Krzysztof Kozlowski Cc: Serge Semin , Bjorn Helgaas , Lorenzo Pieralisi , Cai Huoqing , Robin Murphy , Jingoo Han , Gustavo Pimentel , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Alexey Malahov , Pavel Parkhomenko , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Frank Li , Manivannan Sadhasivam , caihuoqing , Vinod Koul , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 01/20] dt-bindings: imx6q-pcie: Fix clock names for imx6sx and imx8mq Message-ID: <20221117075956.4dw4g7cswr2iamro@mobilestation> References: <20221113191301.5526-1-Sergey.Semin@baikalelectronics.ru> <20221113191301.5526-2-Sergey.Semin@baikalelectronics.ru> <20221116203812.GA834519-robh@kernel.org> <20221117074318.cd52h5ks7ay4j4wb@mobilestation> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221117074318.cd52h5ks7ay4j4wb@mobilestation> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_000001_651677_A4E3FFD3 X-CRM114-Status: GOOD ( 27.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 10:43:22AM +0300, Serge Semin wrote: > On Wed, Nov 16, 2022 at 02:38:12PM -0600, Rob Herring wrote: > > On Sun, Nov 13, 2022 at 10:12:42PM +0300, Serge Semin wrote: > > > Originally as it was defined the legacy bindings the pcie_inbound_axi and > > > pcie_aux clock names were supposed to be used in the fsl,imx6sx-pcie and > > > fsl,imx8mq-pcie devices respectively. But the bindings conversion has been > > > incorrectly so now the fourth clock name is defined as "pcie_inbound_axi > > > for imx6sx-pcie, pcie_aux for imx8mq-pcie", which is completely wrong. > > > Let's fix that by conditionally apply the clock-names constraints based on > > > the compatible string content. > > > > > > Fixes: 751ca492f131 ("dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema") > > > Signed-off-by: Serge Semin > > > Acked-by: Alexander Stein > > > > > > --- > > > > > > Changelog v5: > > > - This is a new patch added on the v5 release of the patchset. > > > > > > Changelog v7: > > > - Move the allOf clause to the bottom of the bindings. (@Krzysztof) > > > - Get back the names to the clock-names property and make sure the > > > platform-specific name constraint is applied in the allOf clause. > > > (@Rob) > > > --- > > > .../bindings/pci/fsl,imx6q-pcie.yaml | 46 +++++++++++++++++-- > > > 1 file changed, 42 insertions(+), 4 deletions(-) > > > > We have 2 patches doing the same thing: > > > > https://lore.kernel.org/all/20221109002449.35936-1-marex@denx.de/ > > It seems to me that that patch does two things at a time: > 1. Fixes invalid fourth clock-names entry. > 2. Fixes the fsl,imx8mm-pcie device having the "pcie_aux" clock name > required instead of "pcie_phy". > > My patch does only the first part. What about moving my patch to that > series and converting the Marek' patch to being applicable on top of > it and fixing the imx8mm part only? That seems reasonable. BTW, if this patch is moved from here the series will fail the dt_binding_check procedure. -Sergey > > -Sergey > > > > > Please hash out which one you all want. Both seem to have clock > > warnings still... > > > > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel