From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0EB0C433FE for ; Thu, 17 Nov 2022 22:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vxqPszexubKuLMrYp6ry8wcn5vB7qQtGxgxpOwwY3+8=; b=pV+DqJQdiHjp9r VUKNa0eQmiKZO3c2iEKQouJhQY0/VhfC0u7TfyxlEfo3T+8IBtQt4d0f99ux5AQJu0DufA1VaKVwW SqpXe4gP4YRz5F90PPwC/TvEEUG9kQmxcgE+G2DnufTG3pgclduwDtyY081E5MpFFhXwEc1gWFHRq GdHiduNhsFUdpBWUfhs3JHafFKUdWpoKiifSVVSTaQwj4PpefGvPGqlwirM3QH+aLlZiEUaYqDvah ogMHHImgoYhcIK/vMxU8b9agi9QXL/dqMRZB3M6yzmcdEo/p8/NoiXitrwyy4vlOuvegX/yu1PE2I cxb+l3eofB+dBSQtgDuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovn4F-000ERn-Qf; Thu, 17 Nov 2022 22:09:07 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovn4C-000EQa-FF for linux-arm-kernel@lists.infradead.org; Thu, 17 Nov 2022 22:09:05 +0000 Received: by mail-pf1-x432.google.com with SMTP id k22so3112846pfd.3 for ; Thu, 17 Nov 2022 14:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=80Ru9KHRSz0WGI1wex7zKkXJKpbumnIV011Te9Odg64=; b=IHJ88W/cCwK+Xu7bl5imNHzCncAxevHPkXGTMFXm5Y57lGB8NSermeEcE3ENaRx6BJ 3jzofHeSp32+5CkhFu54T08/o7mkBCcVnwE7WNdK+0ZTGDBTeUHcBln+XLEiWsTXGbng WPYP56o0HFT8x4Wu6uVYhUDoD7yd9Ha1ryBKw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=80Ru9KHRSz0WGI1wex7zKkXJKpbumnIV011Te9Odg64=; b=IqDygrZh2AwiyIfWS4op8IhhXTLhXoU7Z8S8Z0DW5ZhCKIswrV5g9aJ8LxFYuGl4HO tOOBvP9Mc3QGfPWpZfq84AYGT43qwSEjAsQDLC/kcpD05qCzwku2lQl76Y6EWnwv4dp1 ZaM4c5OOFsodKmwcw48AacHPPdP1sKvk+pk1Ub8T5pc3uMw/yom02qUSJRs3jnnrlxVr nfqoDXIaUofsLfOW6jecBdld9XIzJfIhmgCbi2Bgb3qPfHT2eRCu64JPp4qTMnZc3pvF IX2wjCfZ1icgHKZ6Tg6nPp8Taq+8Lfxk8IetmaOhx8ruex3c7ca92ToEEJj5OMFM4sDm nZ4g== X-Gm-Message-State: ANoB5pmgZ5gK1A22ejlXzrcjY1WRPOXiBZaiMmfwmhSdTHV1GpIa6MGH Hqv7/D+EO2EhuAhcqcakcaXKCg== X-Google-Smtp-Source: AA0mqf5JHqQ4qT9OeLuGMq/ZVbDl7rx0pjA3XSGnuAKpS79EID69TJOnLN5eRbDR8/Sg1Vyd/tLCbg== X-Received: by 2002:a63:e14d:0:b0:46e:d655:60ab with SMTP id h13-20020a63e14d000000b0046ed65560abmr3904712pgk.533.1668722941686; Thu, 17 Nov 2022 14:09:01 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id u4-20020a17090341c400b001830ed575c3sm1943427ple.117.2022.11.17.14.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 14:09:01 -0800 (PST) Date: Thu, 17 Nov 2022 14:09:00 -0800 From: Kees Cook To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org Subject: Re: [PATCH 1/2] arm64: remove current_top_of_stack() Message-ID: <202211171408.D9C4DE6BA@keescook> References: <20221117120902.3974163-1-mark.rutland@arm.com> <20221117120902.3974163-2-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221117120902.3974163-2-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_140904_543894_AEEB2D9B X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 12:09:01PM +0000, Mark Rutland wrote: > We no longer use current_top_of_stack() on arm64, so it can be removed. > > We introduced current_top_of_stack() for STACKLEAK in commit: > > 0b3e336601b82c6a ("arm64: Add support for STACKLEAK gcc plugin") > > ... then we figured out the intended semantics were unclear, and > reworked it in commit: > > e85094c31ddb794a ("arm64: stackleak: fix current_top_of_stack()") > > ... then we removed the only user in commit: > > 0cfa2ccd285d98ad ("stackleak: rework stack high bound handling") > > Given that it's no longer used, and it's very easy to misuse, this patch > removes current_top_of_stack(). For the moment, on_thread_stack() is > left where it is as moving it will change some header dependencies. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel