From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FC82C433FE for ; Thu, 17 Nov 2022 22:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X5MB2cI5y24vgXrcdfgGvpvMf8IrP+Ai2fWb1var5Y0=; b=xM3exmN8Bw1Gx6 7e5zFi8vbhQCyQRMlKEWSQ7qbuLvpqBGasNKJ2n4IN9rG943NxRa1aMuADwj7a6W+9XApkwbvAHma wdWsaU/DP4CpqziJEgy4cV6S8DNbSemvflUJBuRAAVyycFMQ7rDYP1qi3tDfz9pFCtWPB1mz5JhjN KgpIfzxwMOoYxllrAGuR6nAH6t6A7sUHb3r19p/Lw+Pf75giIeOy0HZh5E6zXVzPFBiztFWuH5OHL Hry1BX7bfFw+mx1zlmYT6XrqSzinu2w8/UtHTwx4XolFZ39fNJZunURrXA4LYzu4n+iZhRoxSauGD AaCBXvcta41lXvKoONXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovn4u-000Eh6-Tg; Thu, 17 Nov 2022 22:09:49 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovn4s-000EfM-0B for linux-arm-kernel@lists.infradead.org; Thu, 17 Nov 2022 22:09:47 +0000 Received: by mail-pl1-x62f.google.com with SMTP id y4so2920012plb.2 for ; Thu, 17 Nov 2022 14:09:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J876mBKTbihmRI9UR5DvIeF/h8gTjBNejtcTcNG2xa8=; b=AH2XCb8T9ButWSgOv3pBWyi2n2zJnMbUWiZwTQ6bX3khXq2FtgT+YrxJ8bDgocsHAa W8LYBvnJA0zyQSjCrtubFlAEFpFDt5vASKK9zT6zjDNAxjwnofxcFsXDHhMS1ayn+Lq2 CE0RmBl1haLG4MsxAkc++5ipHU2an3E2Fb0Fw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J876mBKTbihmRI9UR5DvIeF/h8gTjBNejtcTcNG2xa8=; b=1x55u3/tbjdIHbKyPELo0jfOEzJ18RhcwnDjj5tbXu3VDJWMAS86UfKT732TnGmHCa wb6hKQgduCLEjWlikuBBSbuHj71RntSlpbk0ctJxEghQ0gne31RfnBw5/5Ke9LgfuKCk jJxlWECiCTfuMIr8/2r8bJtUBJ7ou5LOocFAmXNvaMFPy9gG0hu8H/SyfagLR6uQW2lm 2W2aJCUzdeCl1pzaDqX2bVLGzpplsM4TArkzuJQAO2mnxBlIouHoHauQafifU8D0zNC5 CqQGgWHBdQTfZnD3/5gdaKp+pYmAd6bSGckBu7wjzltwxcj1Xyz+YNsgqI+8HKU8ODIq tKYg== X-Gm-Message-State: ANoB5pkUZC+HZL0LX65t1SLUIDCSTigdAnJj2c9qodjPgIB9M/6dYqNw MAc47p2HYVTDbgqgnLiNi6sGke2dvMivcg== X-Google-Smtp-Source: AA0mqf6+SQBNJMI7PvclsXJaCoeQfuHB4XezBFYc6EUCDhn9HJyLNaupWroxP26gMwSNvQiR+6PcZA== X-Received: by 2002:a17:90b:4018:b0:205:ec5b:5dcf with SMTP id ie24-20020a17090b401800b00205ec5b5dcfmr10623839pjb.143.1668722983167; Thu, 17 Nov 2022 14:09:43 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id nd13-20020a17090b4ccd00b0020de216d0f7sm1396592pjb.18.2022.11.17.14.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 14:09:42 -0800 (PST) Date: Thu, 17 Nov 2022 14:09:42 -0800 From: Kees Cook To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org Subject: Re: [PATCH 2/2] arm64: move on_thread_stack() to Message-ID: <202211171409.8A31B2A724@keescook> References: <20221117120902.3974163-1-mark.rutland@arm.com> <20221117120902.3974163-3-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221117120902.3974163-3-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_140946_060322_8606F5EE X-CRM114-Status: GOOD ( 15.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 12:09:02PM +0000, Mark Rutland wrote: > Currently on_thread_stack() is defined in , depending > upon definitiong from despite this header not being > included. This ends up being fragile, and any user of on_thread_stack() > must include both and . > > We organised things this way due to header dependencies back in commit: > > 0b3e336601b82c6a ("arm64: Add support for STACKLEAK gcc plugin") > > ... but now that we no longer use current_top_of_stack(), and given that > stackleak includes via , we no > longer need the definition to live in . > > Move on_thread_stack() to , where all its dependencies > are guaranteed to be defined. This requires having arm64's irq.c > explicitly include , and I've taken the opportunity to > sort the includes, which were slightly out of order. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel