From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23A77C4332F for ; Sat, 19 Nov 2022 01:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vlC5ElIJixkNeHhsJD8o15kPyLfkADy+C37FAcKIEbc=; b=2tgzkjVw0+YdLk ekW6yRHuJX//wT6gIzrcJ4zkt/ftCt7P+K2oZerxwkCvqcCOzQKgaEm+RIHUU6gZANrZQrlbG7IRZ JvAgpqr+vGqxRPdtQFK20ixTBGY+JdGnthcl6abgYiebYdDxZkAGmAYvc+uEX62Tm8uRgqoMGojzQ N+NItC9+C3GnZkzSrz+eWbU4S8rK2sb6jtlw3LeU5pzXYLXIK/IRBOvskv1xL5CkDCOiBLyxUfMCM dCdi7lQDpKUrf/ny92RiNTOQbTkU6QNnWZDeC9g5+qq9vku+0sAvkOyycRkRa9xpyNEakEhtsxH5A t6PtmpoIa1ZBc9bU2dZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1owCr3-00A2q9-Os; Sat, 19 Nov 2022 01:41:13 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1owCr0-00A2lH-Ag for linux-arm-kernel@lists.infradead.org; Sat, 19 Nov 2022 01:41:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E7E8BB82661; Sat, 19 Nov 2022 01:41:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24F16C433D6; Sat, 19 Nov 2022 01:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668822067; bh=dlCBK5dMhB9d3GVIA0pD0qYoZC713KGHTS5GXLvDeYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rhjeifABc81j2OrJCTC/gsMXDs+zsk2IXWjZzumuNXNRJPxjbLSBgHvaGdJdoBbKt Q4/tRoyWxcWLDdME9XxrsIvgr1Y9sYljzHcmKhRAR3/oMsWYMjjXdx6IgwntVLt/oi r31eY1NUoQAfJUKwATfKMTrvEOnH/5eyPp5pAUi+duOCVfVYVMrg4OzbE3POCc6MQQ I/p30klitx5m0pQM/8kTtfRAZlwM9IJBlueCQJGTsR5VgEfLUNsGNkWBbzTT/k2Z7h Ny8fYlbr2ZQbQWUZsLGmypo7igU3jiG7v5nv6XQjXqIlTM9bNA01Oz9uSRLCbniVZj 5mYWYLLa7EC/w== Date: Sat, 19 Nov 2022 09:41:01 +0800 From: Shawn Guo To: Marco Felsch Cc: Zheng Yongjun , s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, festevam@gmail.com, linux-imx@nxp.com, kernel@pengutronix.de Subject: Re: [PATCH] ARM: mxs: fix memory leak in mxs_machine_init() Message-ID: <20221119014100.GA16229@T480> References: <20221117062011.84602-1-zhengyongjun3@huawei.com> <20221117091315.wwojwl7vhp43k63v@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221117091315.wwojwl7vhp43k63v@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_174110_649475_BBB30749 X-CRM114-Status: GOOD ( 10.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 10:13:15AM +0100, Marco Felsch wrote: > On 22-11-17, Zheng Yongjun wrote: > > If of_property_read_string() failed, 'soc_dev_attr' should be > > freed before return. Otherwise there is a memory leak. > > > > Fixes: 2046338dcbc6 ("ARM: mxs: Use soc bus infrastructure") > > Signed-off-by: Zheng Yongjun > > Reviewed-by: Marco Felsch Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel