From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19B29C4332F for ; Sat, 19 Nov 2022 10:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wld2WVtsAJ+/8VKbdxzwYoTWIlbhxQdUHR0uc5JxDK4=; b=CsiKYcHcl5YrcvJ/9NB6VXufEu E8R94YWLyCqxC1BXRA0nkBGkG3cNeSk6TbJhtXcRF3xVCLiTpOUs9A3gTuye9Dgg36y1M8utIJYtg oKgEUHEHpLGs0B6hBFqfn//wN0yCSYPR3fvW+GmsvbPAfI/I5wvSv41MSrfIiFMhFxJOD7sgMbveI 4HOCKlEg+VdRITPYaKhocROkGcXnwXJt7buBE2nmy9ax/7wLbRogsFnqLa/JMhiqq1rr8iBrGD+9T zTLjEBA8ObreVZN9MV5ERCB5zLuK+NZ8tbfwvLzJxMsC1plEVj6n1Qw9oYiZ2QSVl0jA2S2v9NErh rynS53rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1owLXH-00DCB5-NT; Sat, 19 Nov 2022 10:57:23 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1owLXE-00DCAO-Qm; Sat, 19 Nov 2022 10:57:22 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 396555C013C; Sat, 19 Nov 2022 05:57:20 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 19 Nov 2022 05:57:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1668855440; x=1668941840; bh=UYi9C6IaaZ ioVaoTtatSi/ezY/KuSuWAipoDncaQtSw=; b=x0P7l1jkb30Z8LOGNzKvuBE77L z3mtki6AnApaTgqxnUcwabvym1uihf3oYOvQOQBax6CGfS208No7KtL6GwZKOijt 3I5ZpmuAcbeG3iDmqBKaxqVpA/1fkAHpD1Wlh2XgVQKhUX4tBrx+CuWZVu1f4P0V ZKyFytHoqE/ecfh78FEto/CyW0DUvAo/q4QFvuFG5UVBzW2j9wvQiS6O6p1FuO7K FmFewnZtPKGU/Tncr2Ik90Sq5IJkZzSRb3CzJ+UDfuNumcha2pzk4AK3flydUBQB Hqq1/aDHgaYOKmbbykARp9GeGWMQngXaLAHCT2XFiuhbyPmtA5GGVyNjqm7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668855440; x=1668941840; bh=UYi9C6IaaZioVaoTtatSi/ezY/Ku SuWAipoDncaQtSw=; b=G96HHULYX4cJ7z5jPX/Y6cGqpx78nWKZUl0VuYionmAb zxyMAsmtL6wSiVj5Q04fK0mczXA901/mS1dIo3MLNiYqd5eKoFyrGG13uETWlg+m sjgzswGf64KCOKiiHA4a1Z9vSKxN5IeMpDZ6ZGofpXmhVq1kWzKnNtjL8NnHYtF2 UHBgCIAa4vxpxjnx++5JT1CTT6SPGgJj/m9mfdb9/oRGQrWtcC8ShToSjFhaEycc dzy1EzetDWRTM0q7phYDwbqVG0fdusLGh+RJ32B2UxNlpTDY3HSjT2dN0ssyqcj+ KVcTkXh49ac9H/wKQ3/Y2PtLbgisTKB6R+pQqXdgYg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedvgddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttdejnecuhfhrohhmpeffrghfnhgr ucfjihhrshgthhhfvghlugcuoegurghfnhgrsehfrghsthhmrghilhdrtghomheqnecugg ftrfgrthhtvghrnhepvdehtdeludekgeevleefuedvudejieetheekvdfhteekffdujefh fedtudehvdeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepuggrfhhnrgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i0e894699:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 19 Nov 2022 05:57:17 -0500 (EST) Date: Sat, 19 Nov 2022 12:57:14 +0200 From: Dafna Hirschfeld To: Paul Elder Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , Heiko Stuebner , Laurent Pinchart , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] media: rkisp1: Implement ENUM_FRAMESIZES Message-ID: <20221119105714.6ynnl2jvfwnb4flw@guri> References: <20221117084217.3892680-1-paul.elder@ideasonboard.com> <20221117084217.3892680-4-paul.elder@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221117084217.3892680-4-paul.elder@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221119_025720_954993_E1084910 X-CRM114-Status: UNSURE ( 9.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17.11.2022 17:42, Paul Elder wrote: >Implement VIDIOC_ENUM_FRAMESIZES for the rkisp1 capture devices. > >Signed-off-by: Paul Elder >Signed-off-by: Laurent Pinchart Reviewed-by: Dafna Hirschfeld >--- > .../platform/rockchip/rkisp1/rkisp1-capture.c | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > >diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c >index 91e685fdbbe9..03c2922bfbed 100644 >--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c >+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c >@@ -1236,6 +1236,35 @@ static int rkisp1_enum_fmt_vid_cap_mplane(struct file *file, void *priv, > return -EINVAL; > } > >+static int rkisp1_enum_framesizes(struct file *file, void *fh, >+ struct v4l2_frmsizeenum *fsize) >+{ >+ static const unsigned int max_widths[] = { >+ RKISP1_RSZ_MP_SRC_MAX_WIDTH, >+ RKISP1_RSZ_SP_SRC_MAX_WIDTH, >+ }; >+ static const unsigned int max_heights[] = { >+ RKISP1_RSZ_MP_SRC_MAX_HEIGHT, >+ RKISP1_RSZ_SP_SRC_MAX_HEIGHT, >+ }; >+ struct rkisp1_capture *cap = video_drvdata(file); >+ >+ if (fsize->index != 0) >+ return -EINVAL; >+ >+ fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE; >+ >+ fsize->stepwise.min_width = RKISP1_RSZ_SRC_MIN_WIDTH; >+ fsize->stepwise.max_width = max_widths[cap->id]; >+ fsize->stepwise.step_width = 2; >+ >+ fsize->stepwise.min_height = RKISP1_RSZ_SRC_MIN_HEIGHT; >+ fsize->stepwise.max_height = max_heights[cap->id]; >+ fsize->stepwise.step_height = 2; >+ >+ return 0; >+} >+ > static int rkisp1_s_fmt_vid_cap_mplane(struct file *file, > void *priv, struct v4l2_format *f) > { >@@ -1285,6 +1314,7 @@ static const struct v4l2_ioctl_ops rkisp1_v4l2_ioctl_ops = { > .vidioc_s_fmt_vid_cap_mplane = rkisp1_s_fmt_vid_cap_mplane, > .vidioc_g_fmt_vid_cap_mplane = rkisp1_g_fmt_vid_cap_mplane, > .vidioc_enum_fmt_vid_cap = rkisp1_enum_fmt_vid_cap_mplane, >+ .vidioc_enum_framesizes = rkisp1_enum_framesizes, > .vidioc_querycap = rkisp1_querycap, > .vidioc_subscribe_event = v4l2_ctrl_subscribe_event, > .vidioc_unsubscribe_event = v4l2_event_unsubscribe, >-- >2.35.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel