From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40E36C4332F for ; Tue, 22 Nov 2022 17:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ywqKzmqfKTLRmbfncSNC3uKKf6uOSsv9tyTrjf4nfHM=; b=rsBugRXMHlwE7f quFugbP3bRrO1V6ZMWwsChaYvEmV+qcRx0GoKtXLw+o+CRs2eu8cPzuKYojwMahnUL3eRJNX78eK1 ++u3FletiQnLc+fHMOvM4mIpHQ0FS/SottReRoDg0EVEqxSg+Usqnul8HKcPD/xe6M/KQ8FDC0xTf L/Od+UOCHF4F78SfbnLCVf+JyLJh8C1xFw3Z7C1YGI9Y4NXC93ZZWZU2PWwDthGjOsAbdZCmdYy11 x0nmneUqDOHq3XKzLOSEwmG8tV3Kv5GKI8bFNU7gx9DSfgsWiGmdffKqy3iqnrG7yzIz2K98GZN1c AG+mmjsJmwTVY9VkCJcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxWhZ-00Avux-GT; Tue, 22 Nov 2022 17:04:53 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxWhJ-00Avl5-EZ for linux-arm-kernel@lists.infradead.org; Tue, 22 Nov 2022 17:04:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D943DCE1EA3; Tue, 22 Nov 2022 17:04:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65BB0C433C1; Tue, 22 Nov 2022 17:04:32 +0000 (UTC) Date: Tue, 22 Nov 2022 12:04:30 -0500 From: Steven Rostedt To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org Subject: Re: [PATCH] ftrace: arm64: remove static ftrace Message-ID: <20221122120430.6932d29c@gandalf.local.home> In-Reply-To: <20221122163624.1225912-1-mark.rutland@arm.com> References: <20221122163624.1225912-1-mark.rutland@arm.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_090437_714022_C1010D68 X-CRM114-Status: GOOD ( 18.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 22 Nov 2022 16:36:24 +0000 Mark Rutland wrote: > The build test robot pointer out that there's a build failure when: > > CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS=y > CONFIG_DYNAMIC_FTRACE_WITH_ARGS=n > > ... due to some mismatched ifdeffery, some of which checks > CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS, and some of which checks > CONFIG_DYNAMIC_FTRACE_WITH_ARGS, leading to some missing definitions expected > by the core code when CONFIG_DYNAMIC_FTRACE=n and consequently > CONFIG_DYNAMIC_FTRACE_WITH_ARGS=n. > > There's really not much point in supporting CONFIG_DYNAMIC_FTRACE=n (AKA > static ftrace). All supported toolchains allow us to implement > DYNAMIC_FTRACE, distributions all prefer DYNAMIC_FTRACE, and both > powerpc and s390 removed support for static ftrace in commits: > > 0c0c52306f4792a4 ("powerpc: Only support DYNAMIC_FTRACE not static") > 5d6a0163494c78ad ("s390/ftrace: enforce DYNAMIC_FTRACE if FUNCTION_TRACER is selected") > > ... and according to Steven, static ftrace is only supported on x86 to > allow testing that the core code still functions in this configuration. > > Given that, let's simplify matters by removing arm64's support for > static ftrace. This avoids the problem originally reported, and leaves > us with less code to maintain. > > Fixes: 26299b3f6ba26bfc ("ftrace: arm64: move from REGS to ARGS") > Link: https://lore.kernel.org/r/202211212249.livTPi3Y-lkp@intel.com > Suggested-by: Steven Rostedt > Signed-off-by: Mark Rutland > Cc: Will Deacon > Cc: Catalin Marinas Acked-by: Steven Rostedt (Google) -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel