From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C147C4332F for ; Tue, 22 Nov 2022 16:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WBiEUh8+ss5fg/hAcvg7oxNqenWTrrtP9Xtx8G9Wj74=; b=ZPARiwTVUS/fVD KJY0KBVi5UxHT8d2q56LbFnwV2an1Yan+wwhw+VFziAXklqBQxMOwJ/xEjSuRFc6EG6hDqZjJlFaM fmzeL89PJCDE3HRhHGrf4utDu1psKZNUPeCnhxlzeSR3E5INyu0vJNBVPJkkyr6o5FryMEPWrNUJB F9Ln+WMWiV/GabncRF6H9WGqhSwG7rYYcHsX9mfcRL7Q7LB6gPycYDBxUVnNPBY/X76SVt9+U4Ap1 qkigE97zO188lgEufssoPP61fEF7ozJ0MUD4PPTH+Q6b8BPo+PLBHXEVDiJ5twfk1T6w4HMx7UgYb GxDdFCmj7A4zNSja2Kdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxVqL-00AbxF-52; Tue, 22 Nov 2022 16:09:54 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxVqB-00Abrp-9g for linux-arm-kernel@lists.infradead.org; Tue, 22 Nov 2022 16:09:46 +0000 Received: by mail-wm1-x32f.google.com with SMTP id t25-20020a1c7719000000b003cfa34ea516so1257237wmi.1 for ; Tue, 22 Nov 2022 08:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MB7sh8EfMeiMpT6eyk0gEECQb5t5VgXPL9obUDUw5Sc=; b=mVDeJYEkvQC6eWfFWLtGuUF637u9WsgKRxpLDgfw8QzLz9JsB+URj8WuFMXEpz0Mww MgAp+g9ay+YEVSueITnwwqqtN1rWa9OS5/0GRbDdcdgvJMy03n/QJcQeAN3jezT1z6pt oX06q0G9b/lvpcLBRVF1Ia3e5YoQVkUIcPjO0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MB7sh8EfMeiMpT6eyk0gEECQb5t5VgXPL9obUDUw5Sc=; b=y5Di03xgBl4rCwr1uLwy2PaZwjLn5BEd65bQyzYkVYgqNO7z12DT1bioA985S9m6y4 MLZzuH3xCluTh1bXsLc00EyJ4BRhP5dgtYeaGyR7LewuT0RUGNjxHNQNgmUDNs337Xp6 gA3EQ9w7orNjU/YvWs++WCNAcksCsMxuC45oiou9qtNyLlKlVXL5W0La8BZN7HUApbCO bS1J2LK424vzQW3Ory+ui64JJA3gvFPq26CxqW1OFuDc5IaxC+J1P/lqoXv6LeodZlHA DHz2sq8hqhbIgbXAHqHZTZHUbVdGFueI9aVmkhJ+bsoRjOjqZ3se5ZZ15ZfIdukfykhE ivOw== X-Gm-Message-State: ANoB5plDcQH0z2CczH2Vg9W2tnXo5B80iNIsaXr1eqUECx2X8+dUvBS7 un0wRowyM6nsM9ISFLprGOYZzQ== X-Google-Smtp-Source: AA0mqf5NtqJ76RIotfZLCAGTg2jm4dfBI9IjABHCpRidd+mpCKzKmdG8CWw7n5MGPzF5JoVww0RHxg== X-Received: by 2002:a1c:7404:0:b0:3cf:b091:e5a1 with SMTP id p4-20020a1c7404000000b003cfb091e5a1mr16700981wmc.44.1669133380511; Tue, 22 Nov 2022 08:09:40 -0800 (PST) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-55-94.cust.vodafonedsl.it. [188.217.55.94]) by smtp.gmail.com with ESMTPSA id n24-20020a7bcbd8000000b003b4fdbb6319sm22345740wmi.21.2022.11.22.08.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 08:09:39 -0800 (PST) Date: Tue, 22 Nov 2022 17:09:37 +0100 From: Tommaso Merciai To: Lukas Bulwahn Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: imx: remove code for non-existing config IMX_GPT_ICAP Message-ID: <20221122160937.GB39395@tom-ThinkPad-T14s-Gen-2i> References: <20221122132330.30408-1-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221122132330.30408-1-lukas.bulwahn@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_080943_420356_8E186D62 X-CRM114-Status: GOOD ( 24.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lukas, On Tue, Nov 22, 2022 at 02:23:30PM +0100, Lukas Bulwahn wrote: > There never was a config IMX_GPT_ICAP in the repository. So remove the code > conditional on this config and simplify the callers that just called empty > functions. > > Signed-off-by: Lukas Bulwahn > --- > drivers/staging/media/imx/imx-media-fim.c | 54 ----------------------- > 1 file changed, 54 deletions(-) > > diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c > index 3a9182933508..19a48eb445fd 100644 > --- a/drivers/staging/media/imx/imx-media-fim.c > +++ b/drivers/staging/media/imx/imx-media-fim.c > @@ -187,54 +187,6 @@ static void frame_interval_monitor(struct imx_media_fim *fim, > send_fim_event(fim, error_avg); > } > > -#ifdef CONFIG_IMX_GPT_ICAP > -/* > - * Input Capture method of measuring frame intervals. Not subject > - * to interrupt latency. > - */ > -static void fim_input_capture_handler(int channel, void *dev_id, > - ktime_t timestamp) > -{ > - struct imx_media_fim *fim = dev_id; > - unsigned long flags; > - > - spin_lock_irqsave(&fim->lock, flags); > - > - frame_interval_monitor(fim, timestamp); > - > - if (!completion_done(&fim->icap_first_event)) > - complete(&fim->icap_first_event); > - > - spin_unlock_irqrestore(&fim->lock, flags); > -} > - > -static int fim_request_input_capture(struct imx_media_fim *fim) > -{ > - init_completion(&fim->icap_first_event); > - > - return mxc_request_input_capture(fim->icap_channel, > - fim_input_capture_handler, > - fim->icap_flags, fim); > -} > - > -static void fim_free_input_capture(struct imx_media_fim *fim) > -{ > - mxc_free_input_capture(fim->icap_channel, fim); > -} > - > -#else /* CONFIG_IMX_GPT_ICAP */ > - > -static int fim_request_input_capture(struct imx_media_fim *fim) > -{ > - return 0; > -} > - > -static void fim_free_input_capture(struct imx_media_fim *fim) > -{ > -} > - > -#endif /* CONFIG_IMX_GPT_ICAP */ > - > /* > * In case we are monitoring the first frame interval after streamon > * (when fim->num_skip = 0), we need a valid fim->last_ts before we > @@ -435,14 +387,8 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim, > spin_unlock_irqrestore(&fim->lock, flags); > > if (icap_enabled(fim)) { > - ret = fim_request_input_capture(fim); > - if (ret) > - goto out; > fim_acquire_first_ts(fim); > } As suggested by the checkpatch.pl: WARNING: braces {} are not necessary for single statement blocks > - } else { > - if (icap_enabled(fim)) > - fim_free_input_capture(fim); > } > > fim->stream_on = on; > -- > 2.17.1 > Apart of this, patch looks good to me. Thanks. Regards, Tommaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel