From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC5CCC4332F for ; Tue, 22 Nov 2022 22:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w8HBeUIZR2LKXY3mgo7yx3QnThjmFtR4Eq7AVzGhxjc=; b=ZySYr9QzvBliER g27jF0W75kUnTs8wYOMIUG5mMHr2lhPJ3k1/tmPuP+QJn3l2MTKWK7GOWizK8+Y7D5QhrSJkaBHZD aAUbkbEeQK7pnyHmAJSdYsnD5vPhb1o0Azr8Y8Ku99/Uv6oKN9G4TZM0MmN529JE8cyNFImLW9CY/ wLmPDkPJmzxa/TOSAY+/+0mfHzkghWtmezTFgbay6AYP0rmgUQQPesd447EPDIKrOp4xPbv8M/omH lFtj6hJXPWUVPjnic5CfpZR8+a17R8z/EkK0dofqi8e9JNWlPZI1iYzmjb4cdDx4gfmgSvjJOpNRE Gf96FvCs5POqiqcTLikA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxbwz-00CBZe-Ci; Tue, 22 Nov 2022 22:41:09 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxbww-00CBYr-5D for linux-arm-kernel@lists.infradead.org; Tue, 22 Nov 2022 22:41:07 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2AMMf2u5114514; Tue, 22 Nov 2022 16:41:02 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1669156862; bh=FVSNJYAF6x9Zrz7oPPeq6zFHcpkG3DTdVSTIsHxVqIs=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=uoZISZtVp65h2PbP+87H2FuY7BYO3k/lCDybFhkVtZmvUxNNX2ZRoRbk3nOGQa53w oj9FCgg94a8TsxfxgulG0DrwwHWR87yJoMwxAVEBiz0Boh8hq7LaH0TLP9ZpEjG84H ZYMzuzzd3ybrJOdDKANI9h2VDoFPnP0IuOjlUt5Q= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2AMMf2hl014428 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 22 Nov 2022 16:41:02 -0600 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 22 Nov 2022 16:41:02 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 22 Nov 2022 16:41:02 -0600 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2AMMf2wm017651; Tue, 22 Nov 2022 16:41:02 -0600 Date: Tue, 22 Nov 2022 16:41:02 -0600 From: Nishanth Menon To: Kevin Hilman CC: , , , Santosh Shilimkar , Subject: Re: [PATCH v6 0/2] soc: ti: k3-socinfo: Add module build support to the k3 socinfo driver Message-ID: <20221122224102.xchwn5d3k64bedgj@antitoxic> References: <20221117095419.171906-1-nfrayer@baylibre.com> <166906774215.20855.4956750581421635106.b4-ty@ti.com> <7ha64iaf6t.fsf@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7ha64iaf6t.fsf@baylibre.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_144106_302434_5FEB584F X-CRM114-Status: GOOD ( 25.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12:48-20221122, Kevin Hilman wrote: > Hi Nishanth, > > Nishanth Menon writes: > > > Hi Nicolas Frayer, > > > > On Thu, 17 Nov 2022 10:54:17 +0100, Nicolas Frayer wrote: > >> In order for the TI K3 SoC info driver to be built as a module, the > >> following changes have been made: > >> - Converted memory allocations to devm and added the remove callback > >> - Added necessary code to build the driver as a module > >> > >> v2->v3: > >> dropped module conversion part of this series while other driver > >> dependencies on socinfo are worked out. > >> A dependency issue is introduced by changing subsys_initcall() > >> to module_platform_driver(). Some drivers using the socinfo information > >> probe before the socinfo driver itself and it makes their probe fail. > >> > >> [...] > > > > I have applied the following to branch ti-drivers-soc-next on [1]. > > Thank you! > > Sorry for the churn here, but I think these need to be reverted. > > We've discoverd some more complexities/issues when socinfo is modular, > and I think the socinfo core code needs some work before this can > actually work reliably for all socinfo users. > > Basically, I think we need to finish converting all the socinfo users to > modules before we can be sure of all the corner cases when socinfo > itself is a module. > > Sorry about this churn, but I think it's better to be a bit conservative > here and revert before this lands in mainline. Understood, and thanks for the headsup and explanation offline (explains why I had'nt caught it in my regression checks). I have dropped the series (since we managed to catch it just in time before arnd picked it up), updated the next and send out a new PR. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel