* [PATCH 2/3] arm64: dts: imx8qxp-ai_ml: Remove invalid linux,default-trigger
2022-11-21 14:51 [PATCH 1/3] arm64: dts: imx8mq-thor96: Remove invalid linux,default-trigger Fabio Estevam
@ 2022-11-21 14:51 ` Fabio Estevam
2022-11-21 14:51 ` [PATCH 3/3] arm64: dts: imx8mm-emcon: Change LED node names Fabio Estevam
2022-11-23 8:00 ` [PATCH 1/3] arm64: dts: imx8mq-thor96: Remove invalid linux,default-trigger Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-11-21 14:51 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel,
Fabio Estevam, Manivannan Sadhasivam
From: Fabio Estevam <festevam@denx.de>
"none", "phy0tx" and "hci0-power" are not valid values for the
linux,default-trigger property and trigger the following warnings when
running:
make dtbs_check DT_SCHEMA_FILES=leds-gpio.yaml
DTC_CHK arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb
arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb: leds: user-led2:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'none' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
'none' does not match '^mmc[0-9]+$'
'none' does not match '^cpu[0-9]*$'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb: leds: user-led4:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'none' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
'none' does not match '^mmc[0-9]+$'
'none' does not match '^cpu[0-9]*$'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb: leds: wlan-active-led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
'phy0tx' does not match '^mmc[0-9]+$'
'phy0tx' does not match '^cpu[0-9]*$'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dtb: leds: bt-active-led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
'hci0-power' does not match '^mmc[0-9]+$'
'hci0-power' does not match '^cpu[0-9]*$'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
Remove the invalid linux,default-trigger entries.
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fixes: 56838644f9dd ("arm64: dts: freescale: Add support for i.MX8QXP AI_ML board")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts b/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
index 7d00e17f0447..233dea6dde22 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dts
@@ -41,7 +41,6 @@ user-led1 {
user-led2 {
label = "green:user2";
gpios = <&lsio_gpio0 6 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "none";
};
user-led3 {
@@ -55,20 +54,17 @@ user-led4 {
label = "green:user4";
gpios = <&lsio_gpio4 21 GPIO_ACTIVE_HIGH>;
panic-indicator;
- linux,default-trigger = "none";
};
wlan-active-led {
label = "yellow:wlan";
gpios = <&lsio_gpio4 17 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "phy0tx";
default-state = "off";
};
bt-active-led {
label = "blue:bt";
gpios = <&lsio_gpio4 18 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "hci0-power";
default-state = "off";
};
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/3] arm64: dts: imx8mm-emcon: Change LED node names
2022-11-21 14:51 [PATCH 1/3] arm64: dts: imx8mq-thor96: Remove invalid linux,default-trigger Fabio Estevam
2022-11-21 14:51 ` [PATCH 2/3] arm64: dts: imx8qxp-ai_ml: " Fabio Estevam
@ 2022-11-21 14:51 ` Fabio Estevam
2022-11-23 8:00 ` [PATCH 1/3] arm64: dts: imx8mq-thor96: Remove invalid linux,default-trigger Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-11-21 14:51 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-arm-kernel,
Fabio Estevam, Reinhold Mueller
From: Fabio Estevam <festevam@denx.de>
'green' an 'red' are not valid names for the LED nodes and
give the following warnings when running:
make dtbs_check DT_SCHEMA_FILES=leds-gpio.yaml
DTC_CHK arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb
arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb: leds: 'green', 'red' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
Change them to led-0 and led-1 instead.
Cc: Reinhold Mueller <reinhold.mueller@emtrion.com>
Fixes: 2449d0440a2b ("arm64: dts: imx8mm: Add support for emtrion emCON-MX8M Mini")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
index 0dbdc9ec3fe5..421f0aa317c7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
@@ -18,14 +18,14 @@ som_leds: leds {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpio_led>;
- green {
+ led-0 {
label = "som:green";
gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
default-state = "on";
linux,default-trigger = "heartbeat";
};
- red {
+ led-1 {
label = "som:red";
gpios = <&gpio5 10 GPIO_ACTIVE_HIGH>;
default-state = "off";
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/3] arm64: dts: imx8mq-thor96: Remove invalid linux,default-trigger
2022-11-21 14:51 [PATCH 1/3] arm64: dts: imx8mq-thor96: Remove invalid linux,default-trigger Fabio Estevam
2022-11-21 14:51 ` [PATCH 2/3] arm64: dts: imx8qxp-ai_ml: " Fabio Estevam
2022-11-21 14:51 ` [PATCH 3/3] arm64: dts: imx8mm-emcon: Change LED node names Fabio Estevam
@ 2022-11-23 8:00 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2022-11-23 8:00 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh+dt, krzysztof.kozlowski+dt, devicetree,
linux-arm-kernel, Fabio Estevam
On Mon, Nov 21, 2022 at 11:51:12AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> "none", "phy0tx" and "hci0-power" are not valid values for the
> linux,default-trigger property and trigger the following warnings when
> running:
>
> make dtbs_check DT_SCHEMA_FILES=leds-gpio.yaml
>
> arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb: leds: user-led4:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 'none' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 'none' does not match '^mmc[0-9]+$'
> 'none' does not match '^cpu[0-9]*$'
> From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb: leds: wlan-active-led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 'phy0tx' does not match '^mmc[0-9]+$'
> 'phy0tx' does not match '^cpu[0-9]*$'
> From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb: leds: bt-active-led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 'hci0-power' does not match '^mmc[0-9]+$'
> 'hci0-power' does not match '^cpu[0-9]*$'
> From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
>
> Remove the invalid linux,default-trigger entries.
>
Just because the binding is complaining doesn't mean that these triggers are
invalid. In this case, the binding needs to be updated as these triggers are
supported by the LED subsystem.
I tried to do that but somehow didn't follow up:
https://lore.kernel.org/lkml/20201210082449.30586-1-manivannan.sadhasivam@linaro.org/
Let me revive that patch.
Thanks,
Mani
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Fixes: 68ca364d4812 ("arm64: dts: freescale: Add devicetree support for Thor96 board")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-thor96.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
> index 5d5aa6537225..170e00c2447f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
> @@ -35,7 +35,6 @@ user-led1 {
> user-led2 {
> label = "green:user2";
> gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>;
> - linux,default-trigger = "none";
> };
>
> user-led3 {
> @@ -49,20 +48,17 @@ user-led4 {
> label = "green:user4";
> gpios = <&gpio4 29 GPIO_ACTIVE_HIGH>;
> panic-indicator;
> - linux,default-trigger = "none";
> };
>
> wlan-active-led {
> label = "yellow:wlan";
> gpios = <&gpio4 1 GPIO_ACTIVE_HIGH>;
> - linux,default-trigger = "phy0tx";
> default-state = "off";
> };
>
> bt-active-led {
> label = "blue:bt";
> gpios = <&gpio4 0 GPIO_ACTIVE_HIGH>;
> - linux,default-trigger = "hci0-power";
> default-state = "off";
> };
> };
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread