From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E1C2C4332F for ; Wed, 23 Nov 2022 10:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=oH7BZ5fg2UaIwhPnwZtg92L3fmZ+WrOKIOglpSUZyKM=; b=treoaEBJjVhGl6 h0S+Miy1ypQavL5X4H4FhBOgJJne7BRvCWOWoe9ooc/NQkWv5x0OQPFtfRm0gKi7j+TEQaSEEpwgT lz2QyymjXtt4ND7nzVl1ck9BuVMw5+nLj8ac9ToP96q4cC08iOCoIjFsVvB0OHB5CvCoeJAWVsyLF vnsExXQBjjUTSo+mChD33KvSu6EsN7XiuHqqJhgpMf3DS01jR8n/qEvo550TurJPQxkZuM/uDXODy eS9BrgJ1zUeS2p+bF8oyNA7TgyaXG+wrSxAbEkYAfWFo5tvWXgnvq4SkqmVVC8gNClnjDXiRvHUgh tFBvixGPzc3eelCC4lqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxmwx-00GLfQ-29; Wed, 23 Nov 2022 10:25:51 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxmwu-00GLR6-FF for linux-arm-kernel@bombadil.infradead.org; Wed, 23 Nov 2022 10:25:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:Message-ID: Date:Subject:CC:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=IEj8MjclYGlm/F8/2v58yoD9tcwFQ5x+mP2vU7x4EFM=; b=OZBkA3wI4klYPPQpghSzN5z1Ut 4uTQYG0Yu+LdFfyvfW1GQE5OWImV8AWAXkwmDOSo/LiKpcUGRChRgXQU9r13aD1EwRO+x27F+bH6p LBQ5L44+PXkSSS3RYe9Pma4Vqxh5J4SbA6X2nG6PeEVX9aRc7+8Kf2TT6CWPII0j/iWC9UfkgYqMp Ux8zWtD6f92dz+Y1CajiYQVq0EHiQIeTe8Ben/JlACYDt9VF9idw98WEBEpf2/5phnj07qJmMnr23 ZApPqbZ50pDdYw15wWX1sUNxRT04JAF9JSv4Yd/wep2DwS4YqGnoWUaOdvuuYveb2XoIEmJcUyky6 p1VKXyww==; Received: from szxga01-in.huawei.com ([45.249.212.187]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxmJ1-003jzc-Ch for linux-arm-kernel@lists.infradead.org; Wed, 23 Nov 2022 09:44:38 +0000 Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NHGLs2qtXzqSY8; Wed, 23 Nov 2022 17:40:05 +0800 (CST) Received: from huawei.com (10.175.112.208) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 23 Nov 2022 17:44:00 +0800 From: Yuan Can To: , , , , , , , , , , , CC: Subject: [PATCH] bus: sunxi-rsb: Fix error handling in sunxi_rsb_init() Date: Wed, 23 Nov 2022 09:42:00 +0000 Message-ID: <20221123094200.12036-1-yuancan@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_094436_228572_A8C8AD10 X-CRM114-Status: GOOD ( 10.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The sunxi_rsb_init() returns the platform_driver_register() directly without checking its return value, if platform_driver_register() failed, the sunxi_rsb_bus is not unregistered. Fix by unregister sunxi_rsb_bus when platform_driver_register() failed. Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus") Signed-off-by: Yuan Can --- drivers/bus/sunxi-rsb.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c index 4cd2e127946e..87b10011667c 100644 --- a/drivers/bus/sunxi-rsb.c +++ b/drivers/bus/sunxi-rsb.c @@ -853,7 +853,13 @@ static int __init sunxi_rsb_init(void) return ret; } - return platform_driver_register(&sunxi_rsb_driver); + ret = platform_driver_register(&sunxi_rsb_driver); + if (ret) { + bus_unregister(&sunxi_rsb_bus); + return ret; + } + + return 0; } module_init(sunxi_rsb_init); -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel