From: Sudeep Holla <sudeep.holla@arm.com>
To: Wang Honghui <honghui.wang@ucas.com.cn>
Cc: Cristian Maruss <cristian.marussi@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm_scpi: modify to support acpi
Date: Thu, 24 Nov 2022 11:10:15 +0000 [thread overview]
Message-ID: <20221124111015.vrfuroty4fbemqv7@bogus> (raw)
In-Reply-To: <F813BC8072CDDB25+Y38Yq2QKFefSupZV@TP-P15V.lan>
Hi Wang,
On Thu, Nov 24, 2022 at 03:09:31PM +0800, Wang Honghui wrote:
> arm_scpi: modify to support acpi
>
1. The commit message is pretty useless. I don't get the complete picture
of why you need this change or what you are trying to do in this change.
2. I am unable to see the series as a whole, just have 2 versions of 3/3
in my inbox.
3. This is not the correct way to use SCPI or mailbox in ACPI. You need
to use PCC and PCC OpRegion to achieve what you want. The whole SCPI
protocol details gets abstracted in the firmware(ACPI ASL)
Hope this helps. So in short, NACK for this approach for ACPI.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-24 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 7:09 [PATCH 3/3] arm_scpi: modify to support acpi Wang Honghui
2022-11-24 11:03 ` Mark Rutland
2022-11-24 12:23 ` 王洪辉
2022-11-24 13:46 ` Sudeep Holla
2022-11-24 11:10 ` Sudeep Holla [this message]
2022-11-25 1:20 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221124111015.vrfuroty4fbemqv7@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=honghui.wang@ucas.com.cn \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox