From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9295CC43219 for ; Thu, 24 Nov 2022 11:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C0HDyqMdRVbAgLwr/taiDr+B4Jcf4YmTXWkxzioz+2o=; b=0FJnUHMfN1ipSD NCt9eVXRIFGp1ATd/qJtClouI/ZLHmGPCbrEIGJFcbVJSDXpth3J2P+jkaHhxx50ki7SbLi+Gksx5 nopCGljD4FQ3uNr+ASVdAd4aFXX255U7GvOEFFv7p0eI0y69mtlQ8eWAl4zhHB2uUgcl/LY3UsRhC TFXEX/Trw4ZwEg28uBLJkZrGj5RqtOa47/Ofxkyv2Ke0yWyzdUAWZRh1z6Y7Q9ew6NY+YrJ3C5XgL 88u8BDQAEq4yIAyD17UfPpNOE4s/R5xgy/SZuLy8BMXmjjTW2aCvuFa/+iUeKlH1xKdW7i/qrvWc8 1ROn3Asfl6qAfwf3y66A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyAC3-007y47-M2; Thu, 24 Nov 2022 11:14:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyABy-007y1m-JJ for linux-arm-kernel@lists.infradead.org; Thu, 24 Nov 2022 11:14:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D622E106F; Thu, 24 Nov 2022 03:14:59 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB42C3F587; Thu, 24 Nov 2022 03:14:52 -0800 (PST) Date: Thu, 24 Nov 2022 11:14:50 +0000 From: Sudeep Holla To: Wang Honghui Cc: Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 3/3] arm_scpi: Rev last modify to support acpi Message-ID: <20221124111450.mqfpmatba6f7pap6@bogus> References: <566DA2F800E4BACA+Y39Ak8xtNJaBqB90@TP-P15V.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <566DA2F800E4BACA+Y39Ak8xtNJaBqB90@TP-P15V.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221124_031454_705534_272AC781 X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 24, 2022 at 05:59:47PM +0800, Wang Honghui wrote: > Rev last modify to support acpi > > Signed-off-by: Wang Honghui > --- > drivers/firmware/arm_scpi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c > index e2e90dcc38bd..aca0a9780c12 100644 > --- a/drivers/firmware/arm_scpi.c > +++ b/drivers/firmware/arm_scpi.c > @@ -908,7 +908,9 @@ static const struct of_device_id shmem_of_match[] __maybe_unused = { > { } > }; > > +#ifdef CONFIG_PHYTIUM_MBOX > extern struct mbox_chan *phytium_mbox_request_channel(struct mbox_client *cl); > +#endif I have already NACK the approach you have taken for SCPI + ACPI. Just forgot to mention SCPI is old and deprecated protocol and SCMI replaced it. You much be using that if possible. Anyways, this kind of #ifdeffery is not allowed in any generic code even if I agreed with the approach. So please don't change the code in such a way. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel